New issue
Advanced search Search tips

Issue 781855 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Roll CLs cause too much spam for roll sheriffs

Project Member Reported by serg...@chromium.org, Nov 6 2017

Issue description

We should run first try as a CQ dry run to avoid spamming developers on first error. In the last 4 months, there were only 17 CLs that landed from 3rd try, so if we dry run the first try, we'll only be getting ~4.25 spam emails per month.

We could increase the number of dry runs to 2, but then we'll be increasing time from the moment CL fails to the point when sheriff is notified, which we'd like to avoid.
 
Components: Infra>Client>V8
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ac48a9bdbddde5ba94ba6f0038f8acc6f29faf12

commit ac48a9bdbddde5ba94ba6f0038f8acc6f29faf12
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Nov 07 15:42:00 2017

[tools] Trigger dry run on upload for auto-roller CLs

R=machenbach@chromium.org

Bug:  chromium:781855 
Change-Id: I919bd1340fa075819777ed685dbce88a0008d245
Reviewed-on: https://chromium-review.googlesource.com/756837
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49197}
[modify] https://crrev.com/ac48a9bdbddde5ba94ba6f0038f8acc6f29faf12/tools/release/auto_roll.py
[modify] https://crrev.com/ac48a9bdbddde5ba94ba6f0038f8acc6f29faf12/tools/release/git_recipes.py
[modify] https://crrev.com/ac48a9bdbddde5ba94ba6f0038f8acc6f29faf12/tools/release/test_scripts.py

Status: Fixed (was: Started)

Sign in to add a comment