New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781849 link

Starred by 1 user
Status: Verified
Owner:
█ sha...@chromium.org
Last visit > 30 days ago
Closed: Nov 2017
Cc:
aaboagye@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

ec: bd9995x: Fix port# / {VBUS,VCC} mapping

Project Member Reported by sha...@chromium.org, Nov 6 2017 
This is broken in a few places, but nobody has noticed since all of our boards are port 0 = VBUS, port 1 = VCC. I'm going to assume that all designs going forward will use the same config (I'll document it of course), which will allow us to remove bd9995x_pd_port_to_chg_port() and simplify the driver quite a bit.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/f4ee6caa665009ca3306f61706074b82e1e2c347

commit f4ee6caa665009ca3306f61706074b82e1e2c347
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Tue Nov 07 20:17:43 2017

bd9995x: Use fixed PD-port-to-VBUS/VCC mapping

The bd9995x driver was written to allow any PD port # to be VBUS or VCC,
but the mapping is broken in a few places. Since all boards use VBUS =
port 0, remove the conversion entirely.

BUG= chromium:781849 
BRANCH=kevin
TEST=Verify PD and BC1.2 charging still works on kevin.

Change-Id: I3687866835d1684342d9f746d91b3a6079ab5cc4
Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/755000
Commit-Ready: Shawn N <shawnn@chromium.org>
Tested-by: Shawn N <shawnn@chromium.org>
Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>

[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/eve/usb_pd_policy.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/include/config.h
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/eve/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/driver/charger/bd9995x.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/coral/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/nefario/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/kevin/usb_pd_policy.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/driver/charger/bd9995x.h
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/reef/usb_pd_policy.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/reef/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/nefario/usb_pd_policy.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/kevin/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/reef_it8320/board.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/reef_it8320/usb_pd_policy.c
[modify] https://crrev.com/f4ee6caa665009ca3306f61706074b82e1e2c347/board/coral/usb_pd_policy.c

Comment 2 by sha...@chromium.org, Nov 7 2017

Status: Verified (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 12 2018

Labels: merge-merged-firmware-eve-9584.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/ec/+/a10d039c5498a1b2a3a655a511b443ce5b1707d5

commit a10d039c5498a1b2a3a655a511b443ce5b1707d5
Author: Shawn Nematbakhsh <shawnn@chromium.org>
Date: Mon Feb 12 19:49:20 2018

bd9995x: Use fixed PD-port-to-VBUS/VCC mapping

The bd9995x driver was written to allow any PD port # to be VBUS or VCC,
but the mapping is broken in a few places. Since all boards use VBUS =
port 0, remove the conversion entirely.

BUG= chromium:781849 
BRANCH=kevin
TEST=Verify PD and BC1.2 charging still works on kevin.

Change-Id: I53162fb6e93e89dd161369302a18fc59e48e5dc8
Signed-off-by: Duncan Laurie <dlaurie@google.com>
Original-Commit-Id: f4ee6caa665009ca3306f61706074b82e1e2c347
Original-Change-Id: I3687866835d1684342d9f746d91b3a6079ab5cc4
Original-Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org>
Original-Reviewed-on: https://chromium-review.googlesource.com/755000
Original-Commit-Ready: Shawn N <shawnn@chromium.org>
Original-Tested-by: Shawn N <shawnn@chromium.org>
Original-Reviewed-by: Aseda Aboagye <aaboagye@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/914643

[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/eve/usb_pd_policy.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/include/config.h
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/eve/board.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/driver/charger/bd9995x.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/coral/board.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/kevin/usb_pd_policy.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/driver/charger/bd9995x.h
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/reef/usb_pd_policy.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/reef/board.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/kevin/board.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/reef_it8320/board.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/reef_it8320/usb_pd_policy.c
[modify] https://crrev.com/a10d039c5498a1b2a3a655a511b443ce5b1707d5/board/coral/usb_pd_policy.c
►

Sign in to add a comment