desktopui_ScreenLocker failing on amd64-generic and betty |
||||||
Issue descriptiondesktopui_ScreenLocker started failing on amd64-generic here: https://build.chromium.org/p/chromiumos.chromium/builders/amd64-generic-tot-chromium-pfq-informational/builds/14000 The failure output is here: https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/amd64-generic-tot-chromium-pfq-informational/R64-10095.0.0-b14000/vm_test_results_1/pfq_suite/test_harness/all/SimpleTestUpdateAndVerify/2_autotest_tests/results-38-desktopui_ScreenLocker/desktopui_ScreenLocker/debug/ Snippet: 11/03 19:09:42.002 INFO | browser:0283| Browser is closed. 11/03 19:09:42.020 WARNI| test:0612| The test failed with the following exception Traceback (most recent call last): File "/usr/local/autotest/common_lib/test.py", line 606, in _exec _call_test_function(self.execute, *p_args, **p_dargs) File "/usr/local/autotest/common_lib/test.py", line 806, in _call_test_function return func(*args, **dargs) File "/usr/local/autotest/common_lib/test.py", line 470, in execute dargs) File "/usr/local/autotest/common_lib/test.py", line 347, in _call_run_once_with_retry postprocess_profiled_run, args, dargs) File "/usr/local/autotest/common_lib/test.py", line 380, in _call_run_once self.run_once(*args, **dargs) File "/usr/local/autotest/tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py", line 166, in run_once self.lock_screen(perf_values) File "/usr/local/autotest/tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py", line 100, in lock_screen exception=error.TestFail('Screenlock screen not visible')) File "/usr/local/autotest/common_lib/utils.py", line 2740, in poll_for_condition raise exception TestFail: Screenlock screen not visible
,
Nov 6 2017
,
Nov 6 2017
This seems suspicious: :) "cros: Enable views-based lock by default." https://chromium-review.googlesource.com/726240 I am hoping that I will be able to repro with a Simple Chrome VM test: https://docs.google.com/document/d/1KIVpg0eXR1gEMZuV4Shm8dH1VV8ev4Ysi541AEephMU/edit#heading=h.h2vvkxpsu6p4
,
Nov 6 2017
From the Chrome log: https://pantheon.corp.google.com/storage/browser/chromeos-image-archive/amd64-generic-tot-chromium-pfq-informational/R64-10095.0.0-b14000/vm_test_results_1/pfq_suite/test_harness/all/SimpleTestUpdateAndVerify/2_autotest_tests/results-38-desktopui_ScreenLocker/desktopui_ScreenLocker/sysinfo/var/log_diff/chrome/ [1093:1093:1103/190931.661206:VERBOSE1:lock_state_controller.cc(535)] PostLockAnimationFinished [1093:1093:1103/190931.661355:VERBOSE1:lock_state_controller.cc(496)] PreLockAnimationFinished [1093:1093:1103/190931.662602:ERROR:views_screen_locker.cc(122)] Not implemented reached in virtual void chromeos::ViewsScreenLocker::OnAshLockAnimationFinished() [1093:1093:1103/190941.392411:VERBOSE1:screen_locker.cc(560)] Deleting ScreenLocker 0x24fe5e389900 [1093:1093:1103/190941.392471:VERBOSE1:screen_locker.cc(573)] Destroying ScreenLocker 0x24fe5e389900 [1093:1093:1103/190941.392526:VERBOSE1:screen_locker.cc(582)] Emitting SCREEN_LOCK_STATE_CHANGED with state=0 [1093:1093:1103/190941.392560:VERBOSE1:screen_locker.cc(587)] Calling session manager's HandleLockScreenDismissed D-Bus method
,
Nov 6 2017
Think https://chromium-review.googlesource.com/726240 breaks the test because the test assumes webui lock screen, e.g. in screenlocker_visible [1]. [1]: https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py?rcl=a4284af727b461f285c92385160eaddc8f64ae49&l=48
,
Nov 6 2017
So it sounds like we should revert the change until we fix the test? I'm a little curious why it is only failing on those boards, but maybe we don't run that test elsewhere? jdufault@ - WDYT, is it safe/OK to revert that?
,
Nov 6 2017
jdfault@ is MIA and I can not reprduce the VM failure locally, but as mentioned in comment #5 this is almost certainly https://chromium-review.googlesource.com/726240 so I am going to try reverting that.
,
Nov 6 2017
Reverting is fine, if you haven't started the revert yet please reassign to me and I'll take care of it.
,
Nov 6 2017
Assigning to jdufault@ to close once the CL is reverted or to track fixing the test.
,
Nov 8 2017
Views-based support for desktopui_ScreenLocker is tracked in issue 781998 , I'm going to force the test to always load webui lock screen in the meantime.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/40a690f27f05572a0553b47140668651fd83f45a commit 40a690f27f05572a0553b47140668651fd83f45a Author: Jacob Dufault <jdufault@google.com> Date: Fri Nov 10 03:16:32 2017 Force desktopui_ScreenLocker to use webui lock screen BUG=chromium:781845 TEST=test_that --board=$BOARD <ip> desktopui_ScreenLocker Change-Id: I38aff94e029749dfebc966f3989d5abfac027c83 Reviewed-on: https://chromium-review.googlesource.com/757170 Commit-Ready: Jacob Dufault <jdufault@chromium.org> Tested-by: Jacob Dufault <jdufault@chromium.org> Reviewed-by: Ilja H. Friedel <ihf@chromium.org> [modify] https://crrev.com/40a690f27f05572a0553b47140668651fd83f45a/client/site_tests/desktopui_ScreenLocker/desktopui_ScreenLocker.py
,
Dec 26 2017
,
Jan 2 2018
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".] |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by steve...@chromium.org
, Nov 6 2017