New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781841 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
twelling...@chromium.org
tedc...@chromium.org
█ mariakho...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Task

Blocked on:
issue 789732


Sign in to add a comment

Fail when ChromeTabbedActivity is explicitly invoked from the outside

Project Member Reported by dskiba@chromium.org, Nov 6 2017 
We had to export CTA to fix issue 781191, and there is a good chance that 3rd party code will start calling CTA explicitly, instead of .Main alias that points to it.

We should detect such cases and bark (show toast, throw exception, etc.).

For example we can require that all CTA intents have "Calling ChromeTabbedActivity directly is not supported" extra. There might be more appropriate / clever solutions.

Comment 1 by tedc...@chromium.org, Nov 6 2017 

I wouldn't throw an exception as that would conflate our crash stacks for undesired external developer behavior.

If anything, I would just log something to logcat and then just ignore the URL associated with the intent (i.e. treat all intents directly to CTA as a main intent -- no app would likely enjoy that behavior so that should be ok).

Comment 2 by dtrainor@chromium.org, Feb 8 2018

Components: UI>Browser>Mobile

Comment 3 by danielpark@chromium.org, Mar 6 2018

Labels: android-fe-triaged
Status: Available (was: Untriaged)

Comment 4 by tedc...@chromium.org, Mar 7 2018

Labels: -Type-Bug Type-Task

Comment 5 by tedc...@chromium.org, Mar 7 2018

Components: Mobile>Intents
dskiba@ added a bunch of metrics in CTA to track whether this is occurring in maybeDispatchExplicitMainViewIntent, so once that gets below some threshold (TBD), we should just start ignoring non-MAIN intents directly to CTA.

Comment 6 by dskiba@chromium.org, May 30 2018

Blockedon: 789732
►

Sign in to add a comment