New issue
Advanced search Search tips

Issue 781839 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Team-Security-UX


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Toolbar lock icon grey instead of green on CCT when Chrome Home enabled.

Project Member Reported by mdjones@chromium.org, Nov 6 2017

Issue description

From https://bugs.chromium.org/p/chromium/issues/detail?id=774641#c18:

I'm still seeing issues related to this on Canary/ToT

Repro steps:
1. Open an app that will launch an Herb e.g. Google Messenger or Keep
2. Tap on an https link

Observed result: URL loads in Herb, lock icon grey
Expected result: lock icon green

 
Components: UI>Browser>Omnibox>SecurityIndicators
Labels: M-63
This is probably still a P1 RBS since the lock icon is security related. I can repro on 63 Beta.

Comment 2 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/566a30010b74240c3b5aa34e6a910aeda26177da

commit 566a30010b74240c3b5aa34e6a910aeda26177da
Author: Matthew Jones <mdjones@chromium.org>
Date: Fri Nov 10 20:14:01 2017

[Home] Fix security icon for CCT

Whether Chrome Home is enabled is not relevant to anything in a custom
tab. This change checks the bottom sheet instead of feature utilities
in the toolbar code.

BUG= 781839 

Change-Id: I407fdaa1d14b74999d9216c678f82a70ff1f804e
Reviewed-on: https://chromium-review.googlesource.com/755354
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515657}
[modify] https://crrev.com/566a30010b74240c3b5aa34e6a910aeda26177da/chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarLayout.java
[modify] https://crrev.com/566a30010b74240c3b5aa34e6a910aeda26177da/chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java

Status: Fixed (was: Assigned)

Sign in to add a comment