New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781824 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

GpuProcess_driver_bug_workarounds_in_gpu_process flakily crashes on Android

Project Member Reported by geoffl...@chromium.org, Nov 6 2017

Issue description

The gpu_tests.gpu_process_integration_test.GpuProcessIntegrationTest.GpuProcess_driver_bug_workarounds_in_gpu_process test appears to flakily crash or time out on the Android Release (Nexus 9) bot (https://build.chromium.org/p/chromium.gpu.fyi/builders/Android%20Release%20%28Nexus%209%29)

Example failure:
https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.gpu.fyi%2FAndroid_Release__Nexus_9_%2F9125%2F%2B%2Frecipes%2Fsteps%2Fgpu_process_launch_tests%2F0%2Fstdout

Sending to zmo@ to triage.
 

Comment 1 by zmo@chromium.org, Nov 6 2017

Cc: kbr@chromium.org piman@chromium.org
Labels: OS-Android
Status: Started (was: Assigned)
At this point, checking browser side GPU driver bug workarounds is no longer meaningful, we should simply the test to only verify the GPU side workarounds.

Also, to query the GPU side workaround, right now in  GpuBenchmarking::GetGpuDriverBugWorkarounds we establish a GPU channel, and then send a message GpuChannelMsg_GetDriverBugWorkArounds to get the strings. This is over complicated, because upon establishing a GPU channel, we already sent back the workaround as part of GpuFeatureInfo.

With these two issue addressed, I expect the flakiness will disappear.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9485178f4103809d6dc696c67e0a886991a41e4

commit d9485178f4103809d6dc696c67e0a886991a41e4
Author: Zhenyao Mo <zmo@chromium.org>
Date: Mon Nov 06 23:20:49 2017

GPU driver bug workarounds checking should be solely from GPU process.

BUG= 781824 
TEST=bots
R=piman@chromium.org,kbr@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ifeb68ffed31f8970666c78e7bb8cf678d5b845bb
Reviewed-on: https://chromium-review.googlesource.com/755539
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514285}
[modify] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/content/renderer/gpu/gpu_benchmarking_extension.cc
[modify] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/content/test/gpu/gpu_tests/gpu_process_integration_test.py
[modify] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/gpu/ipc/common/gpu_messages.h
[modify] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/gpu/ipc/service/gpu_channel.cc
[modify] https://crrev.com/d9485178f4103809d6dc696c67e0a886991a41e4/gpu/ipc/service/gpu_channel.h

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/472b4c4da6b6db3c52416eabf48c6c23e13442da

commit 472b4c4da6b6db3c52416eabf48c6c23e13442da
Author: Zhenyao Mo <zmo@chromium.org>
Date: Tue Nov 07 17:53:21 2017

Remove PANEL_FITTING blacklisting.

ChromeOS will remove PANEL_FITTING support soon. As for now, just disable it so
we can remove the blacklisting support of this feature.

BUG= 781824 
TEST=bots
R=piman@chromium.org,marcheu@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib4526641b16bde05dbf39dcfb1f916fd51b96289
Reviewed-on: https://chromium-review.googlesource.com/755978
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514503}
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/BUILD.gn
[delete] https://crrev.com/88e4d5f0da7234775933a28336f403c5d7306809/ash/content/gpu_support_impl.cc
[delete] https://crrev.com/88e4d5f0da7234775933a28336f403c5d7306809/ash/content/gpu_support_impl.h
[delete] https://crrev.com/88e4d5f0da7234775933a28336f403c5d7306809/ash/gpu_support.h
[delete] https://crrev.com/88e4d5f0da7234775933a28336f403c5d7306809/ash/gpu_support_stub.cc
[delete] https://crrev.com/88e4d5f0da7234775933a28336f403c5d7306809/ash/gpu_support_stub.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/mus/shell_delegate_mus.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/mus/shell_delegate_mus.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/shell.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/shell.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/shell/shell_delegate_impl.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/shell/shell_delegate_impl.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/shell_delegate.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/test_shell_delegate.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/ash/test_shell_delegate.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/chrome/browser/ui/ash/chrome_shell_delegate.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/content/browser/gpu/compositor_util.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/content/browser/gpu/gpu_data_manager_impl_private.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/content/browser/gpu/gpu_data_manager_testing_arrays_and_structs_autogen.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/content/browser/resources/gpu/info_view.js
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/gpu/config/gpu_blacklist.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/gpu/config/gpu_blacklist_unittest.cc
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/gpu/config/gpu_feature_type.h
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/gpu/config/software_rendering_list.json
[modify] https://crrev.com/472b4c4da6b6db3c52416eabf48c6c23e13442da/gpu/ipc/common/struct_traits_unittest.cc

Comment 4 by zmo@chromium.org, Nov 7 2017

Status: Fixed (was: Started)

Sign in to add a comment