New issue
Advanced search Search tips

Issue 781810 link

Starred by 1 user
Status: Verified
Owner:
drott@chromium.org
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Regression



Sign in to add a comment

compile confirm no-op failing on multiple builders

Project Member Reported by bcwhite@google.com, Nov 6 2017 
compile confirm no-op failing on multiple builders

Builders failed on: 
- Linux x64: 
  https://build.chromium.org/p/chromium/builders/Linux%20x64
- Mac: 
  https://build.chromium.org/p/chromium/builders/Mac
- Win x64: 
  https://build.chromium.org/p/chromium/builders/Win%20x64

This is a consistent failure and started with a single CL:
https://chromium-review.googlesource.com/744014

Reverting that...

Comment 1 by bcwh...@chromium.org, Nov 6 2017

Cc: marq@chromium.org
Labels: OS-Linux Pri-1 Type-Bug-Regression
Owner: gambard@chromium.org

Comment 2 by bcwh...@chromium.org, Nov 6 2017

Cc: -marq@chromium.org
Owner: drott@chromium.org
Pasted the wrong CL.  Meant to be this one:
https://chromium-review.googlesource.com/749148

Comment 4 by sky@chromium.org, Nov 6 2017

Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/291aa189c9024d1c4289b710638fea074b590093

commit 291aa189c9024d1c4289b710638fea074b590093
Author: Dominik Röttsches <drott@chromium.org>
Date: Mon Nov 06 20:48:44 2017

Compile no-op fix after text-decoration-skip-ink CL

After https://chromium-review.googlesource.com/c/chromium/src/+/749148
we no longer need the CSSPropertyAPITextDecorationSkip.h header.

Bug:  777428 ,  781810 
Change-Id: Id71f875d23722bbb67b1d6d6f92cfe1f1ac31798
Tbr: mmentovai
Reviewed-on: https://chromium-review.googlesource.com/753373
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514237}
[modify] https://crrev.com/291aa189c9024d1c4289b710638fea074b590093/third_party/WebKit/Source/core/BUILD.gn

Comment 6 by sky@chromium.org, Nov 6 2017

Status: Fixed (was: Started)
Everything now looks good. Closing.

Comment 7 by brajkumar@chromium.org, Nov 7 2017

Status: Verified (was: Fixed)
As per the below waterfall link all the builds triggered successfully and the status is showing in green for Win 64, Linux 64 and Mac platforms. Hence changing the status to verified.

Link: https://build.chromium.org/p/chromium/waterfall

Thanks!
►

Sign in to add a comment