New issue
Advanced search Search tips

Issue 781790 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 781935



Sign in to add a comment

MockWebMediaStreamCenter is obsolete and should be removed

Project Member Reported by hta@chromium.org, Nov 6 2017

Issue description

MockWebMediaStreamCenter (content/shell/test_runner/mock_web_media_stream_center.{cc,h}) was developed long ago, and is now just a burden. It's better if content_shell calls the real code with content-layer mock devices.

 

Comment 1 by hta@chromium.org, Nov 6 2017

Blocking: 781935
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4931caa5e7203b2e001a1742c2414b716f9e4582

commit 4931caa5e7203b2e001a1742c2414b716f9e4582
Author: Harald Alvestrand <hta@chromium.org>
Date: Wed Nov 08 16:53:35 2017

Remove MockWebMediaStreamCenter

It doesn't appear to be needed any more.

Bug:  781790 
Change-Id: Ia000179e676f2feccff1bb16971f45bc70b9a934
Reviewed-on: https://chromium-review.googlesource.com/755193
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514858}
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/public/renderer/content_renderer_client.cc
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/public/renderer/content_renderer_client.h
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/shell/renderer/layout_test/layout_test_content_renderer_client.cc
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/shell/renderer/layout_test/layout_test_content_renderer_client.h
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/9f448647888c760161d7a480215dd8149e0ca075/content/shell/test_runner/mock_web_media_stream_center.cc
[delete] https://crrev.com/9f448647888c760161d7a480215dd8149e0ca075/content/shell/test_runner/mock_web_media_stream_center.h
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/shell/test_runner/web_test_interfaces.cc
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/content/shell/test_runner/web_test_interfaces.h
[modify] https://crrev.com/4931caa5e7203b2e001a1742c2414b716f9e4582/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/9f448647888c760161d7a480215dd8149e0ca075/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation-expected.txt

fixed?

Comment 4 by hta@chromium.org, Nov 10 2017

Status: Fixed (was: Untriaged)

Sign in to add a comment