New issue
Advanced search Search tips

Issue 781777 link

Starred by 1 user
Status: Duplicate
Merged: issue 781719
Owner: ----
Closed: Nov 2017
Cc:
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Test MediaStreamTrack-applyConstraints fails

Project Member Reported by hta@chromium.org, Nov 6 2017 

What steps will reproduce the problem?
(1) Apply CL 738232
(2) Run fast/mediastream/MediaStreamTrack-applyConstraints or MediaStreamTrack-getConstraints


What is the expected result?

Test succeds for "All valid keys are returned for complex constraints"

What happens instead?

OverconstrainedError is returned

A brief analysis says that the mandatory complex constraints used can't be satisfied by the mock devices. Some tuning should solve this.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6

commit 58bf120c5e0261716a20a5c33fdcc3b44f6cedf6
Author: Harald Alvestrand <hta@chromium.org>
Date: Mon Nov 06 18:04:30 2017

Delete MockWebUserMediaClient and calls to it

We believe that the real code, with functions for fake devices,
is the way forward for making testrunner tests. Therefore, this
mock needs to go.

Bugs listed below are bugs filed during patch development.

Bug: 781716,  781719 ,  781772 ,  781774 ,  781777 
Change-Id: Ia28b07270a6874a6c6836542bc0245d39f9efc8d
Reviewed-on: https://chromium-review.googlesource.com/738232
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514173}
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/67eb9df88298a98a719334fa55a27d0ced87239e/content/shell/test_runner/mock_web_user_media_client.cc
[delete] https://crrev.com/67eb9df88298a98a719334fa55a27d0ced87239e/content/shell/test_runner/mock_web_user_media_client.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/audio-output/setSinkId.https-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-impossible-constraint.https-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-devicechange.html
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-stop-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-stop.html
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-applyConstraints-expected.txt
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-constraints-expected.txt

Comment 2 by niklase@chromium.org, Nov 10 2017 

fixed?

Comment 3 by hta@chromium.org, Nov 10 2017

Mergedinto: 781719
Status: Duplicate (was: Untriaged)
Don't think so. I filed it while landing the CL. 

It is, however, a dupe of 781719.
►

Sign in to add a comment