Collect tokens to prepare for the dice migration.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05d951ca31cb99ed616fe38ced9b4d22c9035b01 commit 05d951ca31cb99ed616fe38ced9b4d22c9035b01 Author: David Roger <droger@chromium.org> Date: Wed Nov 08 11:55:22 2017 [signin] Add experimental flag for Dice peparation step TBR: pavely Bug: 781761 Change-Id: I1f82956fdcee85209434c3261d13e29a04613296 Reviewed-on: https://chromium-review.googlesource.com/754833 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#514801} [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/about_flags.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/account_reconcilor_factory.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/account_reconcilor_factory.h [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/chrome_signin_helper.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/dice_response_handler.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/browser_sync/profile_sync_service.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/about_signin_internals.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/account_reconcilor.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/profile_management_switches.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/profile_management_switches.h [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/profile_management_switches_unittest.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/scoped_account_consistency.cc [modify] https://crrev.com/05d951ca31cb99ed616fe38ced9b4d22c9035b01/components/signin/core/browser/scoped_account_consistency.h
We also need to re-route all sign-ins via the DICE sign-in flow.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7f967e0e520c572cd9bdbde2f88107c6b6e28583 commit 7f967e0e520c572cd9bdbde2f88107c6b6e28583 Author: David Roger <droger@chromium.org> Date: Fri Nov 10 00:10:53 2017 [signin] Report Dice migration state even if migration is not enabled The Dice migration state (i.e. if the profile is consistent and can be migrated now) even when the Dice migration is not actually enabled. This is useful for the "Prepare Migration" step, where we try to make the profiles consistent without actually performing the migration. Bug: 781761 Change-Id: I179dca5d7ee370434df26143edeefd0f34faa3a5 Reviewed-on: https://chromium-review.googlesource.com/758638 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#515356} [modify] https://crrev.com/7f967e0e520c572cd9bdbde2f88107c6b6e28583/chrome/browser/signin/account_reconcilor_unittest.cc [modify] https://crrev.com/7f967e0e520c572cd9bdbde2f88107c6b6e28583/components/signin/core/browser/account_reconcilor.cc [modify] https://crrev.com/7f967e0e520c572cd9bdbde2f88107c6b6e28583/components/signin/core/browser/account_reconcilor.h [modify] https://crrev.com/7f967e0e520c572cd9bdbde2f88107c6b6e28583/tools/metrics/histograms/enums.xml [modify] https://crrev.com/7f967e0e520c572cd9bdbde2f88107c6b6e28583/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/793d1ce5f7fa8430f1613f2c9b5559a76e417d98 commit 793d1ce5f7fa8430f1613f2c9b5559a76e417d98 Author: David Roger <droger@chromium.org> Date: Tue Nov 28 14:42:32 2017 [signin] Dice is disabled when Gaia is not isolated Checking site isolation only in a few Dice scenarios was actually hard to do, and since we expect site isolation to be enabled by default soon, this CL goes with a simpler approach: completely disable account consistency (including Mirror and fixing auth errors) on Dice platforms when site isolation is disabled. Note that this change does not apply to mobile, where Mirror is still always enabled, regardless of site isolation. The signin component does not have access to the site isolation feature, and thus it is injected from Chrome. The ChromeSigninClient factory does the injection, for two reasons: - configuring the component should be done by "client" code - it should be done only once, and thus is done by the client factory rather than the client itself (because there can be multiple instances of ChromeSigninClient). Bug: 781761 Change-Id: Ia897bead9ab1fcc6915933eeed168d5ece3dda4a Reviewed-on: https://chromium-review.googlesource.com/768871 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Sky Malice <skym@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#519682} [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/chrome/browser/signin/chrome_signin_client_factory.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/chrome/browser/signin/dice_browsertest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/chrome/browser/signin/dice_response_handler_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/chrome/browser/signin/mutable_profile_oauth2_token_service_delegate_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/browser_sync/profile_sync_test_util.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/ntp_snippets/breaking_news/subscription_manager_impl_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/access_token_fetcher_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/account_reconcilor_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/profile_management_switches.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/profile_management_switches.h [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/profile_management_switches_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/scoped_account_consistency.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/signin_header_helper_unittest.cc [modify] https://crrev.com/793d1ce5f7fa8430f1613f2c9b5559a76e417d98/components/signin/core/browser/signin_manager_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51f305bf770e7a958a02b46d16357e497307e81f commit 51f305bf770e7a958a02b46d16357e497307e81f Author: David Roger <droger@chromium.org> Date: Tue Apr 03 15:12:19 2018 [signin] Update fieldtrial_testing_config for Dice Milestone 2 This CL enables testing with Dice Milestone 2. Bug: 781761 Change-Id: I8781160f56eb45bb47b80ca67e1373f6b42011de Reviewed-on: https://chromium-review.googlesource.com/975561 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by: Marc Treib <treib@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#547712} [modify] https://crrev.com/51f305bf770e7a958a02b46d16357e497307e81f/components/signin/core/browser/profile_management_switches.cc [modify] https://crrev.com/51f305bf770e7a958a02b46d16357e497307e81f/testing/variations/fieldtrial_testing_config.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae commit 23db6afeb7bfae909d36d0d335bbfb84bc42b8ae Author: David Roger <droger@chromium.org> Date: Fri Jun 15 13:39:13 2018 [signin] Enable Dice M2 by default This CL makes DicePrepareMigration the default in profile_management_switches. The entry fieldtrial_testing_config can now be removed. sync_confirmation_handler tests are updated to no longer require or test the OneClickSigninSyncStarter Change-Id: I214b4c50da08f5c2ae49883b21ed18a717157a19 Bug: 781761 Reviewed-on: https://chromium-review.googlesource.com/1088612 Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#567625} [modify] https://crrev.com/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae/chrome/browser/ui/sync/one_click_signin_sync_starter.cc [modify] https://crrev.com/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae/chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc [modify] https://crrev.com/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae/components/signin/core/browser/profile_management_switches.cc [modify] https://crrev.com/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae/components/signin/core/browser/profile_management_switches_unittest.cc [modify] https://crrev.com/23db6afeb7bfae909d36d0d335bbfb84bc42b8ae/testing/variations/fieldtrial_testing_config.json
Comment 1 by bugdroid1@chromium.org
, Nov 8 2017