New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781754 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Task


Sign in to add a comment

Tracking bug for WebView Support Library glue layer code

Project Member Reported by gsennton@chromium.org, Nov 6 2017

Issue description

This is a tracking bug for creating the WebView Support Library glue layer in the chromium source tree.
 
Labels: M-55
Blockedon: 781759
Labels: -M-55 M-65
Blockedon: 735943
Blockedon: 781763
Blockedon: 781764
Owner: gsennton@chromium.org
Status: Assigned (was: Available)
initially assigning all the support library issues to gsennton@
Blockedon: 785928
Blocking: 788138
Blockedon: 807332
Blockedon: 807333
Blockedon: 808417
Blockedon: 810390
Blockedon: 810430
Blockedon: 809471
Blockedon: 812203
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b402360687de07d41112e5552083de3da2b6497

commit 5b402360687de07d41112e5552083de3da2b6497
Author: Gustav Sennton <gsennton@google.com>
Date: Wed Feb 14 23:21:33 2018

[Android WebView] Add a first version of the support library glue layer

WebView already has a webkit <-> chromium glue layer.
This CL introduces a WebView-support-library <-> chromium glue layer to
allow the WebView Support Library to use reflection to access WebView
functionality without being restricted by the android.webkit framework
APIs.

In terms of layering the idea here is to have the support library glue
depend on 'shared' classes in the webkit-glue layer (ideally those
classes would be broken out into their own layer but for now they
contain too many dependencies on the webkit-glue layer).

With this CL we add support for the single API
WebViewCompat.postVisualStateCallback().

Bug:  781754 
Change-Id: I3f904f24858fd39e69b0f89af8c35ed9f61335a6
Reviewed-on: https://chromium-review.googlesource.com/919261
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536875}
[modify] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/glue/BUILD.gn
[modify] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromium.java
[add] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/glue/java/src/com/android/webview/chromium/WebkitToSharedGlueConverter.java
[add] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/support_library/BUILD.gn
[add] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibReflectionUtil.java
[add] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromium.java
[add] https://crrev.com/5b402360687de07d41112e5552083de3da2b6497/android_webview/support_library/java/src/org/chromium/support_lib_glue/SupportLibWebViewChromiumFactory.java

Blockedon: -810390
Blockedon: -781759
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f63578fcbb95bf29919f8e307fa8920ad43548c3

commit f63578fcbb95bf29919f8e307fa8920ad43548c3
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Feb 15 15:47:13 2018

Include support library glue into monochrome and system_webview_apk

The WebView Support Library glue layer is the chromium-side part of the
WebView Support Library - the rest lives in the Android Support Library.

Since the WebView Support Library glue layer does not depend on
anything downstream we can include it in all upstream WebView targets.

Bug:  781754 
Change-Id: Id9da1f0ae6dbde12d0edb8dda369751c378fa36e
Reviewed-on: https://chromium-review.googlesource.com/921224
Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537025}
[modify] https://crrev.com/f63578fcbb95bf29919f8e307fa8920ad43548c3/android_webview/BUILD.gn
[modify] https://crrev.com/f63578fcbb95bf29919f8e307fa8920ad43548c3/chrome/android/BUILD.gn

Project Member

Comment 21 by bugdroid1@chromium.org, Feb 15 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/ee565f1aa76eb856a3795a7060197c2477480e96

commit ee565f1aa76eb856a3795a7060197c2477480e96
Author: Gustav Sennton <gsennton@google.com>
Date: Thu Feb 15 15:53:06 2018

Blockedon: 812657
Blockedon: 813118
Blockedon: 816506
Blockedon: 819595
Blockedon: 821792
Blockedon: -807332
Project Member

Comment 28 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1206fd3a1314938dd91a170d474dbbd0ee23038b

commit 1206fd3a1314938dd91a170d474dbbd0ee23038b
Author: Gustav Sennton <gsennton@google.com>
Date: Tue Mar 27 17:40:57 2018

Add owners to android_webview/support_library/

android_webview/support_library/ contains
1. boundary interfaces (mirrored into the Android support library).
2 the support library glue (gluing the boundary interfaces together
with the rest of chromium).

Bug:  781754 
Change-Id: I903c2165ece5192364ab2d257074304317692114
Reviewed-on: https://chromium-review.googlesource.com/980973
Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Gustav Sennton <gsennton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546153}
[add] https://crrev.com/1206fd3a1314938dd91a170d474dbbd0ee23038b/android_webview/support_library/OWNERS

Blockedon: 828184
Blockedon: 828612
Blockedon: 831315
Blockedon: 831554
Blockedon: 836339
Marking this as fixed - this bug was created to track work needed for the initial support library release.  
Status: Fixed (was: Assigned)

Sign in to add a comment