Issue metadata
Sign in to add a comment
|
Regression : Extra white space is seen in the header of 'App info' dialog box.
Reported by
avsha...@etouch.net,
Nov 6 2017
|
||||||||||||||||||||||
Issue descriptionChrome version : 62.0.3202.89 (Official Build) 4bc124ea2934343d106df5b937e78ce311311658-refs/branch-heads/3202@{#775} 32/64 bit OS : Windows (7,8,10), Linux(14.04 LTS) Precondition : Enable 'Material Design in the rest of the browser's native UI' flag. What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://apps. 2. Right click on 'Web Store' icon and select 'App info' option. 3. Observe header part of a dialog box. Actual Result : Extra white space is seen at the header of 'App info' dialog box. Expected Result : Extra padding should not be seen in the header of 'App info' dialog box. This is a regression issue broken in ‘M-62’ and using the per-revision bisect providing the bisect results, Good build : 62.0.3183.0 (Revision : 493906) Bad build : 62.0.3184.0 (Revision : 493964) You are probably looking for a change made after 493961 (known good), but no later than 493962 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/67c1c1d0d891728fa12d75479ca3072364e4bb8d..1453be1214185aed2b13fdec79c73f842fd2eb83 Suspect : https://chromium.googlesource.com/chromium/src/+/1453be1214185aed2b13fdec79c73f842fd2eb83 @tapted : Could you please look into the issue. Note : Above issue is not reproducible on Mac(10.12.6) OS.
,
Nov 6 2017
Yeah I noticed this too. This probably needs to be fixed before rolling out in m65.
,
Nov 6 2017
Agreed, this needs be fixed before launch. However, that dialog is a P3 (see tracking bug 700189) so we should avoid working on it too much.
,
Nov 15 2017
,
Jan 9 2018
,
Jan 9 2018
Load balancing
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8322e656602b2e61bed407915624e0662231b331 commit 8322e656602b2e61bed407915624e0662231b331 Author: Allen Bauer <kylixrd@chromium.org> Date: Fri Jan 12 16:39:36 2018 Enable BubbleFrameView subclasses to force the client view to overlap into the title. Bug: 781751 Change-Id: Ifbeed606bae4ac1e4f91e720ec75765dc49f4566 Reviewed-on: https://chromium-review.googlesource.com/860281 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#528966} [modify] https://crrev.com/8322e656602b2e61bed407915624e0662231b331/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc [modify] https://crrev.com/8322e656602b2e61bed407915624e0662231b331/ui/views/bubble/bubble_frame_view.cc [modify] https://crrev.com/8322e656602b2e61bed407915624e0662231b331/ui/views/bubble/bubble_frame_view.h
,
Jan 12 2018
,
Jan 16 2018
Update : Verified this issue on Windows (7,8,8.1,10) & Linux (14.04 LTS) OS with build #65.0.3322.0 and the issue is fixed. Extra white space is no longer observed in the header of ‘App info’ dialog box. Kindly review an attached screen shot. Thank you! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by avsha...@etouch.net
, Nov 6 2017