+Mihai as FYI

This is actually pretty high-priority, since we rely on users being able to get to the "x-to-close" button via the keyboard for a11y reasons. lfg@ - could you please take a look?

Alex, can you take a look? It looks like the element is getting focused, but the outer WebContents is not activated. I tried adding SetAsFocusedWebContentsIfNecessary in WebContentsViewChildFrame::TakeFocus, but it makes the behavior racy (works sometimes, but not always, so I assume there's some race between guest/embedder going on).

On this line:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/FocusController.cpp?type=cs&l=825

IsFocused() returns false.  SetFocusedFrame is called when the embedder renderer received the notification to advance focus from the oopif here: https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/FocusController.cpp?type=cs&l=1120

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/839ae6ef38f225cdf0195e186e9c162b26eadcd0

commit 839ae6ef38f225cdf0195e186e9c162b26eadcd0
Author: Alex Vallée <avallee@chromium.org>
Date: Fri Nov 17 19:23:16 2017

[chrome-signin] Reduce focus stealing.

With the OOPIF implementation of webview, the embedder page is not
considered focused when the guest has focus (it does not see any
keyboard input). This means that upon reaching the end of the
<webview>'s content and focusing an element in the embedder,
<paper-icon-button> in this case, the page is first refocused.

This event listener only seemed to expect this to happen once at the
beginning.

This CL prevents the authenticator from focusing the webview if another
element is focused when the page itself is focused.

The alternative would be to call focus only once, when constructing the
Authenticator.

Bug:  781748 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac7020caad90c9e5e617f46bba392caeb09482b0
Reviewed-on: https://chromium-review.googlesource.com/775978
Commit-Queue: Alex Vallee <avallee@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517511}
[modify] https://crrev.com/839ae6ef38f225cdf0195e186e9c162b26eadcd0/chrome/browser/resources/gaia_auth_host/authenticator.js

Change listed at #5 landed 88 mins back. Please update the bug on Monday morning with canary result. If change looks good in canary, I will approve the merge.

Note: If merge happens before 12:30 PM PT Monday, then we can pick it up for next week beta release. Thank you.

This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Rechecked the above issue on Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6)OS with latest canary chrome version :64.0.3273.0 and the issue is not reproducible.Kindly refer the attached screen cast for reference.

Deleted: Actual_result.mov 1.4 MB

Actual_result.mov 1.4 MB Download

Rechecked the above issue on Windows (7,8,10) using build #64.0.3272.0 and Linux (14.04 LTS),Mac(10.12.6)OS using build #64.0.3273.0 and it is working fix as intended.

The NextAction date has arrived: 2017-11-20

Works fine on Mac canary with cross-process-guests enabled.

Approving merge to M63 branch 3239 based on comments #11, #13 and per offline chat with avallee@. Please merge ASAP. Thank you.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76df99b66c6e7b97c16ca9301645561de0abe68d

commit 76df99b66c6e7b97c16ca9301645561de0abe68d
Author: Alex Vallée <avallee@chromium.org>
Date: Mon Nov 20 16:30:41 2017

[M63][chrome-signin] Reduce focus stealing.

Merge to beta: M63.

With the OOPIF implementation of webview, the embedder page is not
considered focused when the guest has focus (it does not see any
keyboard input). This means that upon reaching the end of the
<webview>'s content and focusing an element in the embedder,
<paper-icon-button> in this case, the page is first refocused.

This event listener only seemed to expect this to happen once at the
beginning.

This CL prevents the authenticator from focusing the webview if another
element is focused when the page itself is focused.

The alternative would be to call focus only once, when constructing the
Authenticator.

Bug:  781748 
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Iac7020caad90c9e5e617f46bba392caeb09482b0
Reviewed-on: https://chromium-review.googlesource.com/775978
Commit-Queue: Alex Vallee <avallee@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#517511}(cherry picked from commit 839ae6ef38f225cdf0195e186e9c162b26eadcd0)
Reviewed-on: https://chromium-review.googlesource.com/777711
Reviewed-by: Alex Vallee <avallee@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#542}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/76df99b66c6e7b97c16ca9301645561de0abe68d/chrome/browser/resources/gaia_auth_host/authenticator.js

Rechecked the above issue on Windows (7,8,10),Linux (14.04 LTS),Mac(10.12.6)OS with latest canary chrome version :63.0.3239.59 and the issue is not reproducible.Kindly refer the attached screen cast for reference.

Deleted: Actual_result.mov 1.8 MB

Actual_result.mov 1.8 MB Download