Non-Regression : 'Reset' button is not working in 'Overscan' overlay of chrome://settings page |
|||||
Issue descriptionChrome Version: 64.0.3257.0/10102.0.0 dev channel Peppy,Daisy and Gnawty OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings/display page (2)Now click on 'Overscan' -> Adjust the boundaries of display by using Up or Down or Left or Right arrow keys with 'Shift' (3)Now click on Ok -> Again click on 'Overscan' and now try to click on 'Reset' button and observe Expected: 'Reset' button should work i.e. on clicking 'Reset' adjusted boundaries should get reset Actual: Instead nothing happens on clicking 'Reset' button This is Non-Regression Issue as 'Overscan' option is introduced from M-63 @stevenjb : Please confirm the Issue
,
Dec 1 2017
'Reset' will reset the current set of changes, it does not remove previously applied overscan settings. It seems like it might be useful to support both? Or maybe have 'reset' clear any overscan, since closing the dialog will cancel the current changes? +bettes@, +btuckley@ for UX/PM input. +oshima@ -> weidongg@ for display UI changes
,
Dec 6 2017
C#1> Issue is seen from M-63 and not in M-62 stable version(62.03202.97/9901.77.0)as 'Overscan' option is introduced from M-63 Thanks..!!
,
Dec 6 2017
https://developer.chrome.com/apps/system_display#method-overscanCalibrationReset From the API description, this seems to be how the API works.
,
Dec 6 2017
This issue needs UX feedback as described in comment #2. It is currently WAI, but having the ability to clear all overscan values is not unreasonable.
,
Dec 9 2017
First of all, overscan option shouldn't be on for internal display. This is only for external display. stevenjb@, weidongg@, can one of you fix this? The "reset" should have probably been "cancel". I agree that reset should just reset to the no overscan. +ovanieva@.
,
Dec 9 2017
Re #6, I can fix this (disable overscan option for internal display).
,
Dec 9 2017
thanks!
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8822190766c3fa617d4c10e24967b03c6a8d8835 commit 8822190766c3fa617d4c10e24967b03c6a8d8835 Author: Weidong Guo <weidongg@chromium.org> Date: Thu Dec 14 02:35:41 2017 Disable Overscan option for internal display in display settings Bug: 781747 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I128f64943031087f08bdf3f64c743bcbb7784694 Reviewed-on: https://chromium-review.googlesource.com/820094 Commit-Queue: Weidong Guo <weidongg@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#523988} [modify] https://crrev.com/8822190766c3fa617d4c10e24967b03c6a8d8835/chrome/browser/resources/settings/device_page/display.html [modify] https://crrev.com/8822190766c3fa617d4c10e24967b03c6a8d8835/chrome/browser/resources/settings/device_page/display.js |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by steve...@chromium.org
, Dec 1 2017