Issue metadata
Sign in to add a comment
|
Refactor isolated script test wrappers to reduce boiler plate code for setting up flags |
||||||||||||||||||||||||
Issue descriptionFrom conversation in https://chromium-review.googlesource.com/c/chromium/src/+/754133 The fact that we need to copy & paste this flag multiple times mean the code here can be refactored to reduce boiler plate. I think there can be a single place that define the argparse for all flags of isolated-script-test. Then there is a based FlagsTransformer class that is the API for transforming each isolated script test flag to another flag supported by actual test frameworks (all base TransformXYZFlag methods will raise UnimplementedError). kbr@ raised a caution argument: "The underlying harnesses have completely different mechanisms for handling test filtering -- I counted something like 5 or 6 different mechanisms. I would caution against using too many abstractions in these trampoline scripts because they'll make the scripts harder to understand."
,
Nov 9 2017
For clarification: the scripts in question are those in src/testing/scripts/ which take the --isolated-script-test-output command line argument.
,
Nov 9 2017
,
Nov 9
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 9
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by kbr@chromium.org
, Nov 9 2017