We need to replace WebPrivatePtr with scoped_refptr?

#c1: Yes, for the first step.


And as the next step, we will be able to remove an indirection around public/ classes that hold WebPrivatePtr. E.g.: http://crrev.com/c/756446.
For example, WebSerializedScriptValue has two roles, one is providing an API to the content layer, and another is hiding WTF::RefPtr and WTF::RefCounted from the content layer by adding an indirection using WebPrivatePtr.
As we can use scoped_refptr and base::RefCounted on public/, we can remove the indirection, and expose its implementation as a subclass of WebSerializedScriptValue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19f35e26419126465decb1ba4e841ad863801ab3

commit 19f35e26419126465decb1ba4e841ad863801ab3
Author: tzik <tzik@chromium.org>
Date: Mon Nov 13 10:36:38 2017

Use scoped_refptr in blink::WebString

WebString no longer needs to use WebPrivatePtr.
This CL replaces it with scoped_refptr for cleaner impls.

Bug: 781741
Change-Id: Icacecc2e2a35b59c1d16780625643844b76cbbfb
Reviewed-on: https://chromium-review.googlesource.com/762971
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515916}
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.h
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.h
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/platform/WebScheduler.cpp
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/platform/exported/WebCORSPreflightResultCache.cpp
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/platform/exported/WebString.cpp
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/Source/platform/testing/WebLayerTreeViewImplForTesting.h
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/public/platform/WebBlobInfo.h
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/public/platform/WebRTCRtpReceiver.h
[modify] https://crrev.com/19f35e26419126465decb1ba4e841ad863801ab3/third_party/WebKit/public/platform/WebString.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7912f96ed62ddb93990fb09fec84f4d10980136c

commit 7912f96ed62ddb93990fb09fec84f4d10980136c
Author: tzik <tzik@chromium.org>
Date: Wed Nov 15 13:36:50 2017

Simplify WebRTCICECandidate

This CL inlines WebRTCICECandidatePrivate into WebRTCICECandidate, and
removes its .cpp file. The inner class has been used to hide
WTF::RefCounted from //content layer, but it's no longer needed, as
base::RefCounted is ready to use in Blink's public/.

Bug: 781741
Change-Id: Ia09a30ed08c3aeebae9b5de65eff65baa3e4420b
Reviewed-on: https://chromium-review.googlesource.com/770916
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516682}
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/mock_web_rtc_peer_connection_handler_client.cc
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/mock_web_rtc_peer_connection_handler_client.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/peer_connection_tracker.cc
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/peer_connection_tracker.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/rtc_peer_connection_handler.cc
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/rtc_peer_connection_handler.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/content/renderer/media/rtc_peer_connection_handler_unittest.cc
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidate.cpp
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/Source/modules/peerconnection/RTCIceCandidate.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/53c36fda37d3c5bca4bb9e245c76e3a36e7a8309/third_party/WebKit/Source/platform/exported/WebRTCICECandidate.cpp
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/public/platform/WebRTCICECandidate.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/public/platform/WebRTCPeerConnectionHandler.h
[modify] https://crrev.com/7912f96ed62ddb93990fb09fec84f4d10980136c/third_party/WebKit/public/platform/WebRTCPeerConnectionHandlerClient.h

This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot