Remove RefPtr.h |
||||
Issue descriptionAfter WTF::RefPtr is removed in http://crbug.com/763844 , we will be able to remove platform/wtf/RefPtr.h too. Possible steps to clean up remainings: 1. Update third_party/WebKit/PRESUBMIT.py to allow base::AdoptRef and base::WrapRefCounted. 2. Update callers of WTF::WrapRefPtr to use base::WrapRefCounted. 3. Update callers of WTF::AdoptRef to use base::AdoptRef. 4. Remove RefPtr.h.
,
Nov 7 2017
seem Gyuyoung Kim already working on this bug. :)
,
Nov 8 2017
yes, I'm working on it with tzik@ and haraken@'s review.
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bf0c50f81a15631a30cc47269f80c20ded4f468 commit 9bf0c50f81a15631a30cc47269f80c20ded4f468 Author: Gyuyoung Kim <gyuyoung.kim@lge.com> Date: Fri Nov 10 16:35:17 2017 Remove using-directive base::AdoptRef and base::WrapRefCounted in wtf/RefPtr.h RefPtr.h will be removed eventually by issue 781740 . So it would be good to use base:: namespace for AdoptRef and WrapRefCounted that don't use base namespace directly. This CL adds base:: namespace to them, and removes using base::AdoptRef and using base::WrapRefCounted in RefPtr.h. Bug: 781740 Change-Id: Ibb7db7dc838c7c52f71d83f36c08382254214cd0 Reviewed-on: https://chromium-review.googlesource.com/762541 Reviewed-by: Taiju Tsuiki <tzik@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#515566} [modify] https://crrev.com/9bf0c50f81a15631a30cc47269f80c20ded4f468/third_party/WebKit/Source/platform/wtf/RefPtr.h [modify] https://crrev.com/9bf0c50f81a15631a30cc47269f80c20ded4f468/third_party/WebKit/Source/platform/wtf/text/AtomicStringTable.cpp [modify] https://crrev.com/9bf0c50f81a15631a30cc47269f80c20ded4f468/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp [modify] https://crrev.com/9bf0c50f81a15631a30cc47269f80c20ded4f468/third_party/WebKit/Source/platform/wtf/text/StringStatics.cpp
,
Nov 21 2017
,
Nov 24 2017
tzik@ and kentaro@, I think we can close this issue. I marked it to Fixed. If there is any issue on it, please let me know. |
||||
►
Sign in to add a comment |
||||
Comment 1 by shanmug...@samsung.com
, Nov 7 2017Status: Started (was: Available)