Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 78173 --ppapi-startup-dialog does not work
Starred by 3 users Project Member Reported by ddorwin@chromium.org, Apr 1 2011 Back to list
Status: Fixed
Owner:
Closed: Mar 2013
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment
What steps will reproduce the problem?
1. Launch Chrome with --ppapi-out-of-process --ppapi-startup-dialog --register-pepper-plugins=...
2. Invoke the plugin.

What is the expected output? What do you see instead?
The plugin process should block waiting for a debugger to connect. Instead, it continues running. The command line for the --type=ppapi process does not have --ppapi-startup-dialog.

Please use labels and text to provide additional information.
Chrome 12.0.721.0 (Developer Build 80096) on Linux

It appears that --ppapi-startup-dialog is not being passed to the ppapi process. The code to handle the switch exists in PpapiPluginMain().
 
Comment 1 Deleted
On Linux, I'd use ppapi-plugin-launcher for now.
Labels: Feature-Plugins-Pepper
Labels: -Feature-Plugins
Labels: Mstone-X
Status: Available
Labels: -Pepper Action-FeedbackNeeded
This appears to work on the top of tree (Version 26.0.1411.0 (181941))

Tested on Linux.

I get this message:
[28483:28483:0301/141604:ERROR:child_process.cc(133)] Ppapi (28483) paused waiting for debugger to attach @ pid
...and the plugin is waiting.

ddorwin, Are you still seeing this problem?
I see the same thing. What does "@ pid" mean?
It would be nice to provide instructions on how to resume after attaching.

The original bug is fixed, though.
Presumably "@ pid" means that it's waiting for the debugger to attach to the given pid.

The code blocks there until it receives SIGUSR1 (on POSIX). I agree that it's worth a note in the log message mentioning that.
Project Member Comment 9 by bugdroid1@chromium.org, Mar 8 2013
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=186852

------------------------------------------------------------------------
r186852 | teravest@chromium.org | 2013-03-08T02:11:40.047071Z

Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/content/common/child_process.cc?r1=186852&r2=186851&pathrev=186852

Doc: SIGUSR1 needed when paused for debugger.

This clarifies the log message printed when a user passes
"--ppapi-startup-dialog" on the command line. It's not obvious how to unpause
the process without reading through the source.

BUG= 78173 


Review URL: https://chromiumcodereview.appspot.com/12624002
------------------------------------------------------------------------
Owner: teravest@chromium.org
Status: Fixed
Project Member Comment 11 by bugdroid1@chromium.org, Mar 9 2013
Labels: -Action-FeedbackNeeded Needs-Feedback
Project Member Comment 12 by bugdroid1@chromium.org, Mar 10 2013
Labels: -Area-Internals -Feature-Plugins-Pepper Cr-Content-Plugins-Pepper Cr-Internals
Project Member Comment 13 by bugdroid1@chromium.org, Apr 6 2013
Labels: Cr-Blink
Project Member Comment 14 by bugdroid1@chromium.org, Apr 6 2013
Labels: Cr-Internals-Plugins
Project Member Comment 15 by bugdroid1@chromium.org, Apr 6 2013
Labels: -Cr-Content-Plugins-Pepper Cr-Internals-Plugins-Pepper
Sign in to add a comment