New issue
Advanced search Search tips

Issue 781726 link

Starred by 0 users
Status: Fixed
Owner:
beccahughes@chromium.org
Closed: Mar 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature



Sign in to add a comment

Alternative MEI: Short sounds

Project Member Reported by beccahughes@chromium.org, Nov 6 2017 
Very short sounds such as IM pings will negatively impact an origin engagement score. In order to avoid this, all media playback that is known to be shorter than the required length will be ignored in the context of the engagement score. Because this could be used a loophole or penalise some websites, UKM events will be recorded when it happens (see Metrics section).

At the moment, the Media Engagement service isn’t aware of the playback length and adding this information will require to plumb it from the renderer process to the browser process.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/220bfc10b3926d1004819c5d5d5c7bc3debaef38

commit 220bfc10b3926d1004819c5d5d5c7bc3debaef38
Author: Becca Hughes <beccahughes@chromium.org>
Date: Tue Nov 14 18:24:07 2017

Add MediaStoppedReason to WCO

Add MediaStoppedReason as an argument to MediaStoppedPlaying on
WebContentsObserver. This will contain information as to
whether the media was stopped because it reached the end.
It is needed for Media Engagement.

BUG= 781726 

Change-Id: I84eee732269cb6859d42ac5a5d34185bbd1d6e2d
Reviewed-on: https://chromium-review.googlesource.com/758583
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516365}
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/android/vr_shell/vr_usage_monitor.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/android/vr_shell/vr_usage_monitor.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/banners/app_banner_manager.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/banners/app_banner_manager.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/engagement/site_engagement_helper.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/engagement/site_engagement_helper.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/engagement/site_engagement_helper_unittest.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chromecast/browser/cast_web_view.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/chromecast/browser/cast_web_view.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/browser/media/session/media_session_browsertest.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/browser/renderer_host/render_process_host_browsertest.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/test/web_contents_observer_sanity_checker.cc
[modify] https://crrev.com/220bfc10b3926d1004819c5d5d5c7bc3debaef38/content/test/web_contents_observer_sanity_checker.h
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8

commit e1dc0700afc71ac232659e1dad6c77e5df1d3eb8
Author: Becca Hughes <beccahughes@chromium.org>
Date: Wed Nov 29 11:52:05 2017

Media Engagement: Short playback detection

Measures playback and ignores any playbacks under a certain threshold.
Triggers a UKM "Media.Engagement.Ignored" event if the value was
ignored.

BUG= 781726 

Change-Id: I368a1ab514ff73c064b84134984278d52f49142a
Reviewed-on: https://chromium-review.googlesource.com/758581
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520078}
[modify] https://crrev.com/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8/chrome/browser/media/media_engagement_browsertest.cc
[modify] https://crrev.com/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8/chrome/browser/media/media_engagement_contents_observer.cc
[modify] https://crrev.com/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8/chrome/browser/media/media_engagement_contents_observer.h
[modify] https://crrev.com/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8/chrome/browser/media/media_engagement_contents_observer_unittest.cc
[modify] https://crrev.com/e1dc0700afc71ac232659e1dad6c77e5df1d3eb8/tools/metrics/ukm/ukm.xml

Comment 3 by mlamouri@chromium.org, Feb 8 2018

Components: Internals>Media>Engagement

Comment 4 by beccahughes@chromium.org, Mar 16 2018

Status: Fixed (was: Assigned)
►

Sign in to add a comment