New issue
Advanced search Search tips

Issue 781724 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocking:
issue 709690



Sign in to add a comment

Use Clang for Windows builds on V8

Project Member Reported by machenb...@chromium.org, Nov 6 2017

Issue description

V8 should follow the default changes from Chromium in issue 709690.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a9bd69f3f90341088d1d8f4c4a34c2e3d5c34691

commit a9bd69f3f90341088d1d8f4c4a34c2e3d5c34691
Author: Michael Achenbach <machenbach@chromium.org>
Date: Mon Nov 06 12:56:25 2017

[build] Switch win-clang to msvs after default has changed

This ports:
https://chromium-review.googlesource.com/c/chromium/src/+/732997

NOTRY=true

Bug:  chromium:781724 
Change-Id: Ib57e94bfa66f7898c10b14ce0c07a12b0c3d25b8
Reviewed-on: https://chromium-review.googlesource.com/753725
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49140}
[modify] https://crrev.com/a9bd69f3f90341088d1d8f4c4a34c2e3d5c34691/infra/mb/mb_config.pyl

Comment 2 by h...@chromium.org, Nov 6 2017

machenbach: Do you expect more work besides the patch that landed?
I'm about to rename the bots and will add some tests to the new win-msvc bot. The old win-clang bot was compile-only, but I feel we should do some more testing on the msvc bot now.
Side question: Are the changes in chromium going to stick? Or is there a possibility to go back to msvc even after some time?
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/eb008c86e136143eb79afd317dad1a8d234d06c5

commit eb008c86e136143eb79afd317dad1a8d234d06c5
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 07 10:39:41 2017

V8: Rename win-clang bots to msvc

TBR=sergiyb@chromium.org

Bug:  chromium:781724 
Change-Id: Iddb37d9416093639ebf3f71877b93800ffe12838
Reviewed-on: https://chromium-review.googlesource.com/753346
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.client.v8/slaves.cfg
[delete] https://crrev.com/af07e22d335a6f2f0a8ccf542b6e8626cf5aadf7/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_clang_compile_rel.json
[rename] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___msvc.json
[copy] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_msvc_compile_rel.json
[modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.client.v8/master.cfg
[modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipe_modules/v8/builders.py
[modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.tryserver.v8/master.cfg
[modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.tryserver.v8/slaves.cfg

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88

commit f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 07 10:44:04 2017

[build] Rename win-clang bots to msvc

Accompanies:
https://chromium-review.googlesource.com/c/chromium/tools/build/+/753346

NOTRY=true
NOTREECHECKS=true

Bug:  chromium:781724 
Change-Id: I51e84d7ee7807e557d500c847c72e06e58175e04
Reviewed-on: https://chromium-review.googlesource.com/754687
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49173}
[modify] https://crrev.com/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88/infra/config/cq.cfg
[modify] https://crrev.com/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88/infra/mb/mb_config.pyl

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/bdb8e9bc90614d76e167b6d46b80dd35776c841b

commit bdb8e9bc90614d76e167b6d46b80dd35776c841b
Author: Michael Achenbach <machenbach@chromium.org>
Date: Tue Nov 07 11:15:44 2017

V8: Add win-msvc bot to lkgr

Bug:  chromium:781724 
Change-Id: Iec39f453b664c7006028c00419f8c3225a8ac5af
Reviewed-on: https://chromium-review.googlesource.com/756744
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>

[modify] https://crrev.com/bdb8e9bc90614d76e167b6d46b80dd35776c841b/infra/services/lkgr_finder/config/v8_cfg.pyl

Status: Verified (was: Assigned)

Comment 10 by h...@chromium.org, Nov 8 2017

> Side question: Are the changes in chromium going to stick? Or is there a possibility to go back to msvc even after some time?

We hope the compiler switch is going to stick, but it's not guaranteed, and we're also committed to keeping the MSVC build working at least for a couple of releases.


Unrelatedly, should we close https://bugs.chromium.org/p/v8/issues/detail?id=6626 or dupe it against this one?
Cc: machenb...@chromium.org
 Issue v8:6626  has been merged into this issue.
Duped it... the disadvantage of having two issue trackers... filing buts twice :(

If it doesn't stick, please ping me, so that we can also switch the win-msvs bot to be clang again - otherwise we loose coverage.

Comment 13 by h...@chromium.org, Nov 9 2017

Will do, thanks.

Sign in to add a comment