Use Clang for Windows builds on V8 |
||
Issue descriptionV8 should follow the default changes from Chromium in issue 709690.
,
Nov 6 2017
machenbach: Do you expect more work besides the patch that landed?
,
Nov 6 2017
I'm about to rename the bots and will add some tests to the new win-msvc bot. The old win-clang bot was compile-only, but I feel we should do some more testing on the msvc bot now.
,
Nov 6 2017
Side question: Are the changes in chromium going to stick? Or is there a possibility to go back to msvc even after some time?
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/eb008c86e136143eb79afd317dad1a8d234d06c5 commit eb008c86e136143eb79afd317dad1a8d234d06c5 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Nov 07 10:39:41 2017 V8: Rename win-clang bots to msvc TBR=sergiyb@chromium.org Bug: chromium:781724 Change-Id: Iddb37d9416093639ebf3f71877b93800ffe12838 Reviewed-on: https://chromium-review.googlesource.com/753346 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.client.v8/slaves.cfg [delete] https://crrev.com/af07e22d335a6f2f0a8ccf542b6e8626cf5aadf7/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_clang_compile_rel.json [rename] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___msvc.json [copy] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_win64_msvc_compile_rel.json [modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.client.v8/master.cfg [modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/scripts/slave/recipe_modules/v8/builders.py [modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.tryserver.v8/master.cfg [modify] https://crrev.com/eb008c86e136143eb79afd317dad1a8d234d06c5/masters/master.tryserver.v8/slaves.cfg
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88 commit f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Nov 07 10:44:04 2017 [build] Rename win-clang bots to msvc Accompanies: https://chromium-review.googlesource.com/c/chromium/tools/build/+/753346 NOTRY=true NOTREECHECKS=true Bug: chromium:781724 Change-Id: I51e84d7ee7807e557d500c847c72e06e58175e04 Reviewed-on: https://chromium-review.googlesource.com/754687 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#49173} [modify] https://crrev.com/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88/infra/config/cq.cfg [modify] https://crrev.com/f4d7ca9135ec1ed3de04c6c6ce69105cf67fab88/infra/mb/mb_config.pyl
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/5164678ee24fef3b0a96b77fcf8f892c8adb31d2 commit 5164678ee24fef3b0a96b77fcf8f892c8adb31d2 Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Nov 07 11:11:01 2017 V8: Add tests to win msvc bot Bug: chromium:781724 Change-Id: Id4770bbeeb1149406a282b0179b5180f16a7212a Reviewed-on: https://chromium-review.googlesource.com/756712 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/5164678ee24fef3b0a96b77fcf8f892c8adb31d2/scripts/slave/recipe_modules/v8/builders.py [modify] https://crrev.com/5164678ee24fef3b0a96b77fcf8f892c8adb31d2/scripts/slave/recipes/v8.expected/full_client_v8_V8_Win64___msvc.json
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/bdb8e9bc90614d76e167b6d46b80dd35776c841b commit bdb8e9bc90614d76e167b6d46b80dd35776c841b Author: Michael Achenbach <machenbach@chromium.org> Date: Tue Nov 07 11:15:44 2017 V8: Add win-msvc bot to lkgr Bug: chromium:781724 Change-Id: Iec39f453b664c7006028c00419f8c3225a8ac5af Reviewed-on: https://chromium-review.googlesource.com/756744 Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> [modify] https://crrev.com/bdb8e9bc90614d76e167b6d46b80dd35776c841b/infra/services/lkgr_finder/config/v8_cfg.pyl
,
Nov 7 2017
,
Nov 8 2017
> Side question: Are the changes in chromium going to stick? Or is there a possibility to go back to msvc even after some time? We hope the compiler switch is going to stick, but it's not guaranteed, and we're also committed to keeping the MSVC build working at least for a couple of releases. Unrelatedly, should we close https://bugs.chromium.org/p/v8/issues/detail?id=6626 or dupe it against this one?
,
Nov 9 2017
,
Nov 9 2017
Duped it... the disadvantage of having two issue trackers... filing buts twice :( If it doesn't stick, please ping me, so that we can also switch the win-msvs bot to be clang again - otherwise we loose coverage.
,
Nov 9 2017
Will do, thanks. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 6 2017