New issue
Advanced search Search tips

Issue 781719 link

Starred by 1 user
Status: Fixed
Owner:
hta@chromium.org
Closed: Nov 2017
Cc:
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Tests for unknown constraints need refinement

Project Member Reported by hta@chromium.org, Nov 6 2017 
How to reproduce:

1) Apply CL 738232 (if not landed)
2) Run fast/mediastream/MediaStreamTrack-applyConstraints.html
3) Observe failure.

The failure seems to be caused by wrong error codes being returned, but also seems to have an issue with applying complex constraints (the now-deleted mock would accept just about any constraint, the current fake doesn't seem to do so).

This also affects MediaStreamTrack-getConstraints.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6

commit 58bf120c5e0261716a20a5c33fdcc3b44f6cedf6
Author: Harald Alvestrand <hta@chromium.org>
Date: Mon Nov 06 18:04:30 2017

Delete MockWebUserMediaClient and calls to it

We believe that the real code, with functions for fake devices,
is the way forward for making testrunner tests. Therefore, this
mock needs to go.

Bugs listed below are bugs filed during patch development.

Bug: 781716,  781719 ,  781772 ,  781774 ,  781777 
Change-Id: Ia28b07270a6874a6c6836542bc0245d39f9efc8d
Reviewed-on: https://chromium-review.googlesource.com/738232
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514173}
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/67eb9df88298a98a719334fa55a27d0ced87239e/content/shell/test_runner/mock_web_user_media_client.cc
[delete] https://crrev.com/67eb9df88298a98a719334fa55a27d0ced87239e/content/shell/test_runner/mock_web_user_media_client.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/content/shell/test_runner/web_frame_test_proxy.h
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/audio-output/setSinkId.https-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/mediacapture-streams/GUM-impossible-constraint.https-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/external/wpt/webrtc/RTCPeerConnection-setLocalDescription-answer-expected.txt
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-creation-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaDevices-devicechange.html
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-stop-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-stop.html
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-applyConstraints-expected.txt
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getConstraints-expected.txt
[modify] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-getSettings.html
[add] https://crrev.com/58bf120c5e0261716a20a5c33fdcc3b44f6cedf6/third_party/WebKit/LayoutTests/fast/mediastream/getusermedia-constraints-expected.txt

Comment 2 by niklase@chromium.org, Nov 10 2017

Owner: hta@chromium.org
Status: Started (was: Untriaged)

Comment 3 by hta@chromium.org, Nov 10 2017 

 Issue 781777  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 24 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acb254d290582bb6e34fb4ca64b53acd37fdb1fc

commit acb254d290582bb6e34fb4ca64b53acd37fdb1fc
Author: Harald Alvestrand <hta@chromium.org>
Date: Fri Nov 24 14:32:35 2017

Change applyConstraints test to exercise existing functionality

The audio track doesn't do applyConstraints well yet, so switch
to using video tracks, which do work.
Change constraints to not overconstrain the video track.

Bug:  781719 
Change-Id: I3c6d14e35e65c772ceaad5941323a9530bd5c171
Reviewed-on: https://chromium-review.googlesource.com/789033
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519107}
[delete] https://crrev.com/200f617af7417dda3459db0bc50d4856bbfeeefc/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-applyConstraints-expected.txt
[modify] https://crrev.com/acb254d290582bb6e34fb4ca64b53acd37fdb1fc/third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-applyConstraints.html

Comment 5 by hta@chromium.org, Nov 24 2017

Status: Fixed (was: Started)
►

Sign in to add a comment