New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781705 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Cannot start selection with SVG <tspan>.

Reported by babata...@gmail.com, Nov 6 2017

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/64.0.3260.0 Safari/537.36

Example URL:
https://jsbin.com/kutonusige/edit?html,output

Steps to reproduce the problem:
1. Press left mouse button on "H"ello on the first line.
2. Hold down the button and move the cursor to right.

What is the expected behavior?
"Hello, world" on the first line should be selected.

What went wrong?
Only "H" is selected. The selection range won't be expanded.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes 62.0.3202.75(Official Build)

Does this work in other browsers? Yes

Chrome version: 64.0.3260.0  Channel: canary
OS Version: 10.0
Flash Version: 

It works well if the selection is started from outside of <tspan> ("x").
 
problem.mp4
517 KB View Download
Labels: Needs-Triage-M64 Needs-Bisect
Components: Blink>SVG
Cc: divya.pa...@techmahindra.com
Labels: -Pri-2 -Type-Compat -Needs-Bisect hasbisect-per-revision Triaged-ET M-64 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: yoichio@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce this issue on reported version 64.0.3260.0 and latest Canary 64.0.3261.0 using win 10, Linux 14.04 and Mac 10.12.6

Below is the Manual bisect info:
--------------------------------
Good Build: 63.0.3239.0
Bad Build: 64.0.3240.0

Bisect Tool info:
----------------------------------
You are probably looking for a change made after 508634 (known good), but no later than 508636 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/65c9ac8db53ee49af6ba853ac69a4d9cff502bff..a56445999783667165dabe5ed082b2cec00247a7

Possible suspect:
https://chromium-review.googlesource.com/714939

@Yoichi Osato,Kindly take a look and please help us to reassign this issue to a right owner if not with respect to this change.

Thanks.!
Components: Blink>Editing>Selection
Labels: -Needs-Triage-M64 FoundIn-64 RegressedIn-64
Ping! This is a P1 regression subject to our 30 day goal for fixes. Let us know if you can resolve the issue by then, otherwise we can consider reverting the patch that broke it given that it was a refactoring patch.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a0aeb16c2083c9bd56aed8d410fca532f338846

commit 6a0aeb16c2083c9bd56aed8d410fca532f338846
Author: Yoichi Osato <yoichio@chromium.org>
Date: Thu Nov 16 04:31:39 2017

Invalidate LayoutSVGText if descendant LayoutObject is invalidated.

We used to invalidate only parent LayoutSVGText but
need invalidate ancestor LayoutSVGText because LayoutSVGText
consists of a tree like "<svg><text><tspan>foo</tspan></text></svg>".

Bug:  781705 
Change-Id: I12b38a7a4a78c7bff3e90698e3f64e62fac6101a
Reviewed-on: https://chromium-review.googlesource.com/771061
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516985}
[modify] https://crrev.com/6a0aeb16c2083c9bd56aed8d410fca532f338846/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
[modify] https://crrev.com/6a0aeb16c2083c9bd56aed8d410fca532f338846/third_party/WebKit/Source/core/editing/LayoutSelectionTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment