New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781699 link

Starred by 14 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-11-13
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Incomplete rendering, may be related to css transform and scale and perspective

Reported by qq641016...@gmail.com, Nov 6 2017

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/62.0.3202.75 Safari/537.36

Steps to reproduce the problem:
1. Visit http://csswg.zsjp.cn/SYDindex.html?sceneId=12870&type=edit

I do not know how to locate the reason.

What is the expected behavior?
Should be fully rendered

What went wrong?
Incomplete rendering, missing view.

Did this work before? N/A 

Does this work in other browsers? N/A

Chrome version: 62.0.3202.75  Channel: stable
OS Version: OS X 10.12.6
Flash Version: 

Safari and Firefox are fully displayed, and you can use them to access the url[http://csswg.zsjp.cn/SYDindex.html?sceneId=12870&type=edit]
 

Comment 1 by woxxom@gmail.com, Nov 6 2017

Bisect info: 496954 (good) - 496956 (bad)
https://chromium.googlesource.com/chromium/src/+log/ecde55dc..3171659e?pretty=fuller
Suspecting r496956 - 3171659ead3e26b743effcdd6cc22d43e48a16e1 
"Expand interest rect with padding in root space, not local layer space"
Landed in 62.0.3196.0
good.jpg
345 KB View Download
bad.jpg
282 KB View Download
Why is red, see the attachment

Thank you for your help, but I can not understand it.
I do not know what to do to make it fully visible.

My English is not good..
089D5A06-B2B0-4823-A469-65F0AA00E152.png
594 KB View Download
Components: Blink>CSS
Labels: -Type-Bug -Pri-2 M-64 Pri-1 Type-Bug-Regression
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
Suspected CL from #1 - https://chromium.googlesource.com/chromium/src/+/3171659ead3e26b743effcdd6cc22d43e48a16e1

Assigning to the CL owner for further updates.Tagging for M64.
Labels: ReleaseBlock-Stable

Comment 5 by meade@chromium.org, Nov 7 2017

Components: -Blink>CSS Blink>Paint
Labels: Regressed-In-62 found-in-62
Components: -Blink>Paint Blink>Compositing
Labels: -found-in-62 -Regressed-In-62 RegressedIn-62 FoundIn-62
Reduced testcase attached. The bug has to do with perspective transforms.
test.html
410 bytes View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/692d8c95a4a76ff431b17ab760684aa3e4852d30

commit 692d8c95a4a76ff431b17ab760684aa3e4852d30
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Nov 09 20:37:16 2017

Expand interest rect in GraphicsLayer space, adjusted for approximate layer scale.

An earlier patch moved expansion of the interest rect to root space, but this
doesn't work for non-linear transforms like perspective. The intent of the earlier
patch was to account for layer scale when determining the amount to expand, with
the intent to expand by a certain number of pixels in screen space, not layer
space. This patch achieves the same result, but changing the expansion amount by
the scale factor.

Bug:  781699 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85bcbd8301caa8b3abd36035df63f3eca0e1235c
Reviewed-on: https://chromium-review.googlesource.com/758821
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515275}
[modify] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect-expected.png
[add] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect-expected.txt
[add] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect.html
[add] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/LayoutTests/platform/mac/compositing/perspective-interest-rect-expected.png
[modify] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/692d8c95a4a76ff431b17ab760684aa3e4852d30/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp

Labels: -M-64 Merge-Request-63 M-63
Would like to merge this to 63. It's very safe and avoids continuing an M62
regression to M63.
NextAction: 2017-11-10
Cl listed at #10 is not in canary yet. Please update the bug once change is verified and baked in canary. Thank you.
Cc: ranjitkan@chromium.org
Labels: TE-Verified-M64 TE-Verified-64.0.3264.0
Rechecked this issue on chrome canary version 64.0.3264.0 on Mac 10.12.6 and fix is working as intended. Screen shot attached.

Adding TE-Verified labels for M64.

Thanks.!
Rendering_Img.png
6.0 MB View Download
The NextAction date has arrived: 2017-11-10
Change is now verified and in the Canary channel.
Thank you  chrishtr@. Can we wait until Monday for canary baking?
Sure, ok.
NextAction: 2017-11-13
chrishtr@, pls update bug on Monday with Canary result. Thank you.
Cc: chrishtr@chromium.org
 Issue 783783  has been merged into this issue.
Project Member

Comment 20 by sheriffbot@chromium.org, Nov 10 2017

Labels: -Merge-Request-63 Merge-Review-63 Hotlist-Merge-Review
This bug requires manual review: M63 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I updated the canary and it worked fine in the canary.

Cc: divya.pa...@techmahindra.com
 Issue 783110  has been merged into this issue.
The NextAction date has arrived: 2017-11-13
It's Monday, and I can confirm that it works fine in Canary. Approval for 63
 merge?
Labels: -Merge-Review-63 Merge-Approved-63
Approving merge to M63 branch 3239 based on comments #13 and #24. Please merge today before 4:00 PM PT so we can take it in for this week beta release. Thank you.
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 13 2017

Labels: -merge-approved-63 merge-merged-3239
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c683bffdd55b0292d0e5a8fabc15e256cbf94457

commit c683bffdd55b0292d0e5a8fabc15e256cbf94457
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Mon Nov 13 19:57:55 2017

Expand interest rect in GraphicsLayer space, adjusted for approximate layer scale.

An earlier patch moved expansion of the interest rect to root space, but this
doesn't work for non-linear transforms like perspective. The intent of the earlier
patch was to account for layer scale when determining the amount to expand, with
the intent to expand by a certain number of pixels in screen space, not layer
space. This patch achieves the same result, but changing the expansion amount by
the scale factor.

TBR=chrishtr@chromium.org

(cherry picked from commit 692d8c95a4a76ff431b17ab760684aa3e4852d30)

Bug:  781699 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I85bcbd8301caa8b3abd36035df63f3eca0e1235c
Reviewed-on: https://chromium-review.googlesource.com/758821
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#515275}
Reviewed-on: https://chromium-review.googlesource.com/767148
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#464}
Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578}
[modify] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
[add] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect-expected.png
[add] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect-expected.txt
[add] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/LayoutTests/compositing/perspective-interest-rect.html
[add] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/LayoutTests/platform/mac/compositing/perspective-interest-rect-expected.png
[modify] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp
[modify] https://crrev.com/c683bffdd55b0292d0e5a8fabc15e256cbf94457/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMappingTest.cpp

Status: Fixed (was: Assigned)
 Issue 784903  has been merged into this issue.
 Issue 784908  has been merged into this issue.
Labels: TE-Verified-63.0.3239.52
Verified the issue on latest Chrome Beta i.e., 63.0.3239.52 on Mac.

Comment 31 Deleted

Cc: vamshi.k...@techmahindra.com
 Issue 792366  has been merged into this issue.

Sign in to add a comment