New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781696 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Modernize resource_sizes.py

Project Member Reported by benjhayden@chromium.org, Nov 6 2017

Issue description

src/build/android/resource_sizes.py uses perf_tests_results_helper to produce chartjson containing measurements of Chromium resource sizes. This chartjson is then uploaded to the chromeperf dashboard.
https://cs.chromium.org/chromium/src/build/android/resource_sizes.py

Over 2018, chartjson will be deprecated in favor of HistogramSets:
https://github.com/catapult-project/catapult/blob/master/docs/how-to-write-metrics.md
https://codesearch.chromium.org/chromium/src/third_party/catapult/tracing/tracing/value/histogram_set.py

resource_sizes.py should be updated to use the new library, and moved to tools/perf/.

The chromeperf dashboard is not quite ready to accept Histograms yet, so I'll assign this to myself until it is, then I'll see if anybody wants to drive updating this script.
 
Owner: ----
Status: Available (was: Assigned)
Cc: -eakuefner@chromium.org
Status: Fixed (was: Available)
It looks like that script was renamed and modernized, so I think this is done?
https://cs.chromium.org/chromium/src/build/android/diff_resource_sizes.py
C.f. https://bugs.chromium.org/p/chromium/issues/detail?id=892065

Sign in to add a comment