New issue
Advanced search Search tips

Issue 781691 link

Starred by 1 user
Status: Fixed
Owner:
dpranke@chromium.org
Closed: Jan 2018
Cc:
bbudge@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Broke webkit mac compile undetected by CQ

Project Member Reported by machenb...@chromium.org, Nov 6 2017 
See 
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder/builds/224305
and
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac%20Builder%20%28dbg%29/builds/219579

The V8 roll https://chromium-review.googlesource.com/c/chromium/src/+/741328 broke both webkit mac release and debug builders (compile).

Why didn't the CQ detect the breakage? Are there compile targets missing on CQ for mac? Or was this some last-minute interaction on HEAD?

Broke due to this CL on V8-side:
https://chromium-review.googlesource.com/c/v8/v8/+/741762

Comment 1 by jbudorick@chromium.org, Jan 4 2018

Labels: OS-Mac
Owner: dpranke@chromium.org
Status: Fixed (was: Untriaged)
CQ didn't detect the breakage because the CQ didn't include any of the mac*_blink_rel trybots, which at the time were the only bots that mirrored WebKit Mac Builder. (Those aren't part of the CQ by default; it looks like the roll CL included include linux_trusty_blink_rel in its CQ_INCLUDE_TRYBOTS but not the equivalent mac or windows trybots.)

dpranke landed https://chromium.googlesource.com/chromium/tools/build/+/6d9b47a7fcd6d5f7463c83a8f1ac717859091a74 last month, which, among other things, added WebKit Mac Builder to the list of bots mirrored by mac_chromium_rel_ng. As such, this should be fixed.
►

Sign in to add a comment