New issue
Advanced search Search tips

Issue 781680 link

Starred by 1 user
Status: Fixed
Owner:
tikuta@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

Remove LTCG from link command

Project Member Reported by meade@chromium.org, Nov 6 2017 
LINK : /LTCG specified but no code generation required; remove /LTCG from the link command line to improve linker performance

I noticed on the Google Chrome Win bot (https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Win), the below line appears 61 times in this build: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chrome%2FGoogle_Chrome_Win%2F23559%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout  

Perhaps we should remove it?

Comment 1 by sergeybe...@chromium.org, Jan 9 2018

Components: -Infra>Client>Chrome Build
Labels: OS-Windows
First, I don't think this bug belongs to Infra>Client>Chrome. This is a build config problem, and should probably handled by people most familiar with chromium / chrome build process. Moving it to "Build" (it seems more fitting - please re-triage as necessary).

Confirmed that the message is still there in today's build: https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/25723

Quick code search reveals quite a few places LTCG is set, so I'm not sure which one is relevant here. E.g.: https://cs.chromium.org/chromium/src/build/config/compiler/BUILD.gn?type=cs&q=LTCG&sq=package:chromium&l=1602

Comment 2 by tikuta@chromium.org, Jan 10 2018

Owner: tikuta@chromium.org
Status: Started (was: Untriaged)
Made CL.
https://chromium-review.googlesource.com/c/chromium/src/+/859409
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 10 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39b4dda89c4493a5b7848162dbcc8a5ac58ffee6

commit 39b4dda89c4493a5b7848162dbcc8a5ac58ffee6
Author: Takuto Ikuta <tikuta@google.com>
Date: Wed Jan 10 14:24:50 2018

Do not pass /LTCG for clang-cl build

Bug:  781680 , 598772
Change-Id: I5b746386516ddb153892a91b19e8c1689f09e94f
Reviewed-on: https://chromium-review.googlesource.com/859409
Commit-Queue: Takuto Ikuta <tikuta@google.com>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528305}
[modify] https://crrev.com/39b4dda89c4493a5b7848162dbcc8a5ac58ffee6/build/config/compiler/BUILD.gn

Comment 4 by tikuta@chromium.org, Jan 11 2018

Status: Fixed (was: Started)
►

Sign in to add a comment