Create provider_id class to replace string and temporary DCHECK() macro used in provided_file_system/service.cc References:https://docs.google.com/a/google.com/document/d/1gmWxT8fN9NUMaAkpTJqQ7E-0mzCRqRgtIwz-1O8Zw5I/edit?usp=sharing
Is there a launch bug for this feature? If so, please mark this as a blocker.
There is not one yet, but we will mark this as a blocker when the launch bug is created.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/47cdb652e9a853cc8f2d181c202c8eb60b8620e0 commit 47cdb652e9a853cc8f2d181c202c8eb60b8620e0 Author: Bailey Berro <baileyberro@chromium.org> Date: Mon Nov 27 17:22:59 2017 Refactoring FileSystemInfo::provider_id from a string to a class. Bug: 781666 Change-Id: Ieb0441d0b21df26432f2668ab46fe545d9ae5fba Reviewed-on: https://chromium-review.googlesource.com/775776 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#519324} [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/extensions/file_manager/private_api_util.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/extensions/file_system_provider/provider_function.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_manager/volume_manager.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/fake_registry.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/fake_registry.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/mount_path_util.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/mount_path_util.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/notification_manager.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/operations/operation.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/provided_file_system.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/provided_file_system_info.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/provided_file_system_info.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/registry.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/registry.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/registry_interface.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/registry_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/service.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/service.h [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/file_system_provider/service_unittest.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/smb_client/smb_service.cc [modify] https://crrev.com/47cdb652e9a853cc8f2d181c202c8eb60b8620e0/chrome/browser/chromeos/smb_client/smb_service_unittest.cc
Comment 1 by mtomasz@chromium.org
, Nov 7 2017Status: Assigned (was: Untriaged)