v8_context_snapshot_generator failed when using GetSingleThreadTaskRunner() in BlinkInitializer |
|||
Issue descriptionChrome Version: ToT OS: All What steps will reproduce the problem? (1) Add the following line in blink::Initialize() and build content_shell with use_v8_context_snapshot = true. CHECK(Platform::Current()->MainThread()->GetSingleThreadTaskRunner()); What is the expected result? Build succeed. What happens instead? FAILED: v8_context_snapshot.bin python ../../build/gn_run_binary.py ./v8_context_snapshot_generator --output_file=v8_context_snapshot.bin ./v8_context_snapshot_generator failed with exit code -11 [4/12] SOLINK ./libtest_runner.so ninja: build stopped: subcommand failed. Please use labels and text to provide additional information. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Nov 6 2017
It is because Platform::Current()->MainThread()->GetWebTaskRunner() returns nullptr in v8_context_snapshot_generator. https://cs.chromium.org/chromium/src/tools/v8_context_snapshot/v8_context_snapshot_generator.cc?l=24 (WebThread::GetSingleThreadTaskRunner returns its GetWebTaskRunner().) Now we have no alternates, so please check if it returns nullptr and avoid its actual usages for now.
,
Nov 6 2017
Thanks, please feel free to close this, or we may want to add warnings in SnapshotThread, as it's difficult to figure out what's wrong :)
,
Nov 6 2017
Thanks. Let me close this. and I agree to have the message. |
|||
►
Sign in to add a comment |
|||
Comment 1 by bashi@chromium.org
, Nov 6 2017Status: Assigned (was: Available)