Create SambaService class that implements a keyed service to be called when adding/removing a Samba instance. Design doc: https://docs.google.com/a/google.com/document/d/1gmWxT8fN9NUMaAkpTJqQ7E-0mzCRqRgtIwz-1O8Zw5I/edit?usp=sharing
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb3f4a80662fab2a9712aa5d1d13368881b0febc commit fb3f4a80662fab2a9712aa5d1d13368881b0febc Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Nov 08 01:38:04 2017 Adding file_system_factory_map to service.cc Bug: 781657 Test: FileSystemProviderServiceTest.RegisterFileSystemFactory Change-Id: I32f618bc277f2e6386b07e9b4cc5b3b5d2710863 Reviewed-on: https://chromium-review.googlesource.com/753296 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#514700} [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_reader_unittest.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/fileapi/file_stream_writer_unittest.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/mount_path_util_unittest.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/service.cc [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/service.h [modify] https://crrev.com/fb3f4a80662fab2a9712aa5d1d13368881b0febc/chrome/browser/chromeos/file_system_provider/service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d999ee741695c584f2aba411afb0d0a63b5b7077 commit d999ee741695c584f2aba411afb0d0a63b5b7077 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Nov 15 19:27:40 2017 Extracting classes from service_unittest to make resuable - Moves FakeRegistry to separate files. - Moves LoggingObserver to separate files. - Doesn't change any code in the moved classes. Bug: 781657 Change-Id: I5e8d854b9dea00be2da0e2e36b8def5d0bbcc32d Reviewed-on: https://chromium-review.googlesource.com/767887 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Cr-Commit-Position: refs/heads/master@{#516783} [modify] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/file_system_provider/fake_registry.cc [add] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/file_system_provider/fake_registry.h [add] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/file_system_provider/logging_observer.cc [add] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/file_system_provider/logging_observer.h [modify] https://crrev.com/d999ee741695c584f2aba411afb0d0a63b5b7077/chrome/browser/chromeos/file_system_provider/service_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a9357eb964eda3044ca86eeb2c75aea198d23ef2 commit a9357eb964eda3044ca86eeb2c75aea198d23ef2 Author: Bailey Berro <baileyberro@chromium.org> Date: Wed Nov 15 22:05:11 2017 Creating SmbService to manage smb filesystems - Adds SmbService and SmbServiceFactory. - Implements Mount method. - Creates SmbServiceTest file to test the Smb Filesystem impl Bug: 781657 Test: SmbServiceTest Change-Id: Ic73cbc030a1d1ef9c1d875e5719c439f79eadc11 Reviewed-on: https://chromium-review.googlesource.com/767893 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by: Tomasz Mikolajewski <mtomasz@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#516848} [modify] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/BUILD.gn [add] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/smb_client/smb_service.cc [add] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/smb_client/smb_service.h [add] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/smb_client/smb_service_factory.cc [add] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/smb_client/smb_service_factory.h [add] https://crrev.com/a9357eb964eda3044ca86eeb2c75aea198d23ef2/chrome/browser/chromeos/smb_client/smb_service_unittest.cc
Comment 1 by baileyberro@chromium.org
, Nov 7 2017