New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781655 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocked on:
issue 390749

Blocking:
issue 836870



Sign in to add a comment

Mojofy and onion soup content/common/speech_recognition_messages.h

Project Member Reported by slangley@chromium.org, Nov 6 2017

Issue description

- Convert all IPCs to mojo.
- Move the code into the right place inside //blink.
 
I am new to chromium. I am interested to work on this bug. Plz do let me know some  reference gerrit link 
Cc: olka@chromium.org
Labels: -Type-Bug Type-Task
Owner: maxmorin@chromium.org
Status: Assigned (was: Available)
maxmorin@ - Is it possible for somebody to take a look at this in the not too distant future?
Owner: sashab@chromium.org
Actually sashab@ is keen to take a look :).
Cc: maxmorin@chromium.org

Comment 5 by sashab@chromium.org, Nov 26 2017

Blockedon: 390749

Comment 6 by sashab@chromium.org, Dec 19 2017

Cc: slangley@chromium.org sa...@chromium.org noel@chromium.org
As it turns out, this patch is a little complicated, mainly because it involves RenderViews talking to the RenderProcessHost.

I have a design doc here - https://docs.google.com/document/d/125IipVCwKSDOaJAOyATmM5Lue2dMo0fshLoj4-8JfOg/edit

Basically, the design involves:
1. On the renderer side (in the RenderView), SpeechRecognitionDispatcher holds a SpeechRecognitionRequestClient, which holds an array of SpeechRecognitionRequest objects (each with a Binding)
2. On the browser side (in the RenderProcessHost), SpeechRecognitionDispatcherHost also holds an array of SpeechRecognitionRequestClient objects, each with a Binding
3. In the Start() message (Browser -> Renderer), send the SpeechRecognitionRequestClient object! Now the Browser can send messages on this directly

Hopefully that makes sense. I've attached a diagram I made. Since my team is moving to ChromeOS, after the patch to convert the Renderer -> Browser messages lands (https://chromium-review.googlesource.com/790035), I'll unassign myself as owner of this bug :)

KSSSFVcThqk.png
123 KB View Download
Shifting focus to work on ChromeOS now.

Renderer -> Browser messages patch is working, except for some seemingly unrelated test case failures in Android - https://chromium-review.googlesource.com/790035

Follow-up patch converts Origin to a url::origin - https://chromium-review.googlesource.com/866512
Owner: ----
Status: Available (was: Assigned)
Owner: adithyas@chromium.org
Status: Assigned (was: Available)
Blocking: 836870
Project Member

Comment 11 by bugdroid1@chromium.org, Apr 26 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae

commit 28ba8fc3522dfd6e3bfafd33a126e736d492b8ae
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu Apr 26 22:22:29 2018

Mojoify renderer -> browser messages for speech_recognition

Bug:  781655 
Change-Id: I2bb5975fbdcbb3e888c089eeb9be674b7e16a723
Reviewed-on: https://chromium-review.googlesource.com/1013687
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#554170}
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/common/BUILD.gn
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/common/speech_recognition_messages.h
[add] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/common/speech_recognizer.mojom
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/BUILD.gn
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/speech_recognition_grammar.h
[add] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/speech_recognition_grammar.mojom
[add] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/speech_recognition_grammar.typemap
[add] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/speech_recognition_grammar_struct_traits.cc
[add] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/speech_recognition_grammar_struct_traits.h
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/public/common/typemaps.gni
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/28ba8fc3522dfd6e3bfafd33a126e736d492b8ae/content/renderer/speech_recognition_dispatcher.h

Project Member

Comment 13 by bugdroid1@chromium.org, May 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db1039b3ed35c9424981b4d2db15ed2cf1187f6c

commit db1039b3ed35c9424981b4d2db15ed2cf1187f6c
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Mon May 14 15:58:48 2018

Mojoify browser -> renderer messages for speech_recognition

Bug:  781655 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I1345c5084f5dfe6788710d96d37103125f6cb6c0
Reviewed-on: https://chromium-review.googlesource.com/1036230
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558328}
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/chrome/browser/vr/speech_recognizer_unittest.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/renderer_host/render_view_host_impl.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/speech/speech_recognition_manager_impl.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/common/BUILD.gn
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/common/content_message_generator.h
[delete] https://crrev.com/0077b0092a63997b28b3073612466848bf817930/content/common/speech_recognition_messages.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/common/speech_recognizer.mojom
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/browser/speech_recognition_manager.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/browser/speech_recognition_session_context.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/browser/speech_recognition_session_context.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/BUILD.gn
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_error.h
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_error.mojom
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_error.typemap
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_error_struct_traits.cc
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_error_struct_traits.h
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_result.mojom
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_result.typemap
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_result_struct_traits.cc
[add] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/speech_recognition_result_struct_traits.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/common/typemaps.gni
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/test/fake_speech_recognition_manager.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/public/test/fake_speech_recognition_manager.h
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/db1039b3ed35c9424981b4d2db15ed2cf1187f6c/content/renderer/speech_recognition_dispatcher.h

Project Member

Comment 14 by bugdroid1@chromium.org, May 17 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b6158fa944457f3bf2f8c246167ae38aea21609

commit 2b6158fa944457f3bf2f8c246167ae38aea21609
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Thu May 17 22:26:36 2018

Remove content::SpeechRecognitionGrammar

This CL changes mojom::SpeechRecognitionGrammar to use mojom.url.Url for
the url field, and replaces all uses of content::SpeechRecognitionGrammar
with mojom::SpeechRecognitionGrammar.

Bug:  781655 
Change-Id: I2af2809bfdb578b489cd0c10f11af18434078f3e
Reviewed-on: https://chromium-review.googlesource.com/1045245
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#559708}
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/browser/speech/speech_recognition_engine.cc
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/browser/speech/speech_recognition_engine.h
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/public/browser/speech_recognition_session_config.h
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/public/common/BUILD.gn
[delete] https://crrev.com/b54290b2cafd4b2dd877d2a200625db68ed71dd3/content/public/common/speech_recognition_grammar.h
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/public/common/speech_recognition_grammar.mojom
[delete] https://crrev.com/b54290b2cafd4b2dd877d2a200625db68ed71dd3/content/public/common/speech_recognition_grammar.typemap
[delete] https://crrev.com/b54290b2cafd4b2dd877d2a200625db68ed71dd3/content/public/common/speech_recognition_grammar_struct_traits.cc
[delete] https://crrev.com/b54290b2cafd4b2dd877d2a200625db68ed71dd3/content/public/common/speech_recognition_grammar_struct_traits.h
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/public/common/typemaps.gni
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/public/test/fake_speech_recognition_manager.cc
[modify] https://crrev.com/2b6158fa944457f3bf2f8c246167ae38aea21609/content/renderer/speech_recognition_dispatcher.cc

Project Member

Comment 16 by bugdroid1@chromium.org, May 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ce74950625bae7fd1898f8a2646e48df66a69347

commit ce74950625bae7fd1898f8a2646e48df66a69347
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Mon May 28 16:12:40 2018

Remove content::SpeechRecognitionError

This CL removes content::SpeechRecognitionError,
content::SpeechRecognitionErrorCode and content::SpeechAudioErrorDetails
and replaces their uses with their equivalent mojom types.

Bug:  781655 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: I702de83db5b20b333d6b85bedf65e24b8ed37098
Reviewed-on: https://chromium-review.googlesource.com/1050426
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#562273}
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/chrome/browser/speech/speech_recognizer.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/chrome/browser/vr/speech_recognizer_unittest.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_engine.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_engine.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_engine_unittest.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_manager_impl.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognizer_impl_android.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/android/BUILD.gn
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/android/java/src/org/chromium/content/browser/SpeechRecognitionImpl.java
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/browser/speech_recognition_event_listener.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/browser/speech_recognition_manager_delegate.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/common/BUILD.gn
[delete] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/content/public/common/speech_recognition_error.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/common/speech_recognition_error.mojom
[delete] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/content/public/common/speech_recognition_error.typemap
[add] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/common/speech_recognition_error_code.mojom
[delete] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/content/public/common/speech_recognition_error_struct_traits.cc
[delete] https://crrev.com/dca90b1cc90ac15f8635740bd047bc86391de85d/content/public/common/speech_recognition_error_struct_traits.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/common/typemaps.gni
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/public/test/fake_speech_recognition_manager.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/content/renderer/speech_recognition_dispatcher.h
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/extensions/shell/browser/shell_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/ce74950625bae7fd1898f8a2646e48df66a69347/extensions/shell/browser/shell_speech_recognition_manager_delegate.h

Project Member

Comment 17 by bugdroid1@chromium.org, Jun 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e75e328a026878f90373d4055f8a582da0f9e7e0

commit e75e328a026878f90373d4055f8a582da0f9e7e0
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Jun 01 15:09:00 2018

Remove content::SpeechRecognitionResult

Removes content::SpeechRecognitionResult and
content::SpeechRecognitionHypothesis, and replaces all uses with the
equivalent mojom type.

Bug:  781655 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Iaa22636b0f9f0304aab2634280f9d85421f14796
Reviewed-on: https://chromium-review.googlesource.com/1070587
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563631}
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/chrome/browser/speech/speech_recognizer.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/chrome/browser/vr/speech_recognizer_unittest.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_engine.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_engine.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_engine_unittest.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_manager_impl.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognizer_impl_android.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/browser/speech_recognition_event_listener.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/browser/speech_recognition_manager.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/common/BUILD.gn
[delete] https://crrev.com/94c082d42d63ce1e43c126057c627dfedf2990bd/content/public/common/speech_recognition_result.cc
[delete] https://crrev.com/94c082d42d63ce1e43c126057c627dfedf2990bd/content/public/common/speech_recognition_result.h
[delete] https://crrev.com/94c082d42d63ce1e43c126057c627dfedf2990bd/content/public/common/speech_recognition_result.typemap
[delete] https://crrev.com/94c082d42d63ce1e43c126057c627dfedf2990bd/content/public/common/speech_recognition_result_struct_traits.cc
[delete] https://crrev.com/94c082d42d63ce1e43c126057c627dfedf2990bd/content/public/common/speech_recognition_result_struct_traits.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/common/typemaps.gni
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/test/fake_speech_recognition_manager.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/public/test/fake_speech_recognition_manager.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/content/renderer/speech_recognition_dispatcher.h
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/extensions/shell/browser/shell_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/e75e328a026878f90373d4055f8a582da0f9e7e0/extensions/shell/browser/shell_speech_recognition_manager_delegate.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jun 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f

commit c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Tue Jun 12 14:28:14 2018

Move Speech Recognition mojom files to Blink

Bug:  781655 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: Ibb77d27b07e71440052b32f2aaa55925f8594d4e
Reviewed-on: https://chromium-review.googlesource.com/1072747
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#566416}
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/chrome/browser/speech/chrome_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/chrome/browser/speech/chrome_speech_recognition_manager_delegate.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/chrome/browser/speech/speech_recognizer.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/chrome/browser/vr/speech_recognizer.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/chrome/browser/vr/speech_recognizer_unittest.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_browsertest.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_engine.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_engine.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_engine_unittest.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_manager_impl.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognition_manager_impl.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognizer_impl.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognizer_impl.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognizer_impl_android.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognizer_impl_android.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/browser/speech/speech_recognizer_impl_unittest.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/common/BUILD.gn
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/android/BUILD.gn
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/android/java/src/org/chromium/content/browser/SpeechRecognitionImpl.java
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/browser/speech_recognition_event_listener.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/browser/speech_recognition_manager.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/browser/speech_recognition_session_config.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/common/BUILD.gn
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/test/fake_speech_recognition_manager.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/public/test/fake_speech_recognition_manager.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/renderer/speech_recognition_dispatcher.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/content/renderer/speech_recognition_dispatcher.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/extensions/shell/browser/shell_speech_recognition_manager_delegate.cc
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/extensions/shell/browser/shell_speech_recognition_manager_delegate.h
[modify] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/BUILD.gn
[add] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/OWNERS
[rename] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/speech_recognition_error.mojom
[rename] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/speech_recognition_error_code.mojom
[rename] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/speech_recognition_grammar.mojom
[rename] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/speech_recognition_result.mojom
[rename] https://crrev.com/c35bf396d6b5062e0b9ce418b33a72a01e4b1f9f/third_party/blink/public/mojom/speech/speech_recognizer.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Jun 12 2018

Project Member

Comment 20 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5b33428689a900261141871bf5346acf7619640

commit f5b33428689a900261141871bf5346acf7619640
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Fri Jun 22 14:17:59 2018

Onion soupify SpeechRecognition

Removes content/renderer/speech_recognition_dispatcher and moves
functionality into blink. Also removes layering in blink/public/web
that is now unneeded. Design doc is linked in the bug below (Comment #15).

Bug:  781655 
Change-Id: Ie777279386b08b2fd897bb5cefa1855733f19cb3
Reviewed-on: https://chromium-review.googlesource.com/1081092
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569603}
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/browser/speech/speech_recognition_dispatcher_host.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/browser/speech/speech_recognition_dispatcher_host.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/renderer/BUILD.gn
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/renderer/render_frame_impl.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/content/renderer/speech_recognition_dispatcher.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/content/renderer/speech_recognition_dispatcher.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/BUILD.gn
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/content/shell/test_runner/mock_web_speech_recognizer.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/content/shell/test_runner/mock_web_speech_recognizer.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/test_runner_for_specific_view.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/web_frame_test_client.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/web_frame_test_client.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/content/shell/test_runner/web_frame_test_proxy.h
[add] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/mock-speechrecognizer.js
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-basics.html
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash.html
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-errors.html
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-re-restart.html
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/WebKit/LayoutTests/fast/speech/scripted/start-exception-expected.txt
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/WebKit/LayoutTests/fast/speech/scripted/start-exception.html
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/public/BUILD.gn
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/public/web/web_local_frame_client.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_grammar.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_recognition_handle.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_recognition_params.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_recognition_result.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_recognizer.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/public/web/web_speech_recognizer_client.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/exported/BUILD.gn
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/exported/web_speech_grammar.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/exported/web_speech_recognition_handle.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/exported/web_speech_recognition_result.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/exported/web_speech_recognizer_client.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/modules_initializer.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/BUILD.gn
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/DEPS
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/speech_recognition.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/speech_recognition.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/speech/speech_recognition_client.h
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/speech/speech_recognition_client_proxy.cc
[delete] https://crrev.com/4d5c7dd3680d7018c785549be54ae9b0e837ef59/third_party/blink/renderer/modules/speech/speech_recognition_client_proxy.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/speech_recognition_controller.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/speech_recognition_controller.h
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/modules/speech/speech_recognition_error.cc
[modify] https://crrev.com/f5b33428689a900261141871bf5346acf7619640/third_party/blink/renderer/platform/mojo/revocable_interface_ptr.h

Project Member

Comment 21 by bugdroid1@chromium.org, Jun 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dcd7356c0da6f01946d563da54654a5bf773231

commit 3dcd7356c0da6f01946d563da54654a5bf773231
Author: Adithya Srinivasan <adithyas@chromium.org>
Date: Wed Jun 27 14:25:26 2018

Make speech layout tests use testharness.js

Makes the tests simpler in many cases and also removes the -expected
files.

Bug:  781655 
Change-Id: I15957ca318c56f4904bb68bc085880e70823d202
Reviewed-on: https://chromium-review.googlesource.com/1111910
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570760}
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/basics-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/basics.html
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/mock-speechrecognizer.js
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechgrammar-basics-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechgrammar-basics.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-basics-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-basics.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-detached-no-crash.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-errors-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-errors.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-re-restart-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-re-restart.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-restart-onend-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognition-restart-onend.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognitionerror-basics-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/speechrecognitionerror-basics.html
[delete] https://crrev.com/e609e9ceecedef07df9f95566bf7a07ffffc1e53/third_party/WebKit/LayoutTests/fast/speech/scripted/start-multiple-expected.txt
[modify] https://crrev.com/3dcd7356c0da6f01946d563da54654a5bf773231/third_party/WebKit/LayoutTests/fast/speech/scripted/start-multiple.html

Status: Fixed (was: Assigned)
Project Member

Comment 24 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5777081bc76c3754a1643344c0cd3a8e80be720

commit d5777081bc76c3754a1643344c0cd3a8e80be720
Author: Daniel Bratell <bratell@opera.com>
Date: Wed Oct 17 17:31:27 2018

Removed reference to deleted speech_recognition_client.h

In chasing isolate step errors in trybots, this is removing some
dangling references from a BUILD.gn file (though it seems to be
a never-ending sequence of problems so whatever started generating
the isolate step errors should probably be reverted).

Bug:  781655 
Change-Id: I09f530fa4a1e1cf3e1c0f15125eb8d9886f1038b
Reviewed-on: https://chromium-review.googlesource.com/c/1286818
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Adithya Srinivasan <adithyas@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600448}
[modify] https://crrev.com/d5777081bc76c3754a1643344c0cd3a8e80be720/third_party/blink/renderer/modules/speech/BUILD.gn

Sign in to add a comment