Issue 781645 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	lucmult@chromium.org
Closed:	Mar 2018
Cc:	tkent@chromium.org haraken@chromium.org dcheng@chromium.org yutak@chromium.org
Components:	Blink>Internals>WTF
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	3
Type:	Bug

Remove WTF::MakeUnique & WTF::WrapUnique in favor of std::make_unique.

Project Member Reported by slangley@chromium.org, Nov 5 2017

Issue description

We can use std::make_unique inside WebKit now so lets get rid of the WTF versions.

Comment 1 by slangley@chromium.org, Nov 5 2017

Cc: haraken@chromium.org dcheng@chromium.org

Related: https://bugs.chromium.org/p/chromium/issues/detail?id=755727

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48698bc5d6e4b774497624d93b91d8844aead2de

commit 48698bc5d6e4b774497624d93b91d8844aead2de
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Nov 09 04:01:32 2017

Replaced WTF:MakeUnique by std::make_unique 1 of 10.

This patch is the first of 10 patches replacing WTF::MakeUnique by
std::make_unique.

This changes files on platform/ and bindings/ directories.

Command used for editing:

$ ack-grep --type=cpp -l -w 'MakeUnique'  \
   ./third_party/WebKit/Source/platform/  \
   ./third_party/WebKit/Source/bindings/  \
   |xargs sed -i 's/WTF::MakeUnique/std::make_unique/'

Additionally fixed lint errors related to includes on files:
- CompositedlayerRasterInvalidator.cpp
- BlobBytesProviderTest.cpp
- FetchParameters.cpp

Bug:  755727 ,  781645 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3da4e19b40eabcab823eed0d475f9fcec68b8de7
Reviewed-on: https://chromium-review.googlesource.com/756536
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515089}
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/bindings/modules/v8/serialization/V8ScriptValueSerializerForModulesTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/animation/CompositorAnimationPlayer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/bindings/RuntimeCallStats.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobBytesProviderTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/compositing/CompositedLayerRasterInvalidator.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferSoftwareRenderingTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContext.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/heap/Visitor.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/BufferingDataPipeWriterTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/RawResource.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp
[modify] https://crrev.com/48698bc5d6e4b774497624d93b91d8844aead2de/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h

Comment 3 by lucmult@chromium.org, Nov 10 2017

Going through the noogler training I faced MakeUnique and WrapUnique on the following docs:
https://sites.google.com/a/chromium.org/dev/developers/coding-style/cpp-dos-and-donts
https://chromium-cpp.appspot.com/

That will need to be updated once our they're fully replaced.

While I'm here, I'm working on MakeUnique first via  crbug.com/755727 , I'll come back to this bug to work on WrapUnique once I'm finished with MakeUnique.

Comment 4 by lucmult@chromium.org, Nov 20 2017

Status: Started (was: Assigned)

WTF:MakeUnique has been removed (via  crbug.com/755727 ).

I'm working on MakeUnique now.

Some stats:

# Expected CLs Summary:
# CL #1 - bindings + controller + modules: 75 lines.
# CL #2 - core/audio + core/layout: 105 lines.
# CL #3 - platform/graphics: 98 lines.
# CL #4 - core/*remaining*: 51 lines.
# CL #5 - platform/*remaining*: 37 lines.

# Number of affected files:
$ ack-grep --type=cpp -l -w 'WTF::WrapUnique'  ./third_party/WebKit/Source/ | wc -l
366

# Number of lines affected:
$ ack-grep --type=cpp -w 'WTF::WrapUnique'  ./third_party/WebKit/Source/ |wc -l
629

I'm working on clang refactoring tool to change from WTF::WrapUnique() to std::make_unique<>() style, because this is a bit trickier to get right with sed cmd.

Comment 5 by lucmult@chromium.org, Nov 29 2017

I've abandoned the clang refactoring too approach because it was getting too complicated. Specially because not all calls can be converted to make_unique due to private constructor.

CL #1 out for review.
https://chromium-review.googlesource.com/c/chromium/src/+/795753

Comment 6 by slangley@chromium.org, Nov 29 2017

Take a look at the comments in https://bugs.chromium.org/p/chromium/issues/detail?id=671414

Perhaps we need to somehow move IsGarbageCollectedType to base:: so we can maintain the check in WrapUnique<>?

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dea3d7abb6ccc703942ae522dd2069d70dbd4b68

commit dea3d7abb6ccc703942ae522dd2069d70dbd4b68
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Thu Dec 21 01:33:49 2017

Convert WTF::WrapUnique to std::make_unique or base::WrapUnique

Change Source/DEPS and Scripts/audit-non-blink-usage.py to allow
the following |base|:
- base/memory/ptr_util.h"
- base::WrapUnique

CL #1 out of 5.

Convert for 3 directories:
- third_party/WebKit/Source/bindings/
- third_party/WebKit/Source/controller/
- third_party/WebKit/Source/modules/

Fix some lint errors.

Bug:  781645 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2ba14aad50f6b1f32ae907d4f238c37d9f3679cd
Reviewed-on: https://chromium-review.googlesource.com/795753
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525555}
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/DEPS
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/ActivityLoggerTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/ScriptStreamer.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/ScriptStreamerThread.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/SourceLocation.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/V8IdleTaskRunner.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/custom/V8HTMLPlugInElementCustom.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValue.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/controller/BlinkInitializer.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/EventModulesFactory.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/ModulesInitializer.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/accessibility/AXObjectCacheImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/accessibility/AXRelationCache.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThread.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/animationworklet/AnimationWorkletThreadTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/app_banner/AppBannerController.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/background_sync/SyncManager.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/cachestorage/CacheTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/canvas/canvas2d/CanvasRenderingContext2DTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/crypto/NormalizeAlgorithm.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/csspaint/CSSPaintDefinition.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySystemAccess.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/BodyStreamBufferTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/BytesConsumerForDataConsumerHandleTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/FetchDataLoader.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/FetchResponseData.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/fetch/ResponseTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/filesystem/DOMFileSystemSync.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/filesystem/LocalFileSystemClient.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBRequestQueueItem.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/IDBValueWrappingTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/MockWebIDBDatabase.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/WebIDBCallbacksImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/installation/InstallationServiceImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/media_controls/MediaControlsImplTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegate.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/media_controls/MediaControlsOrientationLockDelegateTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/mediacapturefromelement/HTMLCanvasElementCapture.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/mediastream/UserMediaClient.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/payments/CanMakePaymentEvent.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/payments/PaymentRequestEvent.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/peerconnection/RTCCertificate.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/peerconnection/RTCDataChannelTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/permissions/Permissions.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeProxy.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/serviceworkers/WebEmbeddedWorkerImplTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/speech/SpeechRecognitionClientProxy.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/storage/StorageNamespace.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/storage/StorageNamespaceController.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AsyncAudioDecoder.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioBasicProcessorHandlerTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioBufferSourceNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioContextTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioNodeInput.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioNodeOutput.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioWorkletThread.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/AudioWorkletThreadTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/BiquadFilterNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/BiquadProcessor.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/ConvolverNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/DelayNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/DelayProcessor.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/IIRFilterNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/IIRProcessor.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/MediaElementAudioSourceNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/OfflineAudioDestinationNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/PeriodicWave.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/RealtimeAnalyser.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/WaveShaperDSPKernel.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/WaveShaperNode.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webaudio/WaveShaperProcessor.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/DatabaseManager.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/DatabaseTask.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/DatabaseThread.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/DatabaseTracker.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/SQLError.h
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/SQLTransactionBackend.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webdatabase/sqlite/SQLiteStatement.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/webmidi/MIDIAccessor.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannelTest.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/websockets/WebPepperSocketImpl.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/dea3d7abb6ccc703942ae522dd2069d70dbd4b68/third_party/WebKit/Tools/Scripts/audit-non-blink-usage.py

Project Member

Comment 8 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30054a9187f2eafb16fdbaee21a94098afb10753

commit 30054a9187f2eafb16fdbaee21a94098afb10753
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Mar 07 22:41:47 2018

Replace WTF::WrapUnique with base::WrapUnique or std::make_unique

CL #4 out of 5.

Converted the following directories:
- third_party/WebKit/Source/platform/audio
- third_party/WebKit/Source/platform/exported
- third_party/WebKit/Source/platform/graphics

When the ctor is private replaced to base::WrapUnique, otherwise used
std::make_unique.

Removed include of wtf/PtrUtil.h.

Fixed missing includes pointed by git cl lint.

Bug:  781645 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia41caa048f5c9cfea1ed95b8052bf23fd5ff6c2b
Reviewed-on: https://chromium-review.googlesource.com/950486
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541618}
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/AudioBus.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/AudioChannel.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/AudioDestination.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/FFTFrame.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/HRTFDatabase.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/HRTFElevation.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/HRTFKernel.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/HRTFKernel.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/PushPullFIFOMultithreadTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/PushPullFIFOTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/Reverb.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/ReverbConvolver.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/ReverbConvolverStage.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/audio/StereoPanner.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebActiveGestureAnimation.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebCryptoAlgorithm.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebCryptoKey.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebCryptoKeyAlgorithm.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebFileSystemCallbacks.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebMediaStreamTrack.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebPrerender.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebScrollbarImpl.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebScrollbarThemeGeometryNative.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebServiceWorkerInstalledScriptsManager.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/exported/WebURLResponse.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/AcceleratedStaticBitmapImage.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/BitmapImage.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridgeTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/DecodingImageGenerator.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/DeferredImageDecoder.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/GraphicsContextState.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/GraphicsLayerTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/ImageDataBuffer.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/ImageDecodingStore.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/ImageFrameGenerator.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/ImageLayerChromiumTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImplTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/WebGraphicsContext3DProviderWrapper.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/compositing/PaintArtifactCompositor.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/gpu/Extensions3DUtil.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/gpu/SharedGpuContextTest.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/paint/PaintController.h
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/paint/PaintRecordBuilder.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/paint/PropertyTreeState.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/paint/RefCountedPropertyTreeState.cpp
[modify] https://crrev.com/30054a9187f2eafb16fdbaee21a94098afb10753/third_party/WebKit/Source/platform/graphics/test/MockImageDecoder.h

Project Member

Comment 9 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4010bf57df97972621d5771becd78398804d27ae

commit 4010bf57df97972621d5771becd78398804d27ae
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Mar 12 00:02:57 2018

Replace WTF::WrapUnique with base::WrapUnique or std::make_unique

CL #5 out of 5.

Converted remaining sub-directories of third_party/WebKit/Source/platform/.

When the ctor is private replaced to base::WrapUnique, otherwise used
std::make_unique.

Removed include of wtf/PtrUtil.h.

Fixed missing includes pointed by git cl lint.

Bug:  781645 
Change-Id: I8c6a85c0490b0e615e3d41e96821559aa6aa4e26
Reviewed-on: https://chromium-review.googlesource.com/952505
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542408}
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/ContentSettingCallbacks.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/DragImage.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/PODArena.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/PngFuzzer.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/WaitableEvent.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/WebThreadSupportingGC.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorFilterAnimationCurve.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorFloatAnimationCurve.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorKeyframeModel.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorScrollOffsetAnimationCurve.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/animation/CompositorTransformAnimationCurve.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/DOMWrapperWorld.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/Microtask.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/V0CustomElementBinding.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/V8PerContextData.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/V8PerIsolateData.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/bindings/V8PrivateProperty.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/blob/BlobData.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/FontCache.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/GlyphMetricsMap.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/SimpleFontData.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/SimpleFontData.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/shaping/RunSegmenter.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/skia/FontCacheSkia.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/fonts/win/FontCacheSkiaWin.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/geometry/FloatPolygonTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/CallbackStack.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/GCTaskRunner.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/Heap.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/HeapCompact.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/HeapCompact.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/HeapTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/PersistentNode.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/SparseHeapBitmap.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/heap/ThreadState.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoderTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageReader.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoderTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoderTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/instrumentation/tracing/TracedValue.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/instrumentation/tracing/web_process_memory_dump.cc
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/json/JSONValues.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/loader/fetch/ResourceResponse.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/mediastream/MediaStreamCenter.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/mediastream/MediaStreamWebAudioSource.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/testing/HistogramTester.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/text/LocaleICU.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/text/LocaleWin.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/text/TextBreakIteratorICU.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/text/hyphenation/HyphenationMinikin.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/transforms/TransformationMatrix.h
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/weborigin/KURL.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/weborigin/SecurityOrigin.cpp
[modify] https://crrev.com/4010bf57df97972621d5771becd78398804d27ae/third_party/WebKit/Source/platform/weborigin/SecurityPolicy.cpp

Project Member

Comment 10 by bugdroid1@chromium.org, Mar 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/560c8dc54649cccc06f6d60ab4c4456149ec23c0

commit 560c8dc54649cccc06f6d60ab4c4456149ec23c0
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Mon Mar 12 03:17:07 2018

Replace WTF::WrapUnique with base::WrapUnique or std::make_unique

CL #3 out of 5.

Convert the remaining directories of third_party/WebKit/Source/core/.
When the class ctor is private use base::WrapUnique(), otherwise use
std::make_unique().

Remove includes of wtf/PtrUtil.h, and add missing #includes detected
by the 'git cl lint' command.

Bug:  781645 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie8367d0c6913a8cfccb37b57335b5d9ae2c46f81
Reviewed-on: https://chromium-review.googlesource.com/950623
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542418}
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/SelectorFilter.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/SelectorQuery.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/invalidation/InvalidationSet.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/parser/CSSParserSelector.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/AXObjectCache.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/ContextFeaturesClientImpl.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/IncrementLoadEventDelayCount.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/events/EventTarget.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/dom/events/ScopedEventQueue.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/editing/Editor.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/PrerenderingTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/WebAssociatedURLLoaderImplTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/WebDOMActivityLogger.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/WebDocumentLoaderImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/fileapi/FileReaderLoader.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/fileapi/FileReaderLoader.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/DeferredLoadingTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/FullscreenController.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/LocalFrameView.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/PageScaleConstraintsSet.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/PausableScriptExecutor.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/Settings.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/WebFrameWidgetBase.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/WebFrameWidgetImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/input/EventHandler.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/inspector/DevToolsEmulator.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/inspector/InspectorOverlayAgent.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/loader/ThreadableLoaderTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/loader/resource/MockImageResourceObserver.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/page/ContextMenuController.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/page/PageOverlay.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/page/ValidationMessageOverlayDelegate.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/FilterPainter.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/FindPropertiesNeedingUpdate.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/HTMLCanvasPainterTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/LinkHighlightImpl.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/ObjectPaintProperties.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/PaintLayerStackingNode.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/SVGFilterPainter.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/paint/SVGPaintContext.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/CachedUAStyle.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/ComputedStyle.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/ContentData.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/CounterDirectives.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/PaintImages.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/StyleNonInheritedVariables.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/style/StylePath.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/svg/SVGPathByteStream.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/svg/graphics/SVGImageChromeClient.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/svg/graphics/SVGImageTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/testing/DummyPageHolder.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/DedicatedWorkerObjectProxy.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/DedicatedWorkerThread.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/ThreadedWorkletObjectProxy.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/WorkerBackingThread.h
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/xml/XPathParser.cpp
[modify] https://crrev.com/560c8dc54649cccc06f6d60ab4c4456149ec23c0/third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Mar 13 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/746621834ade23fdb2623caac91563375c0d90ed

commit 746621834ade23fdb2623caac91563375c0d90ed
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Tue Mar 13 02:12:59 2018

Replace WTF::WrapUnique with base::WrapUnique or std::make_unique

CL #2 out of 5.

Converted the following directories:
- third_party/WebKit/Source/core/animation
- third_party/WebKit/Source/core/html
- third_party/WebKit/Source/core/layout

When the ctor is private replaced to base::WrapUnique, otherwise used
std::make_unique.

Removed include of wtf/PtrUtil.h.

Fixed missing includes pointed by git cl lint.

Bug:  781645 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I5e5a35de44df03d801a3553b56761126374402e4
Reviewed-on: https://chromium-review.googlesource.com/933882
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542695}
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSBasicShapeInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSBorderImageLengthBoxInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSClipInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSColorInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSFilterListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSFontSizeInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSFontVariationSettingsInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSFontWeightInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSImageInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSImageListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSImageSliceInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSLengthInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSLengthListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSNumberInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSOffsetRotateInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSPaintInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSPathInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSRayInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSRotateInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSScaleInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSShadowListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSSizeListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSTextIndentInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSTransformInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSTranslateInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSVarCycleInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CSSVisibilityInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/CompositorAnimationsTest.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/InterpolableValue.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/LengthUnitsChecker.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/PrimitiveInterpolation.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/SVGTransformListInterpolationType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/TypedInterpolationValue.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/UnderlyingLengthChecker.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/css/CSSAnimationData.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/animation/css/CSSTransitionData.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/MediaElementFillingViewportTest.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/canvas/CanvasFontCache.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/forms/ExternalPopupMenu.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/forms/FormController.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/forms/InputType.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/media/HTMLMediaElement.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/media/HTMLMediaElementEventListenersTest.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/HTMLMetaCharsetParser.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/HTMLToken.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/HTMLTokenizer.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/PreloadRequest.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/TextResourceDecoder.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/XSSAuditor.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/html/parser/XSSAuditorDelegate.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/FloatingObjects.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/Grid.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutBox.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutBox.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutCounter.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutGrid.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/ScrollAnchor.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/TextAutosizer.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/line/RootInlineBox.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/ng/ng_block_node.cc
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/ng/ng_layout_result.cc
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/shapes/RasterShape.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/shapes/Shape.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/shapes/ShapeOutsideInfo.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceGradient.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/svg/LayoutSVGResourcePattern.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/svg/LayoutSVGTextPath.h
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/svg/SVGResources.cpp
[modify] https://crrev.com/746621834ade23fdb2623caac91563375c0d90ed/third_party/WebKit/Source/core/layout/svg/SVGResources.h

Project Member

Comment 12 by bugdroid1@chromium.org, Mar 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a

commit 348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Wed Mar 14 23:16:57 2018

Remove wtf/PtrUtil.h

WrapUnique was the last thing remaining on PtrUtil.h.

Remove last uses of WTF::WrapUnique converting to std::make_unique or
base::WrapUnique when the ctor is private.

Bug:  781645 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I8e04ccd6848bc425ef952a631c1c406ba1399c87
Reviewed-on: https://chromium-review.googlesource.com/961562
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Luciano Pacheco (SYD) <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543234}
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/animation/CSSInterpolationTypesMap.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/animation/CompositorAnimations.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/animation/DocumentTimeline.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/animation/SVGInterpolationTypesMap.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/css/resolver/StyleResolverStats.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/dom/ContextFeatures.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/events/EventFactory.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/events/KeyboardEvent.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/LocalFrameClientImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/SharedWorkerRepositoryClientImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebFrameSerializer.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebNode.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebPagePopupImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebSharedWorkerImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/exported/WebViewTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/frame/FrameTestHelpers.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/frame/PerformanceMonitorTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/frame/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/frame/WebLocalFrameImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/HTMLAreaElement.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/canvas/HTMLCanvasElement.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/forms/ColorChooserUIController.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/forms/TextControlElementTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/parser/AtomicHTMLToken.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/html/parser/HTMLParserScheduler.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/input/ScrollManager.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/input/TouchEventManager.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/inspector/InspectorDOMSnapshotAgent.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/inspector/InspectorStyleSheet.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/LayoutTable.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/LayoutTableCell.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/line/InlineFlowBox.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/EmptyClients.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/ProgressTracker.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/ScheduledNavigation.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/resource/CSSStyleSheetResourceTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/loader/resource/ImageResourceTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/messaging/MessagePort.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/page/ChromeClientImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/page/scrolling/ScrollStateTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/paint/LinkHighlightImplTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/paint/ng/ng_paint_fragment.cc
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/scheduler/ActiveConnectionThrottlingTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/style/ClipPathOperation.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/style/CounterDirectives.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/GlobalScopeCreationParams.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/SharedWorkerThread.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/ThreadedObjectProxyBase.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/WorkerScriptLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/core/workers/WorkletThreadHolder.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/modules/csspaint/PaintRenderingContext2D.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/modules/exported/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/modules/indexeddb/IDBKey.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/modules/indexeddb/WebIDBDatabaseCallbacksImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/modules/webaudio/AudioParamTimeline.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/SharedBufferTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/TimerPerfTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/TimerTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/animation/CompositorAnimation.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/audio/DynamicsCompressor.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/audio/DynamicsCompressorKernel.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/audio/HRTFDatabaseLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/audio/PushPullFIFO.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/blob/BlobDataTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/exported/WebDataConsumerHandle.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/exported/WebMediaStream.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/feature_policy/FeaturePolicy.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzFace.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/fonts/shaping/HarfBuzzShaper.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/CompositorMutatorClient.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/CompositorMutatorImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/DrawLooperBuilder.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/StrokeData.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/filters/FEConvolveMatrix.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/filters/FEMerge.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/gpu/DrawingBufferTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/heap/SparseHeapBitmap.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/image-decoders/png/PNGImageReader.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/fetch/BufferingDataPipeWriterTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcherTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/fetch/ResourceRequest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/fetch/ResourceTimingInfo.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/loader/testing/MockFetchContext.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/mac/ScrollAnimatorMac.mm
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/scroll/ProgrammaticScrollAnimator.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/scroll/ScrollAnimator.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/scroll/ScrollbarTestSuite.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/text/LocaleMac.mm
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/threading/BackgroundTaskRunnerTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/Assertions.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/BUILD.gn
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/DequeTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/Functional.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/HashMapTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/HashSetTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/HashTable.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/ListHashSetTest.cpp
[delete] https://crrev.com/2b1f5f9e57a47ae4632ff88ed11038b366d551dd/third_party/WebKit/Source/platform/wtf/PtrUtil.h
[delete] https://crrev.com/2b1f5f9e57a47ae4632ff88ed11038b366d551dd/third_party/WebKit/Source/platform/wtf/PtrUtilTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/README.md
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/TerminatedArray.h
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/VectorTest.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/TextCodecICU.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/TextCodecLatin1.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/TextCodecReplacement.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/TextCodecUTF8.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/TextCodecUserDefined.cpp
[modify] https://crrev.com/348dac8f400b4e3dfe90242f7ab9e233fdbf1f6a/third_party/WebKit/Source/platform/wtf/text/icu/CollatorICU.cpp

Comment 13 by lucmult@chromium.org, Mar 14 2018

Status: Fixed (was: Started)

wtf/PtrUtil.h removed.

Comment 14 by slangley@chromium.org, Mar 14 2018

\o/

Comment 15 by tkent@chromium.org, Mar 26 2018

Cc: tkent@chromium.org

 Issue 671414  has been merged into this issue.

►

Issue 781645 link

Issue metadata

Remove WTF::MakeUnique & WTF::WrapUnique in favor of std::make_unique.

Issue description

Comment 1 by slangley@chromium.org, Nov 5 2017

Comment 1 Deleted

Comment 2 by bugdroid1@chromium.org, Nov 9 2017

Comment 2 Deleted

Comment 3 by lucmult@chromium.org, Nov 10 2017

Comment 3 Deleted

Comment 4 by lucmult@chromium.org, Nov 20 2017

Comment 4 Deleted

Comment 5 by lucmult@chromium.org, Nov 29 2017

Comment 5 Deleted

Comment 6 by slangley@chromium.org, Nov 29 2017

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Dec 21 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Mar 7 2018

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Mar 12 2018

Comment 9 Deleted

Comment 10 by bugdroid1@chromium.org, Mar 12 2018

Comment 10 Deleted

Comment 11 by bugdroid1@chromium.org, Mar 13 2018

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Mar 14 2018

Comment 12 Deleted

Comment 13 by lucmult@chromium.org, Mar 14 2018

Comment 13 Deleted

Comment 14 by slangley@chromium.org, Mar 14 2018

Comment 14 Deleted

Comment 15 by tkent@chromium.org, Mar 26 2018

Comment 15 Deleted

Sign in to add a comment