New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781644 link

Starred by 2 users
Status: Fixed
Owner:
tommycli@chromium.org
Closed: Dec 2017
Cc:
█ ericde@chromium.org
█ raymes@chromium.org
█ groby@chromium.org
█ krishna...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug

Blocked on:
issue 706532


Sign in to add a comment

Remove SEI threshold for HTML5 by Default

Project Member Reported by lafo...@chromium.org, Nov 5 2017 
Now that the minimum SEI score has been bumped to 101 all sites will get prompted to enable Flash Player, regardless of usage.

We can safely remove that logic, ensuring that all sites continue to get prompted.

Comment 1 by raymes@chromium.org, Nov 5 2017 

Hooray!

Comment 2 by tommycli@chromium.org, Dec 11 2017 

Hey --

Is this a done deal? As in we can remove all HBD / SEI references in the codebase now?

Tommy

Comment 3 by ericde@google.com, Dec 11 2017 

yup - SEI threshold is already 101 (as been since 28 SEP). and welcome back.

Comment 4 by tommycli@chromium.org, Dec 11 2017 

ericde: Can you confirm that we no longer need these histograms also?

  Plugin.Flash.Engagement.ContentSettingAllowed
  Plugin.Flash.Engagement.ContentSettingBlocked
  Plugin.Flash.Engagement.NoSetting

Thanks,

Tommy

Comment 5 by ericde@google.com, Dec 12 2017 

those are just related to SEI thresholds, right? if so, then yes, I think those histograms can be removed as well.

Comment 6 by tommycli@chromium.org, Dec 12 2017 

Great. My thoughts as well.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/897ed131dcda20b80fdebf34bb69cfb4527cb05e

commit 897ed131dcda20b80fdebf34bb69cfb4527cb05e
Author: Tommy C. Li <tommycli@chromium.org>
Date: Wed Dec 13 18:06:04 2017

[HBD] Remove Site Engagement Threshold for HTML5 by Default

Bug:  781644 
Change-Id: I450b4b3472fa024b753a512058ddf0668b280307
Reviewed-on: https://chromium-review.googlesource.com/821051
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523815}
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/chrome_plugin_service_filter.cc
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/chrome_plugin_service_filter.h
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/flash_permission_browsertest.cc
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/plugins_field_trial.cc
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/chrome/browser/plugins/plugins_field_trial.h
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/testing/variations/fieldtrial_testing_config.json
[modify] https://crrev.com/897ed131dcda20b80fdebf34bb69cfb4527cb05e/tools/metrics/histograms/histograms.xml

Comment 8 by tommycli@chromium.org, Dec 13 2017

Status: Fixed (was: Assigned)

Comment 9 by hsiangc@chromium.org, Jan 3 2018

Cc: krishna...@chromium.org
►

Sign in to add a comment