New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781641 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojofy and onion soup text_input_client_messages.h

Project Member Reported by slangley@chromium.org, Nov 5 2017

Issue description

Convert all IPC's to Mojo.

Move the code into the right spot in //blink
 
Labels: -Type-Bug Type-Task
Summary: Mojofy and onion soup content/common/text_input_client_messages.h (was: Mojofy and onion soup text_input_client_messages.h)

Comment 2 by sashab@chromium.org, Nov 21 2017

Cc: sashab@chromium.org
Labels: -Type-Task Type-Bug
Owner: joelhockey@chromium.org
Summary: Mojofy and onion soup text_input_client_messages.h (was: Mojofy and onion soup content/common/text_input_client_messages.h)
This is a mac-specific IPC, so assigning to joel who has a mac machine to build on :) Happy to do code reviews for this.

Some trybots running to see test coverage:
https://chromium-review.googlesource.com/c/chromium/src/+/780704
https://chromium-review.googlesource.com/c/chromium/src/+/780126
It turns out that the mac part of this is not the trickiest bit.

These messages are sent between RenderWidgetHost and RenderWidget.
https://cs.chromium.org/chromium/src/content/browser/renderer_host/text_input_client_mac.mm?l=69&rcl=a7588a30d59fea194ad7a1afa5695405dcc41e80

Currently there is no InterfaceProvider / InterfaceRegistry for RenderWidget(Host).
There looks to be some start on doing this.
https://cs.chromium.org/chromium/src/content/common/widget.mojom

For now, I'm going to leave this and focus on some other conversions.

Comment 4 by sashab@chromium.org, Nov 30 2017

Blockedon: 722928
It looks like that file was added as part of this bug - crbug.com/722928

Marking it as blocking.

Comment 5 by sashab@chromium.org, Nov 30 2017

Blockedon: -722928
Cc: slangley@chromium.org nasko@chromium.org
After speaking with dtapuska@ (owner of crbug.com/722928), he's not going to add an InterfaceProvider/InterfaceRegistry for RenderWidgetHost. There is already one for RenderWidget which is all that's needed for that bug.

He says these look like editing apis that should be on the frame input handler, and we should speak to the OOPIF team about a design.

+nasko who I chatted to briefly about this as well
Cc: joelhockey@chromium.org
Owner: ----
Status: Available (was: Assigned)
Cc: -sashab@chromium.org

Sign in to add a comment