New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781629 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

chromite afdo_unittest failing on numerous builders

Project Member Reported by akes...@chromium.org, Nov 5 2017

Issue description

https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromiumos.tryserver%2Fno_vmtest_pre_cq%2F165665%2F%2B%2Frecipes%2Fsteps%2FUnitTest%2F0%2Fstdout

chromite-0.0.2-r3490: ======================================================================
chromite-0.0.2-r3490: FAIL: [chromite.cbuildbot.afdo_unittest] AfdoTest.testProfileAge
chromite-0.0.2-r3490: ----------------------------------------------------------------------
chromite-0.0.2-r3490: Traceback (most recent call last):
chromite-0.0.2-r3490:   File "/mnt/host/source/chromite/lib/timeout_util.py", line 191, in TimeoutWrapper
chromite-0.0.2-r3490:     return func(*args, **kwargs)
chromite-0.0.2-r3490:   File "/mnt/host/source/chromite/cbuildbot/afdo_unittest.py", line 81, in testProfileAge
chromite-0.0.2-r3490:     afdo.ProfileAge([0, 0, 0, int(time.time() - 86400)])
chromite-0.0.2-r3490: AssertionError: 1 != 0
chromite-0.0.2-r3490: 
chromite-0.0.2-r3490: ----------------------------------------------------------------------
chromite-0.0.2-r3490: Ran 5 tests in 0.032s
chromite-0.0.2-r3490: 
chromite-0.0.2-r3490: FAILED (failures=1)
chromite-0.0.2-r3490: 
chromite-0.0.2-r3490: 12:02:45: ERROR: The following 1 tests failed:
chromite-0.0.2-r3490:   cbuildbot/afdo_unittest
chromite-0.0.2-r3490:  * ERROR: chromeos-base/chromite-0.0.2-r3490::chromiumos failed (test phase):
chromite-0.0.2-r3490:  *   (no error message)
chromite-0.0.2-r3490:  * 
chromite-0.0.2-r3490:  * Call stack:
chromite-0.0.2-r3490:  *     ebuild.sh, line  93:  Called src_test
chromite-0.0.2-r3490:  *   environment, line 5888:  Called die
chromite-0.0.2-r3490:  * The specific snippet of code:
chromite-0.0.2-r3490:  *       cd "${CHROMITE_DIR}/cbuildbot" && sudo -u "${PORTAGE_USERNAME}" PATH="${CROS_WORKON_SRCROOT}/../depot_tools:${PATH}" ./run_tests || die
chromite-0.0.2-r3490:  * 
chromite-0.0.2-r3490:  * If you need support, post the output of `emerge --info '=chromeos-base/chromite-0.0.2-r3490::chromiumos'`,
chromite-0.0.2-r3490:  * the complete build log and the output of `emerge -pqv '=chromeos-base/chromite-0.0.2-r3490::chromiumos'`.
chromite-0.0.2-r3490:  * The complete build log is located at '/build/nyan_blaze/tmp/portage/logs/chromeos-base:chromite-0.0.2-r3490:20171105-200142.log'.
chromite-0.0.2-r3490:  * For convenience, a symlink to the build log is located at '/build/nyan_blaze/tmp/portage/chromeos-base/chromite-0.0.2-r3490/temp/build.log'.
chromite-0.0.2-r3490:  * The ebuild environment file is located at '/build/nyan_blaze/tmp/portage/chromeos-base/chromite-0.0.2-r3490/temp/environment'.
chromite-0.0.2-r3490:  * Working directory: '/mnt/host/source/chromite/cbuildbot'
chromite-0.0.2-r3490:  * S: '/mnt/host/source/src/platform/../../chromite'
chromite-0.0.2-r3490: >>> Failed to emerge chromeos-base/chromite-0.0.2-r3490 for /build/nyan_blaze/, Log file:
chromite-0.0.2-r3490: >>>  '/build/nyan_blaze/tmp/portage/logs/chromeos-base:chromite-0.0.2-r3490:20171105-200142.log'
chromite-0.0.2-r3490: 
chromite-0.0.2-r3490:  * Messages for package chromeos-base/chromite-0.0.2-r3490 merged to /build/nyan_blaze/:
chromite-0.0.2-r3490: 
chromite-0.0.2-r3490:  * ERROR: chromeos-base/chromite-0.0.2-r3490::chromiumos failed (test phase):
chromite-0.0.2-r3490:  *   (no error message)
chromite-0.0.2-r3490:  * 
chromite-0.0.2-r3490:  * Call stack:
chromite-0.0.2-r3490:  *     ebuild.sh, line  93:  Called src_test
chromite-0.0.2-r3490:  *   environment, line 5888:  Called die
chromite-0.0.2-r3490:  * The specific snippet of code:
chromite-0.0.2-r3490:  *       cd "${CHROMITE_DIR}/cbuildbot" && sudo -u "${PORTAGE_USERNAME}" PATH="${CROS_WORKON_SRCROOT}/../depot_tools:${PATH}" ./run_tests || die
chromite-0.0.2-r3490:  * 
chromite-0.0.2-r3490:  * If you need support, post the output of `emerge --info '=chromeos-base/chromite-0.0.2-r3490::chromiumos'`,
chromite-0.0.2-r3490:  * the complete build log and the output of `emerge -pqv '=chromeos-base/chromite-0.0.2-r3490::chromiumos'`.
chromite-0.0.2-r3490:  * The complete build log is located at '/build/nyan_blaze/tmp/portage/logs/chromeos-base:chromite-0.0.2-r3490:20171105-200142.log'.
chromite-0.0.2-r3490:  * For convenience, a symlink to the build log is located at '/build/nyan_blaze/tmp/portage/chromeos-base/chromite-0.0.2-r3490/temp/build.log'.
chromite-0.0.2-r3490:  * The ebuild environment file is located at '/build/nyan_blaze/tmp/portage/chromeos-base/chromite-0.0.2-r3490/temp/environment'.
chromite-0.0.2-r3490:  * Working directory: '/mnt/host/source/chromite/cbuildbot'
chromite-0.0.2-r3490:  * S: '/mnt/host/source/src/platform/../../chromite'
 
Owner: laszio@chromium.org
I'm marking this test as expectedFailure.
(the failure above reproduces locally and seems unrelated to any recent chromite change, looks liek it is due to some external artifact being stale)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0f6dfa13ec32379b9a13c5992c1b0dabe59c3d2a

commit 0f6dfa13ec32379b9a13c5992c1b0dabe59c3d2a
Author: Aviv Keshet <akeshet@chromium.org>
Date: Sun Nov 05 20:53:03 2017

afdo_unittest: mark an expected failure

BUG= chromium:781629 
TEST=afdo_unittest

Change-Id: I4bb1e376fccb8d651dc819062eaa797ad05ca2c9
Reviewed-on: https://chromium-review.googlesource.com/754622
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/0f6dfa13ec32379b9a13c5992c1b0dabe59c3d2a/cbuildbot/afdo_unittest.py

Cc: icoolidge@chromium.org
Labels: -Pri-0 Pri-2
No longer P0, laszio fix at your leisure.
Cc: akes...@chromium.org
 Issue 781982  has been merged into this issue.
CL needs to be merged to 63, possibly other branches.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 6 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ecc267364b15f9ebfe051c0ae241f0823bfc4851

commit ecc267364b15f9ebfe051c0ae241f0823bfc4851
Author: Aviv Keshet <akeshet@chromium.org>
Date: Mon Nov 06 22:43:23 2017

afdo_unittest: mark an expected failure

BUG= chromium:781629 
TEST=afdo_unittest

Change-Id: I4bb1e376fccb8d651dc819062eaa797ad05ca2c9
Previous-Reviewed-on: https://chromium-review.googlesource.com/754622
(cherry picked from commit b5fa7a0de10e14ae63fa1ee93edd04445c7a0d4d)
Reviewed-on: https://chromium-review.googlesource.com/755940
Commit-Queue: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Grace Kihumba <gkihumba@chromium.org>

[modify] https://crrev.com/ecc267364b15f9ebfe051c0ae241f0823bfc4851/cbuildbot/afdo_unittest.py

Python's timedelta takes daylight saving into account and there were 25 hours yesterday. The unittest tests if now is a day ahead of now - 86400s so it failed yesterday.

Because this only happens once per year, and it is also disabled in R63, so I'm not going to cherry-pick the fix to R63.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/ef632e4a473bfe196707200bc315293b59a121f7

commit ef632e4a473bfe196707200bc315293b59a121f7
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue Nov 07 14:00:17 2017

autofdo: use utc to calculate timedelta

A day can be longer than 86400 seconds for a local time.

TEST=afdo_unittest
BUG= chromium:781629 

Change-Id: I480190377f3ee748df324494facf84379a1a07a5
Reviewed-on: https://chromium-review.googlesource.com/756201
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/ef632e4a473bfe196707200bc315293b59a121f7/cbuildbot/afdo.py
[modify] https://crrev.com/ef632e4a473bfe196707200bc315293b59a121f7/cbuildbot/afdo_unittest.py

Status: Fixed (was: Untriaged)

Sign in to add a comment