New issue
Advanced search Search tips

Issue 781570 link

Starred by 7 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Mac client certificate selector is frozen (regression in recent change)

Project Member Reported by davidben@chromium.org, Nov 5 2017

Issue description

Chrome Version: r513797
OS: macOS 10.12.6 (also repros on 10.13)

What steps will reproduce the problem?
(1) Spin up a test server that requests a client certificate. This should do the trick:
    cd third_party/boringssl/src/ssl/test/runner
    openssl s_server -cert cert.pem -key key.pem -www -accept 4433 -Verify 1
(2) Go to https://localhost:4433 in Chrome.
(3) If no client certificate dialog comes up, here is a really silly way to add one to Keychain. (But I think if you're on a corp Mac, you'll have the dialog come up without doing this?)
    a) Go to https://davidben.scripts.mit.edu/keygen_webcrypto/
    b) Hit the first "Get certificate" button.
    c) Hit the "Download certificate" link.
    d) Save and open the downloaded p12 file. Type 123 in the password prompt.
    Follow those steps and repeat step (2).

What is the expected result?
The client certificate prompt is responsive.

What happens instead?
The UI is frozen.

I did a bisect and it gave:
You are probably looking for a change made after 513788 (known good), but no later than 513797 (first known bad).
CHANGELOG URL:
https://chromium.googlesource.com/chromium/src/+log/51af90bc8f9ed49daa83872bb04a74cc89c8b842..bf6c42efe66fa71309a794abcb34a50e9713df74

This CL looks like the only change that plausibly changed Mac UI? Tentatively assigning to sdy@
https://chromium.googlesource.com/chromium/src/+/8f1989aa6b1becf26cafbcd3dc972a43009d3883

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 

Comment 1 Deleted

Labels: ReleaseBlock-Beta
(Marking RBB so this doesn't get lost. Client certs are, sadly, widely used in enterprise.)
Cc: tapted@chromium.org meh...@chromium.org
 Issue 781802  has been merged into this issue.

Comment 4 by sdy@chromium.org, Nov 8 2017

Status: Started (was: Assigned)
CL: https://chromium-review.googlesource.com/c/chromium/src/+/758926
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abc40c5dc6f6bf7888e03f43e1794231502ab26a

commit abc40c5dc6f6bf7888e03f43e1794231502ab26a
Author: Sidney San Martín <sdy@chromium.org>
Date: Thu Nov 09 16:55:54 2017

Work around a macOS bug that prevents interaction with the client certificate selector.

Bug:  781570 
Change-Id: Icaed643a358f2414dcf3fdf84bee6b6453a744ef
Reviewed-on: https://chromium-review.googlesource.com/758926
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515187}
[modify] https://crrev.com/abc40c5dc6f6bf7888e03f43e1794231502ab26a/chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_info.mm

Comment 6 by sdy@chromium.org, Nov 9 2017

Status: Fixed (was: Started)
Should be fixed by the above cl!
 Issue 801727  has been merged into this issue.

Sign in to add a comment