Issue metadata
Sign in to add a comment
|
Mojo bot browser tests failing on download tests |
||||||||||||||||||||||||
Issue descriptionAs of https://build.chromium.org/p/chromium.fyi/builders/Mojo%20Linux/builds/6874 the following tests are failing on the Mojo FYI bot: DownloadTest.DontCloseNewTab3 DownloadTest.CloseNewTab1 DownloadTest.CloseNewTab2 DownloadTest.CloseNewTab3 I believe the CL that triggered this was https://chromium-review.googlesource.com/744644 "Converts more chrome download browsertest to use embedded test server." xingliu@: Would you be willing to take a look and decide if it makes sense to try and fix this now, or if we should leave these tests suppressed? (I'll commit a suppression against this bug in a bit.) Output from first test; looks like the download didn't complete: [ RUN ] DownloadTest.DontCloseNewTab3 Xlib: extension "RANDR" missing on display ":99". [28845:28882:1103/173356.464956:ERROR:bus.cc(395)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix") [28845:28845:1103/173356.467355:WARNING:password_store_factory.cc(241)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [28845:28873:1103/173356.486107:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin [28845:28873:1103/173356.499347:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin [28887:28887:1103/173356.546238:ERROR:gpu_info.cc(103)] No active GPU found, returning primary GPU. [28890:28929:1103/173356.601946:WARNING:simple_synchronous_entry.cc(1179)] Could not open platform files for entry. [28845:28932:1103/173356.633844:WARNING:embedded_test_server.cc(228)] Request not handled. Returning 404: /favicon.ico [28845:28873:1103/173356.689615:WARNING:child_process_launcher_helper_posix.cc(118)] Ignoring invalid file v8_context_snapshot.bin BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000050038b7 base::debug::StackTrace::StackTrace() #1 0x000005616481 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f49c6e64cb0 <unknown> #3 0x7f49c6f1ec5d __poll #4 0x7f49cc3ecfe4 <unknown> #5 0x7f49cc3ed0ec g_main_context_iteration #6 0x00000502d9c3 base::MessagePumpGlib::Run() #7 0x000005028fee base::MessageLoop::Run() #8 0x000005058e04 base::RunLoop::Run() #9 0x000005652dec content::RunMessageLoop() #10 0x000005622bb5 content::DownloadTestObserver::WaitForFinished() #11 0x00000226ecd9 DownloadTest::DownloadAndWaitWithDisposition() #12 0x0000022702fb DownloadTest_DontCloseNewTab3_Test::RunTestOnMainThread() #13 0x0000056161ef content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #14 0x00000513682b ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #15 0x0000051354ea ChromeBrowserMainParts::PreMainMessageLoopRun() #16 0x000003aa9edd content::BrowserMainLoop::PreMainMessageLoopRun() #17 0x000003ef2e7f content::StartupTaskRunner::RunAllTasksNow() #18 0x000003aa813e content::BrowserMainLoop::CreateStartupTasks() #19 0x000003aad923 content::BrowserMainRunnerImpl::Initialize() #20 0x000003aa59c4 content::BrowserMain() #21 0x000004fe43bf content::RunNamedProcessTypeMain() #22 0x000004fe4e3c content::ContentMainRunnerImpl::Run() #23 0x000006dec903 service_manager::Main() #24 0x000004fe3782 content::ContentMain() #25 0x000005615e4a content::BrowserTestBase::SetUp() #26 0x0000050d50f5 InProcessBrowserTest::SetUp() #27 0x0000031c6e2e testing::Test::Run() #28 0x0000031c7960 testing::TestInfo::Run() #29 0x0000031c7e47 testing::TestCase::Run() #30 0x0000031ce327 testing::internal::UnitTestImpl::RunAllTests() #31 0x0000031cdfb3 testing::UnitTest::Run() #32 0x0000050ea938 base::TestSuite::Run() #33 0x000004ff6ffa ChromeTestSuiteRunner::RunTestSuite() #34 0x00000564d21a content::LaunchTests() #35 0x000004ff73be LaunchChromeTests() #36 0x000004ff6f59 main #37 0x7f49c6e4ff45 __libc_start_main #38 0x0000020b8029 <unknown>
,
Nov 7 2017
Apologies, applied the wrong component in bulk.
,
Nov 8 2017
Thanks for disabling them, will double check if anything is wrong in those test cases.
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/098549fcb1bf89794e862d5bb7c071efabacc771 commit 098549fcb1bf89794e862d5bb7c071efabacc771 Author: Xing Liu <xingliu@chromium.org> Date: Sat Nov 11 03:55:27 2017 Fix an issue in download with network service. Download code uses frame_tree_node_id to find WebContents when browser side navigation is enabled. The WebContents is used in UI layer code to close the tab when the request is a download. Bug: 715630 , 781565 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ib9490a64692027e3b16c70b77b54aceebcfcb9b7 Reviewed-on: https://chromium-review.googlesource.com/761269 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#515816} [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/content/browser/download/download_manager_impl.h [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/content/browser/download/resource_downloader.cc [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/content/browser/download/resource_downloader.h [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/098549fcb1bf89794e862d5bb7c071efabacc771/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Nov 11 2017
FYI the latest cl broke new tests: fast/dom/HTMLAnchorElement/anchor-download.html fast/dom/HTMLAnchorElement/anchor-nodownload-set.html DownloadTest.CloseNewTab4
,
Nov 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cde41d11f134b91918bfc75d93369e0575f4f333 commit cde41d11f134b91918bfc75d93369e0575f4f333 Author: John Abd-El-Malek <jam@chromium.org> Date: Sat Nov 11 17:38:35 2017 Update network service test filter TBR=yzshen@chromium.org NOTRY=true Bug: 781565 , 752370 Change-Id: Ic14467588e28081173625323dea6dd5dd99a4f0e Reviewed-on: https://chromium-review.googlesource.com/764811 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515846} [modify] https://crrev.com/cde41d11f134b91918bfc75d93369e0575f4f333/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter [modify] https://crrev.com/cde41d11f134b91918bfc75d93369e0575f4f333/third_party/WebKit/LayoutTests/FlagExpectations/enable-features=NetworkService
,
Nov 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f598d6acae1f05a650ed8325a0ab4e19d56482da commit f598d6acae1f05a650ed8325a0ab4e19d56482da Author: John Abd-El-Malek <jam@chromium.org> Date: Mon Nov 13 02:57:11 2017 Revert "Fix an issue in download with network service." This reverts commit 098549fcb1bf89794e862d5bb7c071efabacc771. Reason for revert: Causing a bunch of test failures, see original commit's replies for list Original change's description: > Fix an issue in download with network service. > > Download code uses frame_tree_node_id to find WebContents when browser > side navigation is enabled. The WebContents is used in UI layer code > to close the tab when the request is a download. > > > Bug: 715630 , 781565 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation > Change-Id: Ib9490a64692027e3b16c70b77b54aceebcfcb9b7 > Reviewed-on: https://chromium-review.googlesource.com/761269 > Commit-Queue: Xing Liu <xingliu@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Min Qin <qinmin@chromium.org> > Reviewed-by: David Trainor <dtrainor@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515816} TBR=jam@chromium.org,dtrainor@chromium.org,qinmin@chromium.org,xingliu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 715630 , 781565 Change-Id: I5c969d11f411c5742dec2762017609db351d7a28 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Reviewed-on: https://chromium-review.googlesource.com/765388 Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#515879} [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/content/browser/download/download_manager_impl.h [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/content/browser/download/resource_downloader.cc [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/content/browser/download/resource_downloader.h [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/f598d6acae1f05a650ed8325a0ab4e19d56482da/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Nov 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a8e089607563e923056b2c5d839e3c45c9dc62 commit 18a8e089607563e923056b2c5d839e3c45c9dc62 Author: Xing Liu <xingliu@chromium.org> Date: Wed Nov 15 06:16:13 2017 [Reland] Fix an issue in download with network service. This CL relands https://chromium-review.googlesource.com/c/chromium/src/+/761269, which is reverted in https://chromium-review.googlesource.com/c/chromium/src/+/765388. Also SBNavigationObserverBrowserTest.DownloadViaHTML5FileApiWithoutUserGesture and SBNavigationObserverBrowserTest.DownloadViaHTML5FileApiWithUserGesture is broken because of the reverted patch. See https://chromium-review.googlesource.com/c/chromium/src/+/765229. The code path from RenderFrameMessageFilter::DownloadUrl still needs the render_frame_id to find the WebContents. In this case, the download is not intercepted from navigation but from renderer, mostly triggered from javascript. Bug: 715630 , 781565 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: I414c87f54d3f03a3060a38a9de402e02197ca445 Reviewed-on: https://chromium-review.googlesource.com/767852 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by: Min Qin <qinmin@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#516595} [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/content/browser/download/download_manager_impl.cc [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/content/browser/download/download_manager_impl.h [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/content/browser/download/resource_downloader.cc [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/content/browser/download/resource_downloader.h [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/content/browser/frame_host/navigation_request.cc [modify] https://crrev.com/18a8e089607563e923056b2c5d839e3c45c9dc62/testing/buildbot/filters/mojo.fyi.network_browser_tests.filter
,
Mar 3 2018
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 5 2017