New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781561 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Task



Sign in to add a comment

Delete experimental flags to ignore accidental power button presses

Project Member Reported by derat@chromium.org, Nov 4 2017

Issue description

I added some experimental code and flags to ignore spurious power button events. We went with a different approach, so I should delete the code now.
 

Comment 1 by derat@chromium.org, Nov 4 2017

Status: Started (was: Assigned)
Sent https://crrev.com/c/754184 for review.

Comment 2 by derat@chromium.org, Nov 6 2017

Status: Verified (was: Started)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5137e3aa92595669c787165b834e5ef4d7a63a3

commit e5137e3aa92595669c787165b834e5ef4d7a63a3
Author: Daniel Erat <derat@chromium.org>
Date: Mon Nov 06 23:15:14 2017

chromeos: Delete experimental spurious-power-button flags.

Remove never-used flags that were added to attempt to ignore
accidental power button presses:

--spurious-power-button-window
--spurious-power-button-accel-count
--spurious-power-button-screen-accel
--spurious-power-button-keyboard-accel
--spurious-power-button-lid-angle-change

Bug:  781561 ,  736936 
Change-Id: I389d6d2cc8d530bf1bef09d780fd52c1d6bd011c
Reviewed-on: https://chromium-review.googlesource.com/754184
Commit-Queue: Dan Erat <derat@chromium.org>
Reviewed-by: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514280}
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/public/cpp/ash_switches.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/public/cpp/ash_switches.h
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/power_button_test_base.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/tablet_power_button_controller.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/tablet_power_button_controller.h
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/tablet_power_button_controller_test_api.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/tablet_power_button_controller_test_api.h
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/ash/system/power/tablet_power_button_controller_unittest.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/chrome/browser/about_flags.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/e5137e3aa92595669c787165b834e5ef4d7a63a3/chrome/browser/flag_descriptions.h

Sign in to add a comment