cros-config-tools unit tests didn't catch breakage at ToT |
|
Issue description
cros-config-tools are broken at ToT right now with:
$ FEATURES=test sudo -E emerge --nodeps chromeos-config-tools
...
1104/120430:ERROR:cros_config.cc(103)] The path /audio/main does not exist.
./../../../../../../mnt/host/source/src/platform2/chromeos-config/libcros_config/cros_config_unittest.cc:152: Failure
Expected: "front"
o be equal to: val
Which is: "1mic"
[ FAILED ] CrosConfigTest.CheckSubmodel (2 ms)
This shouldn't be possible. Looking at a random board UnitTests phase, everything seems fine: https://logs.chromium.org/v/?s=chromeos%2Fbb%2Fchromeos%2Freef-uni-paladin%2F914%2F%2B%2Frecipes%2Fsteps%2FUnitTest%2F0%2Fstdout
,
Nov 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3250ff0f784cb52159d313ef40b893daa291a7e2 commit 3250ff0f784cb52159d313ef40b893daa291a7e2 Author: Jason D. Clinton <jclinton@chromium.org> Date: Sun Nov 05 00:42:05 2017 chromeos-config: Fix broken unit test at ToT Somehow this got through CQ. BUG=chromium:781551 TEST=FEATURES=test sudo -E emerge --nodeps chromeos-config-tools Change-Id: I86a2071f9ab8907be0117265c19c4b9e28750484 Reviewed-on: https://chromium-review.googlesource.com/754115 Commit-Ready: Jason Clinton <jclinton@chromium.org> Tested-by: Jason Clinton <jclinton@chromium.org> Reviewed-by: Simon Glass <sjg@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/3250ff0f784cb52159d313ef40b893daa291a7e2/chromeos-config/libcros_config/cros_config_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by jclinton@chromium.org
, Nov 4 2017