New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781543 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

CorrectedSelectionAfterCommand() should not return invalid selection

Project Member Reported by ClusterFuzz, Nov 4 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5674977616723968

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Breakpoint
Crash Address: 0x7fbb5880
Crash State:
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=471041:471079

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5674977616723968

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 4 2017

Components: Blink>Editing
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: msrchandra@chromium.org pnangunoori@chromium.org
Labels: M-63 Test-Predator-Wrong
Owner: yosin@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.
Using the code search for the file, “SimplifiedBackwardsTextIterator.cpp” assigning to concern owner from GIT blame.

Suspecting Commit#
https://chromium.googlesource.com/chromium/src/+/4bbd32a9e1f247a9491178f45d34c8c0d467b5c8

@yosin -- Could you please look into this issue, kindly reassign if it has nothing to do with your changes.
Thank You.

Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-Auto-CC

Comment 6 by yosin@chromium.org, Nov 8 2017

Components: -Blink>Editing Blink>Editing>Selection
Labels: -Pri-1 Pri-3
Owner: ----
Status: Available (was: Assigned)
Summary: CorrectedSelectionAfterCommand() should not return invalid selection (was: Breakpoint in blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N)
Lower to Pri-3 since it is caused by unusual HTML.

HIt DCHECK
EphemeralRange.cpp(41) Check failed: start_position_.IsValidFor(*start_position_.GetDocument()).

In CorrectedSelectionAfterCommand(), we should use Position::IsValidFor()
or adjust offset in Text node.


Project Member

Comment 7 by ClusterFuzz, Nov 21 2017

ClusterFuzz has detected this issue as fixed in range 517712:517832.

Detailed report: https://clusterfuzz.com/testcase?key=5674977616723968

Fuzzer: inferno_layout_test_unmodified
Job Type: windows_asan_content_shell
Platform Id: windows

Crash Type: Breakpoint
Crash Address: 0x7fbb5880
Crash State:
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  blink::SimplifiedBackwardsTextIteratorAlgorithm<blink::EditingAlgorithm<blink::N
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=471041:471079
Fixed: https://clusterfuzz.com/revisions?job=windows_asan_content_shell&range=517712:517832

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5674977616723968

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Nov 21 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 5674977616723968 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment