drop wget from rootfs |
|||||||
Issue descriptionwe added wget to the chrome ebuild only so chrome could upload crash reports in issue 190568 . it doesn't do that anymore (it passes crashes to the system crash_reporter which uses curl), so we can drop it from chrome. since chrome is the only package that depends on wget, dropping it there means it'll be removed from the rootfs. this is already the case for non-browser systems (like lakitu and jetstream), so we have some coverage already to make sure this works.
,
Nov 9 2017
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7 commit fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Nov 10 22:05:45 2017 chrome: drop wget dependency This was added long ago in chromium:190568 so Chrome could upload its own crash reports. Since Chrome no longer does that (it passes them to the system crash reporter which uses curl), we can drop this dep. BUG= chromium:781538 TEST=chromium pfq passes CQ-DEPEND=CL:754542 Change-Id: Icf641ffbba3d60f228c417099bc04b3cdd3125e2 Reviewed-on: https://chromium-review.googlesource.com/753759 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: David Riley <davidriley@chromium.org> [modify] https://crrev.com/fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild
,
Nov 13 2017
A theory out there is that the missing wget is causing provision failure spike.
,
Nov 13 2017
I see vapier has a fix at https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/754542 , perhaps should be chumped.
,
Nov 13 2017
that's already been merged. i landed that a week ago before landing the chrome CL. dev & test images are guaranteed to have wget installed in /usr/local. but if /usr/local is nuked, then wget won't work.
,
Nov 15 2017
,
Nov 15 2017
I am investigating a moblab provisioning issue that seems to be related. https://bugs.chromium.org/p/chromium/issues/detail?id=785487
,
Nov 20 2017
problems with code requiring wget have been handled in other bugs. this one is resolved now since wget isn't shipped in the rootfs anymore.
,
Jan 22 2018
,
Jan 23 2018
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Nov 7 2017