New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781538 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 784462



Sign in to add a comment

drop wget from rootfs

Project Member Reported by vapier@chromium.org, Nov 4 2017

Issue description

we added wget to the chrome ebuild only so chrome could upload crash reports in  issue 190568 .  it doesn't do that anymore (it passes crashes to the system crash_reporter which uses curl), so we can drop it from chrome.

since chrome is the only package that depends on wget, dropping it there means it'll be removed from the rootfs.  this is already the case for non-browser systems (like lakitu and jetstream), so we have some coverage already to make sure this works.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f5224c5b99db5bba5f016ecf216449866d3c6a8f

commit f5224c5b99db5bba5f016ecf216449866d3c6a8f
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Nov 07 01:26:19 2017

target-chromium-os-dev: add wget & curl to the dev image explicitly

These packages get pulled in for some targets implicitly to the rootfs.
Add these to the dev image explicitly so they're always available when
doing development & testing.

BUG= chromium:781538 
TEST=precq passes

Change-Id: Iccbd376c3d36fd4d932a93ae045270fa48259250
Reviewed-on: https://chromium-review.googlesource.com/754542
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[rename] https://crrev.com/f5224c5b99db5bba5f016ecf216449866d3c6a8f/virtual/target-chromium-os-dev/target-chromium-os-dev-1-r25.ebuild
[modify] https://crrev.com/f5224c5b99db5bba5f016ecf216449866d3c6a8f/virtual/target-chromium-os-dev/target-chromium-os-dev-1.ebuild

Cc: drinkcat@chromium.org dnschn...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7

commit fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Nov 10 22:05:45 2017

chrome: drop wget dependency

This was added long ago in chromium:190568 so Chrome could upload its
own crash reports.  Since Chrome no longer does that (it passes them
to the system crash reporter which uses curl), we can drop this dep.

BUG= chromium:781538 
TEST=chromium pfq passes
CQ-DEPEND=CL:754542

Change-Id: Icf641ffbba3d60f228c417099bc04b3cdd3125e2
Reviewed-on: https://chromium-review.googlesource.com/753759
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: David Riley <davidriley@chromium.org>

[modify] https://crrev.com/fbb659dde1a36d7c2ce3ded7a034d38f9ac2f5b7/chromeos-base/chromeos-chrome/chromeos-chrome-9999.ebuild

Cc: xixuan@chromium.org shuqianz@chromium.org
Labels: -Pri-3 Pri-0
A theory out there is that the missing wget is causing provision failure spike.
I see vapier has a fix at https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/754542 , perhaps should be chumped.

Comment 6 by vapier@chromium.org, Nov 13 2017

that's already been merged.  i landed that a week ago before landing the chrome CL.  dev & test images are guaranteed to have wget installed in /usr/local.  but if /usr/local is nuked, then wget won't work.

Comment 7 by vapier@chromium.org, Nov 15 2017

Blockedon: 784462
I am investigating a moblab provisioning issue that seems to be related.
https://bugs.chromium.org/p/chromium/issues/detail?id=785487

Comment 9 by vapier@chromium.org, Nov 20 2017

Labels: -Pri-0 Pri-3
Status: Fixed (was: Available)
problems with code requiring wget have been handled in other bugs.  this one is resolved now since wget isn't shipped in the rootfs anymore.

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 11 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment