pstore: migrate from /dev/pstore to /sys/fs/pstore |
|||
Issue descriptionThis matches better with default kernel conventions (which documents the /sys/fs path over the /dev path), and is a bit cleaner in that the pstore tree doesn't contain device nodes, just log buffers. it's also the default in systemd builds like lakitu.
,
Nov 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/253b614b4fe78b77fe548188d81cdd1cef6e3fac commit 253b614b4fe78b77fe548188d81cdd1cef6e3fac Author: Mike Frysinger <vapier@chromium.org> Date: Tue Nov 07 20:17:45 2017 init: pstore: move to /sys/fs/pstore This matches better with default kernel conventions (which documents the /sys/fs path over the /dev path), and is a bit cleaner in that the pstore tree doesn't contain device nodes, just log buffers. BUG= chromium:781536 TEST=precq passes CQ-DEPEND=CL:*496205 Change-Id: If8dc7c7393ca69a31a0779ba2a4ee968295c89a8 Reviewed-on: https://chromium-review.googlesource.com/753516 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Pradeep Sawlani <sawlani@google.com> [modify] https://crrev.com/253b614b4fe78b77fe548188d81cdd1cef6e3fac/init/upstart/pstore.conf
,
Nov 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d23e6e4aa0a820b350abb3a77c6f17e28be68d3e commit d23e6e4aa0a820b350abb3a77c6f17e28be68d3e Author: Mike Frysinger <vapier@chromium.org> Date: Wed Nov 08 19:47:54 2017 init: clobber-log: move to /sys/fs/pstore We've updated the pstore init script to move to /sys/fs/pstore. This matches better with default kernel conventions (which documents the /sys/fs path over the /dev path), and is a bit cleaner in that the pstore tree doesn't contain device nodes, just log buffers. BUG= chromium:781536 TEST=precq passes Change-Id: I61568f011a1e99c23f52b6ec361fb898fb789fd9 Reviewed-on: https://chromium-review.googlesource.com/753517 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/d23e6e4aa0a820b350abb3a77c6f17e28be68d3e/init/clobber-log
,
Nov 9 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/autotest-cheets/+/274efa69e30ea50bd8a4c9a31b724757234207c9 commit 274efa69e30ea50bd8a4c9a31b724757234207c9 Author: Mike Frysinger <vapier@chromium.org> Date: Thu Nov 09 03:48:55 2017
,
Nov 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d4eefa34ef205dbf05807be0150e16841d9ddb2c commit d4eefa34ef205dbf05807be0150e16841d9ddb2c Author: Mike Frysinger <vapier@chromium.org> Date: Thu Nov 09 08:38:10 2017 debugd: log_tool: move to /sys/fs/pstore We've updated the pstore init script to move to /sys/fs/pstore. This matches better with default kernel conventions (which documents the /sys/fs path over the /dev path), and is a bit cleaner in that the pstore tree doesn't contain device nodes, just log buffers. BUG= chromium:781536 TEST=precq passes Change-Id: I69528cd768244f0e77422491e19b5adf1a67eb52 Reviewed-on: https://chromium-review.googlesource.com/753518 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> Reviewed-by: Pradeep Sawlani <sawlani@google.com> [modify] https://crrev.com/d4eefa34ef205dbf05807be0150e16841d9ddb2c/debugd/src/log_tool.cc
,
Nov 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/kernel/+/193f1c589b3c8e7a06e2a7a8e56fe039a43bb86e commit 193f1c589b3c8e7a06e2a7a8e56fe039a43bb86e Author: Josh Boyer <jwboyer@redhat.com> Date: Fri Nov 10 17:16:36 2017 UPSTREAM: pstore: Create a convenient mount point for pstore Using /dev/pstore as a mount point for the pstore filesystem is slightly awkward. We don't normally mount filesystems in /dev/ and the /dev/pstore file isn't created automatically by anything. While this method will still work, we can create a persistent mount point in sysfs. This will put pstore on par with things like cgroups and efivarfs. BUG= chromium:782821 , chromium:781536 TEST=precq passes Signed-off-by: Josh Boyer <jwboyer@redhat.com> Acked-by: Kees Cook <keescook@chromium.org> Signed-off-by: Tony Luck <tony.luck@intel.com> (cherry picked from commit fb0af3f2b1b613e5ea75426d454c7e5b1d1eef49) Change-Id: I8ed29909ac26f5a2e171c05e0640d731419f1233 Reviewed-on: https://chromium-review.googlesource.com/759277 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Benjamin Gordon <bmgordon@chromium.org> Reviewed-by: Guenter Roeck <groeck@chromium.org> Reviewed-by: Benjamin Gordon <bmgordon@chromium.org> [modify] https://crrev.com/193f1c589b3c8e7a06e2a7a8e56fe039a43bb86e/Documentation/ABI/testing/pstore [modify] https://crrev.com/193f1c589b3c8e7a06e2a7a8e56fe039a43bb86e/fs/pstore/inode.c
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/696358315e517824a0e52dd337118949513e6ba9 commit 696358315e517824a0e52dd337118949513e6ba9 Author: Mike Frysinger <vapier@chromium.org> Date: Tue Nov 21 02:13:38 2017 platform_BootPerf: move to /sys/fs/pstore We're moving the mount point to under /sys/fs. BUG= chromium:781536 TEST=precq passes Change-Id: I7528a82eeb116f215423a6b802439d2986df57a1 Reviewed-on: https://chromium-review.googlesource.com/775795 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Po-Hsien Wang <pwang@chromium.org> [modify] https://crrev.com/696358315e517824a0e52dd337118949513e6ba9/client/site_tests/platform_BootPerf/platform_BootPerf.py
,
Nov 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a2809b720679a76722f1b40cef4762c9d95f012e commit a2809b720679a76722f1b40cef4762c9d95f012e Author: Mike Frysinger <vapier@chromium.org> Date: Tue Nov 21 21:34:43 2017 crash: switch to /sys/fs/pstore directly Now that we mount /sys/fs/pstore everywhere, we can switch to reading that directly and avoid having to bind mount /dev/pstore. BUG= chromium:781536 TEST=precq passes Change-Id: I67e9a1589f451e9f54f6ff95f007ae7dc3dc28c1 Reviewed-on: https://chromium-review.googlesource.com/775863 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/a2809b720679a76722f1b40cef4762c9d95f012e/crash-reporter/crash_reporter.cc [modify] https://crrev.com/a2809b720679a76722f1b40cef4762c9d95f012e/crash-reporter/kernel_collector.cc
,
Nov 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/494498e759fb75a6ded02774d106e255663ea0e7 commit 494498e759fb75a6ded02774d106e255663ea0e7 Author: Mike Frysinger <vapier@chromium.org> Date: Sat Nov 25 04:31:23 2017 kernel_MemoryRamoop: move to /sys/fs/pstore We're moving the mount point to under /sys/fs. BUG= chromium:781536 TEST=precq passes Change-Id: I0e5078751292f3b753209daa0699886c95856130 Reviewed-on: https://chromium-review.googlesource.com/775980 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/494498e759fb75a6ded02774d106e255663ea0e7/server/site_tests/kernel_MemoryRamoop/control [modify] https://crrev.com/494498e759fb75a6ded02774d106e255663ea0e7/server/site_tests/kernel_MemoryRamoop/kernel_MemoryRamoop.py
,
Dec 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/92a542abbebf5cb2ba318cb761861bc715d86092 commit 92a542abbebf5cb2ba318cb761861bc715d86092 Author: Mike Frysinger <vapier@chromium.org> Date: Fri Dec 15 23:52:44 2017 stop collecting files from /dev/pstore Since devices use /sys/fs/pstore everywhere now, stop looking in /dev/pstore. BUG= chromium:781536 TEST=precq passes Change-Id: I0f91de3ee8de47d8591a185fd640cf6127c02d62 Reviewed-on: https://chromium-review.googlesource.com/815555 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/92a542abbebf5cb2ba318cb761861bc715d86092/client/cros/constants.py [modify] https://crrev.com/92a542abbebf5cb2ba318cb761861bc715d86092/client/common_lib/logs_to_collect
,
Jan 19 2018
The following revision refers to this bug: https://chrome-internal.googlesource.com/chromeos/ap-daemons/+/2f39012cb0644fb9eb666c5bf2b6ffc038ddc6fd commit 2f39012cb0644fb9eb666c5bf2b6ffc038ddc6fd Author: Mike Frysinger <vapier@chromium.org> Date: Fri Jan 19 01:40:43 2018
,
Feb 3 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/4b97fabffd010ae906e3092f5ab7c18227e67d06 commit 4b97fabffd010ae906e3092f5ab7c18227e67d06 Author: Mike Frysinger <vapier@chromium.org> Date: Sat Feb 03 00:32:05 2018 move to /sys/fs/pstore We're moving the mount point to under /sys/fs. BUG= chromium:781536 TEST=precq passes Change-Id: Ib6954ff01aeb76ea1aaca0485b37e27e19391daf Reviewed-on: https://chromium-review.googlesource.com/896406 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/4b97fabffd010ae906e3092f5ab7c18227e67d06/py/utils/sys_utils.py [modify] https://crrev.com/4b97fabffd010ae906e3092f5ab7c18227e67d06/py/test/diagnosis/system_logs.yaml [modify] https://crrev.com/4b97fabffd010ae906e3092f5ab7c18227e67d06/py/tools/factory_bug.py
,
Feb 3 2018
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/4a6740b4e7e174d0a5192e4faa465f51d10799b7 commit 4a6740b4e7e174d0a5192e4faa465f51d10799b7 Author: Mike Frysinger <vapier@chromium.org> Date: Wed May 16 12:08:37 2018 init: drop /dev/pstore compat Everything should be migrated to /sys/fs/pstore now. BUG= chromium:781536 TEST=precq passes Change-Id: I769e24ae5a375e7ef230e30eda0b3bda52fff8c3 Reviewed-on: https://chromium-review.googlesource.com/898043 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Brian Norris <briannorris@chromium.org> [modify] https://crrev.com/4a6740b4e7e174d0a5192e4faa465f51d10799b7/init/upstart/pstore.conf
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/b2967842737641444597378d3c39dd13bb277057 commit b2967842737641444597378d3c39dd13bb277057 Author: Todd Broch <tbroch@chromium.org> Date: Fri May 18 05:21:07 2018 platform_FilePerms: drop /dev/pstore compat. crrev.com/c/898043 migrated to /sys/fs/pstore exclusively. CQ-DEPEND=CL:898043 BUG= chromium:781536 TEST=platform_FilePerms passes Change-Id: I7422a0bbce1beebfeb5d1264f503989a457da227 Reviewed-on: https://chromium-review.googlesource.com/1055592 Commit-Ready: Todd Broch <tbroch@chromium.org> Tested-by: Todd Broch <tbroch@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/b2967842737641444597378d3c39dd13bb277057/client/site_tests/platform_FilePerms/platform_FilePerms.py
,
Aug 15
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/872e684fb6ef09fdc8c2ff083ad2e07edd37a79c commit 872e684fb6ef09fdc8c2ff083ad2e07edd37a79c Author: Mike Frysinger <vapier@chromium.org> Date: Wed Aug 15 11:42:47 2018 crash: fix pstore parent path check When we switched to /sys/fs/pstore, we didn't update the parent patch which is used by the "is pstore mounted" check. BUG= chromium:781536 TEST=precq passes TEST=(pstore mounted) --boot detects pstore mount TEST=(pstore unmounted) --boot detects pstore is not mounted Change-Id: I318e160d04d364ec01239099d8fa88909e74d58f Reviewed-on: https://chromium-review.googlesource.com/1173699 Commit-Ready: Mike Frysinger <vapier@chromium.org> Tested-by: Mike Frysinger <vapier@chromium.org> Reviewed-by: Ben Chan <benchan@chromium.org> [modify] https://crrev.com/872e684fb6ef09fdc8c2ff083ad2e07edd37a79c/crash-reporter/kernel_collector.cc |
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Nov 7 2017