New issue
Advanced search Search tips

Issue 781529 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in CPDF_HintTables::ReadPageHintTable

Project Member Reported by ClusterFuzz, Nov 4 2017

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5140733614096384

Fuzzer: afl_pdf_hint_table_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00017fff7ffe
Crash State:
  CPDF_HintTables::ReadPageHintTable
  HintTableForFuzzing::Fuzz
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=514029:514033

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5140733614096384

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 4 2017

Components: Internals>Plugins>PDF
Labels: Test-Predator-AutoComponents
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Nov 4 2017

Labels: Test-Predator-AutoOwner
Owner: art-sn...@yandex-team.ru
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/33591752d2cb14f2e07726ca52afce6efbdc07c9 (Simplify CPDF_HintsTable.).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 5 2017

Labels: M-64
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 5 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 5 2017

Labels: Pri-1
A revert has been submitted. https://pdfium-review.googlesource.com/c/pdfium/+/17830
Cc: thestig@chromium.org
Labels: -ReleaseBlock-Stable
This CL has been reverted, removing the RBS.
Should we leave this open this the CL has been reverted?

I commented on the revert CL as to what went wrong.
I we should, when the CL is re-landed it should reference this BUG and we can close it then, yea? I removed the release block, so it's just a bug now.
Project Member

Comment 11 by ClusterFuzz, Nov 7 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5313006765604864 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Status: Assigned (was: Verified)
I'm guessing the reverted CL will be re-landed. Keeping this open so we know it needs to be fixed with the reland.
Project Member

Comment 13 by ClusterFuzz, Nov 7 2017

ClusterFuzz has detected this issue as fixed in range 514153:514189.

Detailed report: https://clusterfuzz.com/testcase?key=5140733614096384

Fuzzer: afl_pdf_hint_table_fuzzer
Job Type: afl_chrome_asan
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x00017fff7ffe
Crash State:
  CPDF_HintTables::ReadPageHintTable
  HintTableForFuzzing::Fuzz
  
Sanitizer: address (ASAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=514029:514033
Fixed: https://clusterfuzz.com/revisions?job=afl_chrome_asan&range=514153:514189

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5140733614096384

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 14 by sheriffbot@chromium.org, Nov 7 2017

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -ReleaseBlock-Stable ReleaseBlock-NA
This has been reverted so is not release block.
Labels: Test-Predator-Auto-CC
Labels: -Test-Predator-AutoComponents Test-Predator-Auto-Components
Labels: -Test-Predator-AutoOwner Test-Predator-Auto-Owner
Labels: -Test-Predator-Auto-CC
Project Member

Comment 20 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/cee39e6e90c219cc91f2c94a912a06977f4461a0

commit cee39e6e90c219cc91f2c94a912a06977f4461a0
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Nov 13 18:35:23 2017

Check first page number in IsLinearizedHeaderValid().

This should allow https://pdfium-review.googlesource.com/15770 to safely
reland.

BUG= chromium:781529 

Change-Id: Id0c1bde3280fb72125d8e74751b9a1cb35302b6f
Reviewed-on: https://pdfium-review.googlesource.com/18170
Reviewed-by: dsinclair <dsinclair@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/cee39e6e90c219cc91f2c94a912a06977f4461a0/core/fpdfapi/parser/cpdf_linearized_header.cpp

Project Member

Comment 21 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb9b79b4d71e2a05fe5fcf3f4f08574aa8b2cc28

commit fb9b79b4d71e2a05fe5fcf3f4f08574aa8b2cc28
Author: pdfium-deps-roller@chromium.org <pdfium-deps-roller@chromium.org>
Date: Mon Nov 13 23:39:11 2017

Roll src/third_party/pdfium/ 9fa503624..f2d490650 (2 commits)

https://pdfium.googlesource.com/pdfium.git/+log/9fa5036245c3..f2d490650cef

$ git log 9fa503624..f2d490650 --date=short --no-merges --format='%ad %ae %s'
2017-11-13 hnakashima Remove virtual from EmbedderTest methods that are not overridden.
2017-11-13 thestig Check first page number in IsLinearizedHeaderValid().

Created with:
  roll-dep src/third_party/pdfium
BUG= 781529 


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Ia254f6081520caf0c3eaa7cd6167c5ef6e52bdcc
Reviewed-on: https://chromium-review.googlesource.com/767013
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516099}
[modify] https://crrev.com/fb9b79b4d71e2a05fe5fcf3f4f08574aa8b2cc28/DEPS

Project Member

Comment 22 by sheriffbot@chromium.org, Nov 19 2017

art-snake: Uh oh! This issue still open and hasn't been updated in the last 14 days. This is a serious vulnerability, and we want to ensure that there's progress. Could you please leave an update with the current status and any potential blockers?

If you're not the right owner for this issue, could you please remove yourself as soon as possible or help us find the right one?

If the issue is fixed or you can't reproduce it, please close the bug. If you've started working on a fix, please set the status to Started.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: -thestig@chromium.org art-sn...@yandex-team.ru
Owner: thestig@chromium.org
Status: Fixed (was: Assigned)
The fuzzer bug has been fixed. art-snake@ can revert the revert whenever.
Project Member

Comment 24 by sheriffbot@chromium.org, Nov 22 2017

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Project Member

Comment 25 by sheriffbot@chromium.org, Feb 28 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 26 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head -M-64 M-65 Security_Impact-Stable

Sign in to add a comment