New issue
Advanced search Search tips

Issue 781498 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

DevTools: console preview does not wrap, horizontal scroll appears

Project Member Reported by pfeldman@chromium.org, Nov 4 2017

Issue description

See the image.
 
Screen Shot 2017-11-03 at 8.23.09 PM.png
49.1 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e436d6d90eb217693e0fe40fc5d094affcc21f96

commit e436d6d90eb217693e0fe40fc5d094affcc21f96
Author: Erik Luo <luoe@chromium.org>
Date: Wed Nov 08 01:25:00 2017

DevTools: use non-breaking space after length in preview

With today's normal space, Blink can break long previews at awkward
locations.  If we place a non-breaking space after the length instead,
we do not.

Screenshot: https://imgur.com/a/czGw5

Bug:  781498 
Change-Id: I660cdf9ae1eec307d7a12ae73369d7a0cf7cb4a2
Reviewed-on: https://chromium-review.googlesource.com/754280
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514697}
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-call-getter-on-proto-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-dirxml-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-edit-property-value-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-external-array-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-array-prototype-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-collections-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-es6-2-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-format-perfomance-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-log-side-effects-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-message-format-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-constructor-name-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-save-to-temp-var-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-inline-values-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/debugger-save-to-temp-var-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger-ui/inline-scope-variables-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-minified-variables-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/sources/debugger/debugger-scope-resolve-this-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/LayoutTests/http/tests/devtools/startup/console/console-format-startup-expected.txt
[modify] https://crrev.com/e436d6d90eb217693e0fe40fc5d094affcc21f96/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7356b1fdc83c8a97e64708b7f20865fd59d950bb

commit 7356b1fdc83c8a97e64708b7f20865fd59d950bb
Author: Erik Luo <luoe@chromium.org>
Date: Thu Dec 14 02:14:11 2017

DevTools: fix console overflow and wrapping styles

Today's previews might not always wrap when they should.
Example: `Object.keys(window.performance.timing.__proto__)`

Bug:  781498 
Change-Id: I763f55a8802773811b67c2f91eee96b3cb7e003b
Reviewed-on: https://chromium-review.googlesource.com/818079
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523986}
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-object-preview-expected.txt
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/LayoutTests/http/tests/devtools/console/console-proxy-expected.txt
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/Source/devtools/front_end/console/ConsoleViewMessage.js
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/Source/devtools/front_end/console/consoleView.css
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/Source/devtools/front_end/object_ui/RemoteObjectPreviewFormatter.js
[modify] https://crrev.com/7356b1fdc83c8a97e64708b7f20865fd59d950bb/third_party/WebKit/Source/devtools/front_end/object_ui/objectValue.css

Comment 3 by l...@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment