New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 781487 link

Starred by 1 user
Status: Fixed
Owner:
mar...@chromium.org
Closed: Mar 2018
Cc:
█ alhem@google.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Terminate task are not immediately reaped

Project Member Reported by mar...@chromium.org, Nov 4 2017 
The ghost of issue 735388 is still well alive.
Looks like the priority is still not working as expected.

Terminate at 21:43:25 (EDT) at priority 0
https://chromium-swarm.appspot.com/task?id=399d83f2cc6cf210
was preempted by a test created at 19:56:21 (EDT) at priority 100.
https://chromium-swarm.appspot.com/task?id=399d21eb2819fe10
on bot https://chromium-swarm.appspot.com/bot?id=swarm921-c4
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/luci/luci-py.git/+/654678c576d434a6cf38b2543e9be245e30fa87d

commit 654678c576d434a6cf38b2543e9be245e30fa87d
Author: Marc-Antoine Ruel <maruel@chromium.org>
Date: Fri Nov 10 20:05:32 2017

swarming: fix priorities, add smoke test to confirm priorities work.

- Add explanations about the expected types (int, long), the bit size and why.
- Add a complete end-to-end smoke test, which ensures that priorities indeed
  work.
- Indeed the priorities didn't work, the unit test was not enough.
- Fix priority code.

In particular, this change the TaskToRun query from a keys_only=True query
to a normal query fetching the entities. This is a big change which may
have performance impact.

Bug:  781487 
Change-Id: I2157d0b6b9f40c44b4c733bfd2bfc55b83c469cb
Reviewed-on: https://chromium-review.googlesource.com/755774
Reviewed-by: Vadim Shtayura <vadimsh@chromium.org>
Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org>

[modify] https://crrev.com/654678c576d434a6cf38b2543e9be245e30fa87d/appengine/swarming/local_smoke_test.py
[modify] https://crrev.com/654678c576d434a6cf38b2543e9be245e30fa87d/appengine/swarming/server/task_queues.py
[modify] https://crrev.com/654678c576d434a6cf38b2543e9be245e30fa87d/appengine/swarming/server/task_to_run.py
[modify] https://crrev.com/654678c576d434a6cf38b2543e9be245e30fa87d/appengine/swarming/server/task_to_run_test.py

Comment 2 by mar...@chromium.org, Mar 1 2018

Owner: mar...@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment