New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 781485 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

[a11y assessment Downloads bar] button submenu unlabeled, instructions ambiguous

Project Member Reported by leberly@chromium.org, Nov 4 2017

Issue description

Google Chrome	64.0.3257.0 (Official Build) canary (64-bit) (cohort: Clang-64)
Windows 10 Enterprise Version 1607 Build 14393.1770
JAWS 2018.1710.42 private preview release
NVDA 2017.3

Repro steps: 
# Download any file to bring up downloads bar. For example, go to https://permission.site and use Auto Download to download some test pictures.
# Navigate to the Download bar using F6
# Focus falls on the download button for the item just downloaded 
Expected: when JAWS says "Press space to activate the menu, then navigate with arrow keys", pressing space will activate the sub menu. Note that NVDA does not offer this instruction 
Actual: pressing space will invoke the entire button (open what was downloaded) instead of accessing the submenu  
# If the download bar was dismissed by the previous step, download another file
# Once focus is on the entire button menu, press the right arrow key once
Expected: button is labeled
Actual: screen reader just says Button 


 
Can repro in stable 
Google Chrome	62.0.3202.75 (Official Build) (64-bit) (cohort: 62_75_win)


Verified in stable and canary versions noted above with NVDA 17.3. 

There are two buttons here. First is the button to open the file. This button is labelled with the filename. Pressing applications key will bring up the options menu. The unlabeled button is the control that also brings up this menu.
I would expect the first button to be labelled something like 'open <filename>' and not indicate the sub menu and the second to be labelled 'more options' and sub menu to be indicated here.
Further detail on the two comments here. Visually, the sub-menu (second) button is located inside the first button. From the screen reader perspective, they are two different buttons.  
Labels: -Pri-2 Pri-1
Labels: a11y-2017
Labels: win-a11y
Labels: downloads
 Issue 779299  has been merged into this issue.
Owner: aleventhal@chromium.org
Status: Started (was: Available)
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49074912451707d0f0e935934f70174cc21490a4

commit 49074912451707d0f0e935934f70174cc21490a4
Author: Aaron Leventhal <aleventhal@chromium.org>
Date: Fri Feb 16 02:36:04 2018

Fix missing accessibility names in browser UI

Address a collection of missing a11y names in browser UI found by
iterating through views in the primary UI and checking for non-empty
accessible names where the view is focusable.

The browser view itself intentionally has no name, so it uses the
explicitly empty name attribute flag.

The textfield control has been updated so that SetAssociatedLabel
can be used to automatically set the name. When this is used the
accessibility labelledby relationship is also automatically set.

Bug:  781485 
Change-Id: Ie6359af94938156ae2ee7f36b73059fe2830cbdc
Reviewed-on: https://chromium-review.googlesource.com/905592
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537121}
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/app/generated_resources.grd
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/apps/guest_view/web_view_browsertest.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/global_error/global_error_service_browsertest.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/javascript_dialogs/javascript_dialog_browsertest.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/toolbar/toolbar_action_view_controller.h
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/apps/app_info_dialog/app_info_summary_panel.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/cookie_info_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/location_bar/find_bar_icon.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/profiles/avatar_button.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/tab_icon_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/chrome/browser/ui/views/toolbar/toolbar_action_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/accessibility/ax_node_data.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/accessibility/ax_node_data.h
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/views/controls/message_box_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/views/controls/table/table_view.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/views/controls/textfield/textfield.cc
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/views/controls/textfield/textfield.h
[modify] https://crrev.com/49074912451707d0f0e935934f70174cc21490a4/ui/views/controls/webview/webview.cc

Status: Fixed (was: Started)
There were actually about a dozen nameless fixes in that CL.
Labels: a11y-testers
Status: Assigned (was: Fixed)
Chrome: 66.0.3355.0
NVDA: 2017.4

The options button is now labelled, thank you!
The button labelled with the filename still reports as a submenu, but when activated, opens the file.

Labels: -a11y-testers
Labels: a11y-testers
Status: Fixed (was: Assigned)
Labels: -a11y-testers
Status: Verified (was: Fixed)

Sign in to add a comment