New issue
Advanced search Search tips

Issue 781476 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Whining update should not use respawn as a while/true loop

Project Member Reported by haddowk@chromium.org, Nov 4 2017

Issue description

It is not a good idea to use the upstart respawn as a while loop for a process, make the while true explicit in the script




 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/f5c7b92bb9584321a10f9ef6091d26b2588ee709

commit f5c7b92bb9584321a10f9ef6091d26b2588ee709
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Nov 09 01:25:44 2017

[moblab] Put the whining database update in an explicit script

The current conf uses the respawn to create an implicit loop
add to the script to make it a explicit loop.

Also slow down the update a little, it is not used by very many
partners and the resources are better used elsewhere.

BUG= chromium:781476 
TEST=local moblab testing

Change-Id: I1b4223ad49c4b7cb955d91bb053406e045afb860
Reviewed-on: https://chromium-review.googlesource.com/754373
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>

[rename] https://crrev.com/f5c7b92bb9584321a10f9ef6091d26b2588ee709/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r71.ebuild
[modify] https://crrev.com/f5c7b92bb9584321a10f9ef6091d26b2588ee709/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/whining-update-db.conf

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2017

Labels: merge-merged-release-R63-10032.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e2d20c0d18586e2f526d7c655c49db3a1d350a0c

commit e2d20c0d18586e2f526d7c655c49db3a1d350a0c
Author: Keith Haddow <haddowk@chromium.org>
Date: Thu Nov 09 01:31:40 2017

[moblab] Put the whining database update in an explicit script

The current conf uses the respawn to create an implicit loop
add to the script to make it a explicit loop.

Also slow down the update a little, it is not used by very many
partners and the resources are better used elsewhere.

BUG= chromium:781476 
TEST=local moblab testing

Change-Id: I1b4223ad49c4b7cb955d91bb053406e045afb860
Reviewed-on: https://chromium-review.googlesource.com/754373
Commit-Ready: Keith Haddow <haddowk@chromium.org>
Tested-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
(cherry picked from commit f5c7b92bb9584321a10f9ef6091d26b2588ee709)
Reviewed-on: https://chromium-review.googlesource.com/758754
Commit-Queue: Keith Haddow <haddowk@chromium.org>

[add] https://crrev.com/e2d20c0d18586e2f526d7c655c49db3a1d350a0c/project-moblab/chromeos-base/chromeos-bsp-moblab/chromeos-bsp-moblab-0.0.5-r71.ebuild
[modify] https://crrev.com/e2d20c0d18586e2f526d7c655c49db3a1d350a0c/project-moblab/chromeos-base/chromeos-bsp-moblab/files/init/whining-update-db.conf

Comment 4 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Comment 5 by dchan@chromium.org, Jan 23 2018

Status: Fixed (was: Archived)

Sign in to add a comment