New issue
Advanced search Search tips

Issue 781434 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 651764
issue 752672



Sign in to add a comment

Blink tests should use a TextIterator-free text dumper

Project Member Reported by xiaoche...@chromium.org, Nov 3 2017

Issue description

Currently, Blink tests dump document text content with TextIterator. However, our implementation of TextIterator is not spec-compliant and contains bugs.

To avoid massive rebaselining when changing the implementation of TextIterator, we should use a different text dumper for tests. This also makes the text dump more predictable.
 
Blocking: 752672
Note that this is also related to LayoutNG, since we have a different TextIterator when LayoutNG is enabled.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b7caf9d9a9948625b933566f9479990bb014dc2

commit 6b7caf9d9a9948625b933566f9479990bb014dc2
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Wed Nov 08 00:35:55 2017

Use a simplified version of Node.innerText for gtest text dump

This patch changes WebFrameContentDumper to use a simplified version
of Node.innerText instead of TextIterator for text dumping, so that
Blink gtests no longer uses TextIterator for text dumping, so that we
can avoid massive rebaselining when changing behavior of TextIterator.

A follow-up patch will change layout tests to use WebFrameContentDumper
for text dump, so that layout test text dumps are TextIterator-free.

Bug:  781434 
Change-Id: If5bce13d0fa2c8685f2eddf146c7be1250845e28
Reviewed-on: https://chromium-review.googlesource.com/756365
Reviewed-by: Dimitri Glazkov <dglazkov@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514671}
[modify] https://crrev.com/6b7caf9d9a9948625b933566f9479990bb014dc2/content/renderer/dom_serializer_browsertest.cc
[modify] https://crrev.com/6b7caf9d9a9948625b933566f9479990bb014dc2/content/renderer/render_view_browsertest.cc
[modify] https://crrev.com/6b7caf9d9a9948625b933566f9479990bb014dc2/third_party/WebKit/Source/core/exported/WebFrameContentDumper.cpp
[modify] https://crrev.com/6b7caf9d9a9948625b933566f9479990bb014dc2/third_party/WebKit/Source/core/exported/WebFrameTest.cpp
[modify] https://crrev.com/6b7caf9d9a9948625b933566f9479990bb014dc2/third_party/WebKit/Source/core/exported/WebViewTest.cpp

Blocking: 651764
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ab8b8c61c9504168cb36f49d22ae96d417bc17

commit 41ab8b8c61c9504168cb36f49d22ae96d417bc17
Author: Xiaocheng Hu <xiaochengh@chromium.org>
Date: Tue Dec 11 17:01:27 2018

Make WebFrameContentDumper use Element.innerText

This patch changes WebFrameContentDumper to use Element.innerText
instead of its ad-hoc TextDumper, so that its output is more
predictable.

This patch also allows all WebFrameSwapTest to pass in LayoutNG.

Bug:  781434 
Change-Id: I961fa43c1821e2a0e7eae6b01a6affe884eacc72
Reviewed-on: https://chromium-review.googlesource.com/c/1371145
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#615560}
[modify] https://crrev.com/41ab8b8c61c9504168cb36f49d22ae96d417bc17/third_party/blink/renderer/core/exported/web_frame_content_dumper.cc
[modify] https://crrev.com/41ab8b8c61c9504168cb36f49d22ae96d417bc17/third_party/blink/renderer/core/exported/web_frame_test.cc

Status: Fixed (was: Assigned)

Sign in to add a comment