New issue
Advanced search Search tips

Issue 781428 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 789184
issue 817186

Blocking:
issue 711468



Sign in to add a comment

[root layer scrolls] devtools layout test failures

Project Member Reported by skobes@chromium.org, Nov 3 2017

Issue description

This bug tracks layout tests under http/tests/devtools/... that fail, crash, or timeout with root layer scrolling enabled.

The following tests are failing consistently on all platforms:

  http/tests/devtools/device-mode/default-background-color.html
  http/tests/devtools/layers/layer-compositing-reasons.html
  http/tests/devtools/layers/layer-scroll-rects-get.html
  http/tests/devtools/layers/layer-tree-model.html
  http/tests/devtools/layers/layers-3d-view-hit-testing.html
  http/tests/devtools/tracing/scroll-invalidations.html
  http/tests/devtools/tracing/timeline-paint/layer-tree.html
  http/tests/devtools/tracing/timeline-paint/paint-profiler-update.html [ Timeout ]
  http/tests/devtools/tracing/timeline-paint/timeline-paint-and-multiple-style-invalidations.html
  http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations-on-deleted-node.html
  http/tests/devtools/tracing/timeline-paint/timeline-paint-with-layout-invalidations.html
  http/tests/devtools/tracing/timeline-paint/timeline-paint-with-style-recalc-invalidations.html
  http/tests/devtools/tracing/timeline-paint/timeline-paint.html

In addition, the following tests seem to be timing out on some platforms (possibly flaky):

  http/tests/devtools/sources/autocomplete-hide-on-smart-brace.js
  http/tests/devtools/agents-enable-disable.js

And the following test crashes with threaded compositing on Windows:

  http/tests/devtools/tracing/timeline-paint/update-layer-tree.html
 

Comment 1 by pdr@chromium.org, Dec 2 2017

Blockedon: 789184
The http/tests/devtools/layers and agents-enable-disable.js failures were fixed in:
https://chromium.googlesource.com/chromium/src/+/1743273d0ea5d0d73e4ba5cbdc1c9acb684e21ff

The devtools/tracing/timeline-paint failures have been pulled off into  https://crbug.com/789184 .

That leaves the following tests that still need investigation:
http/tests/devtools/device-mode/default-background-color.html
http/tests/devtools/layers/layer-compositing-reasons.js
http/tests/devtools/layers/layer-tree-model.js

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/122fa6560e0c8cb675fc32045805e65d53f03a6e

commit 122fa6560e0c8cb675fc32045805e65d53f03a6e
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Dec 06 00:33:55 2017

[root layer scrolls] Rebaseline devtools layer tree and compositing test

layer-tree-model.js:
This test dumps the layer tree and associated elements. With root
layer scrolling (RLS), the layers are associated with different
elements (e.g., the iframe scrolling contents layer is "#document"
instead of "iframe#frame") and there are a different number of
layers, but the test passes otherwise.

layer-compositing-reasons.js:
This test dumps the compositing reasons for all layers, directly from
the GraphicsLayer object. With RLS, the root layer has two additional
reasons: overflowScrollingTouch and rootScroller.

Bug:  781428 
Change-Id: Ibc1e654474c96d2dd8dfdfc01ec52046989c30cb
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/804620
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521914}
[modify] https://crrev.com/122fa6560e0c8cb675fc32045805e65d53f03a6e/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/122fa6560e0c8cb675fc32045805e65d53f03a6e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/http/tests/devtools/layers/layer-compositing-reasons-expected.txt
[add] https://crrev.com/122fa6560e0c8cb675fc32045805e65d53f03a6e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/http/tests/devtools/layers/layer-tree-model-expected.txt
[modify] https://crrev.com/122fa6560e0c8cb675fc32045805e65d53f03a6e/third_party/WebKit/LayoutTests/http/tests/devtools/layers/layer-tree-model.js

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8628e5bedc0375b0faa54e6aebf03c01661381bc

commit 8628e5bedc0375b0faa54e6aebf03c01661381bc
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Dec 06 04:01:49 2017

[root layer scrolls] Repaint scrolling on bg color override change

This patch ensures the scrolling contents layer is repainted when
the background color is changed with the inspector protocol.

Bug:  781428 
Change-Id: Ia7ba3e7acdf55bf557e42cd9fab62d08f2ce3a0c
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/805006
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521996}
[modify] https://crrev.com/8628e5bedc0375b0faa54e6aebf03c01661381bc/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/8628e5bedc0375b0faa54e6aebf03c01661381bc/third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Status: WontFix (was: Available)
Components: -Platform>DevTools
Status: Available (was: WontFix)

Comment 6 by pdr@chromium.org, Feb 28 2018

Blockedon: 817186
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b066b1e5e0daab9f6e73da0b09660827749a24f

commit 5b066b1e5e0daab9f6e73da0b09660827749a24f
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Feb 28 19:29:54 2018

[RLS] Mark text-editor-formatter.js as not timing out on Win

text-editor-formatter.js is no longer timing out on windows:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=http%2Ftests%2Fdevtools%2Feditor%2Ftext-editor-formatter.js

While slow, the slowest run is 5s which is equal to the slowest mac
run. This patch removes the timeout expectation.

Bug:  781428 
Change-Id: I707171e7a32224dc915570e692d33bf86d08d120
Reviewed-on: https://chromium-review.googlesource.com/941409
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#539921}
[modify] https://crrev.com/5b066b1e5e0daab9f6e73da0b09660827749a24f/third_party/WebKit/LayoutTests/TestExpectations

Comment 8 by bokan@chromium.org, Mar 2 2018

Cc: bokan@chromium.org
Status: Fixed (was: Available)
There's no devtools tests remaining for RLS in TestExpectations so this is fixed. Good job team.

Sign in to add a comment