New issue
Advanced search Search tips

Issue 781423 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ProxyService::SetProxyScriptFetchers() should use unique_ptr for proxy_script_fetcher parameter

Project Member Reported by eroman@chromium.org, Nov 3 2017

Issue description

Using a raw pointer but taking ownership right now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9

commit c6c63ffeddd89a57caaacc93faa4af1f23bf1df9
Author: Eric Roman <eroman@chromium.org>
Date: Tue Nov 07 02:00:15 2017

Use a std::unique_ptr in ProxyService::SetProxyScriptFetchers().

TBR=jam@chromium.org

Bug:  781423 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I86d90e9ca4f787a08b2940cb98f2f0c4580432ff
Reviewed-on: https://chromium-review.googlesource.com/755353
Commit-Queue: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514352}
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/content/network/proxy_service_mojo.cc
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/content/network/proxy_service_mojo.h
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/content/public/network/url_request_context_builder_mojo.cc
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/content/test/proxy_service_mojo_unittest.cc
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/net/proxy/proxy_service.cc
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/net/proxy/proxy_service.h
[modify] https://crrev.com/c6c63ffeddd89a57caaacc93faa4af1f23bf1df9/net/proxy/proxy_service_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment