New issue
Advanced search Search tips

Issue 781419 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug

Blocked on:
issue 789184

Blocking:
issue 711468



Sign in to add a comment

[root layer scrolls] failures in paint/invalidation/...

Project Member Reported by skobes@chromium.org, Nov 3 2017

Issue description

The following 44 layout tests currently fail with RLS:

  paint/invalidation/caret-invalidation-in-overflow-scroll.html
  paint/invalidation/caret-subpixel.html
  paint/invalidation/caret-with-composited-scroll.html
  paint/invalidation/change-text-content-and-background-color.html
  paint/invalidation/composited-iframe-scroll-repaint.html
  paint/invalidation/compositing/composited-document-element.html
  paint/invalidation/details-open-repaint.html
  paint/invalidation/iframe-scroll-repaint.html
  paint/invalidation/invalidate-caret-in-composited-scrolling-container.html
  paint/invalidation/invalidate-caret-in-non-composited-scrolling-container.html
  paint/invalidation/media-audio-no-spurious-repaints.html
  paint/invalidation/multi-layout-one-frame.html
  paint/invalidation/overflow-scroll-body-appear.html
  paint/invalidation/positioned-document-element.html
  paint/invalidation/resize-iframe-text.html
  paint/invalidation/search-field-cancel.html
  paint/invalidation/selection-clear-after-move.html
  paint/invalidation/selection/selection-in-composited-scrolling-container.html
  paint/invalidation/subpixel-shadow-included-in-invalidation.html
  paint/invalidation/subtree-root-skipped.html
  paint/invalidation/svg/absolute-sized-document-no-scrollbars.svg
  paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html
  paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
  paint/invalidation/svg/feImage-target-add-to-document.svg
  paint/invalidation/svg/feImage-target-reappend-to-document.svg
  paint/invalidation/table-two-pass-layout-overpaint.html
  paint/invalidation/textarea-caret.html
  paint/invalidation/textarea-set-disabled.html
  paint/invalidation/viewport-gradient-background-html-resize.html
  paint/invalidation/window-resize-background-image-fixed-centered-composited.html
  paint/invalidation/window-resize-background-image-fixed-centered.html
  paint/invalidation/window-resize-background-image-generated.html
  paint/invalidation/window-resize-background-image-non-fixed.html
  paint/invalidation/window-resize-centered-inline-under-fixed-pos.html
  paint/invalidation/window-resize-frameset.html
  paint/invalidation/window-resize-media-query.html
  paint/invalidation/window-resize-no-layout-change1.html
  paint/invalidation/window-resize-no-layout-change2.html
  paint/invalidation/window-resize-percent-html.html
  paint/invalidation/window-resize-percent-width-height.html
  paint/invalidation/window-resize-positioned-bottom.html
  paint/invalidation/window-resize-positioned-percent-top.html
  paint/invalidation/window-resize-vertical-writing-mode.html
  paint/invalidation/window-resize-viewport-percent.html

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b3f41609b7536ea5366c9beaf8d9e234b05e07e

commit 5b3f41609b7536ea5366c9beaf8d9e234b05e07e
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Nov 06 17:39:05 2017

Fix typo in ShouldFullyInvalidateBackgroundOnLayoutOverflowChange

ShouldFullyInvalidateBackgroundOnLayoutOverflowChange had a typo
where only MustInvalidateFillLayersPaintOnHeightChange would be
checked instead of MustInvalidateFillLayersPaintOnWidthChange.
This was introduced in:
  https://crrev.com/a2907993ffbc7f8e21b2dce12c2ff5d541afca7e

Bug:  781419 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I1ab2e88a331546d15a9ddf85be07d5c441829068
Reviewed-on: https://chromium-review.googlesource.com/754180
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514164}
[modify] https://crrev.com/5b3f41609b7536ea5366c9beaf8d9e234b05e07e/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf3b94f3071bd3152fc865da5260095cd536bdd7

commit bf3b94f3071bd3152fc865da5260095cd536bdd7
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Nov 08 00:23:47 2017

[root layer scrolls] Rebaseline 4 passing tests

These tests just needed a simple invalidation type change. The
expectations for those invalidations now match non-rls:
paint/invalidation/svg/feImage-target-reappend-to-document.svg
paint/invalidation/svg/feImage-target-add-to-document.svg

These tests had rls-specific expectations that had an inner-editor
that is not present in the actual test. These now match non-rls:
paint/invalidation/textarea-set-disabled.html
paint/invalidation/textarea-caret.html

Bug:  781419 
Change-Id: I5133d34fff4e5b5324cc35b82c0b489746a118d7
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/757685
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#514667}
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/feImage-target-add-to-document-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/feImage-target-reappend-to-document-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/textarea-set-disabled-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/textarea-caret-expected.txt
[modify] https://crrev.com/bf3b94f3071bd3152fc865da5260095cd536bdd7/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/textarea-caret-expected.txt

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab2050f18161d7df3f0a47efdbb901435c5200f1

commit ab2050f18161d7df3f0a47efdbb901435c5200f1
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Nov 10 00:16:58 2017

[root layer scrolls] Rebaseline 9 passing tests

These tests had rls-specific expectations that had an inner-editor
that is not present in the actual test. These now match non-rls.

Bug:  781419 
Change-Id: If54b8ee00f1895c39c4c6ec90b012f88570a6d83
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/762096
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515360}
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/details-open-repaint-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.10/paint/invalidation/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.10/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.11/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/details-open-repaint-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-retina/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/caret-subpixel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/details-open-repaint-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/search-field-cancel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/caret-invalidation-in-overflow-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/caret-subpixel-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/caret-with-composited-scroll-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/details-open-repaint-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/invalidate-caret-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/invalidate-caret-in-non-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/multi-layout-one-frame-expected.txt
[modify] https://crrev.com/ab2050f18161d7df3f0a47efdbb901435c5200f1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/search-field-cancel-expected.txt

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73301afbf3cc353abe04cdab2527aa5ad0b9b45e

commit 73301afbf3cc353abe04cdab2527aa5ad0b9b45e
Author: Philip Rogers <pdr@chromium.org>
Date: Sat Nov 11 02:47:55 2017

[root layer scrolls] Rebaseline 4 passing tests

Rebaseline paint/invalidation/caret-ancestor-clip-change.html:
The non-RLS baseline was recently updated in:
https://chromium-review.googlesource.com/c/chromium/src/+/750041

This just needed a mac baseline update to match non-RLS:
paint/invalidation/change-text-content-and-background-color.html

Rebaseline paint/invalidation/flexbox/repaint-opacity-change.html:
The non-RLS baseline was recently updated in:
https://chromium-review.googlesource.com/c/chromium/src/+/760671

Rebaseline paint/invalidation/japanese-rl-selection-clear.html:
The non-RLS win10 baseline was recently updated in:
https://chromium-review.googlesource.com/c/chromium/src/+/685976

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I62935ad508fff623f0d6f3b685dabc0eaa72802e
Reviewed-on: https://chromium-review.googlesource.com/764599
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515809}
[modify] https://crrev.com/73301afbf3cc353abe04cdab2527aa5ad0b9b45e/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/73301afbf3cc353abe04cdab2527aa5ad0b9b45e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/caret-ancestor-clip-change-expected.txt
[modify] https://crrev.com/73301afbf3cc353abe04cdab2527aa5ad0b9b45e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/flexbox/repaint-opacity-change-expected.txt
[add] https://crrev.com/73301afbf3cc353abe04cdab2527aa5ad0b9b45e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/caret-ancestor-clip-change-expected.txt
[modify] https://crrev.com/73301afbf3cc353abe04cdab2527aa5ad0b9b45e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/change-text-content-and-background-color-expected.txt

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffa7914153c0d8c025f80708b1813cde68f49466

commit ffa7914153c0d8c025f80708b1813cde68f49466
Author: Philip Rogers <pdr@chromium.org>
Date: Sat Nov 11 03:01:02 2017

[root layer scrolls] Fix subpixel-shadow-included-in-invalidation.html

This test depends on invalidations on a specific layer. With root layer
scrolls enabled, the paint invalidations for this test are on the
scrolling contents layer which is not the first layer.

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I86d50174eb74c2481849752e4e506384d489c9b6
Reviewed-on: https://chromium-review.googlesource.com/764383
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515812}
[modify] https://crrev.com/ffa7914153c0d8c025f80708b1813cde68f49466/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/ffa7914153c0d8c025f80708b1813cde68f49466/third_party/WebKit/LayoutTests/paint/invalidation/subpixel-shadow-included-in-invalidation.html

Project Member

Comment 6 by bugdroid1@chromium.org, Nov 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c

commit ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c
Author: Philip Rogers <pdr@chromium.org>
Date: Sun Nov 12 16:50:47 2017

[root layer scrolls] Rebaseline 2 passing tests

These tests had rls-specific expectations that had an inner-editor
that is not present in the actual test. These now match non-rls.
This is a followup to [1] and should be the last of the
inner-editor baselines.

[1] https://chromium.googlesource.com/chromium/src/+/ab2050f18161d7df3f0a47efdbb901435c5200f1

Bug:  781419 
Change-Id: I54df3c50ca893aeebd581c72c3074c03a9f376e7
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/764440
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515867}
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/android/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.10/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.11/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.9/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-retina/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/subtree-root-skipped-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/selection/selection-in-composited-scrolling-container-expected.txt
[modify] https://crrev.com/ea1e6ed62ee1a0d8b790238a5ff54ca90a66497c/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/subtree-root-skipped-expected.txt

Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b85e62b2f4b37ed1e4903b06940c1085e04c2112

commit b85e62b2f4b37ed1e4903b06940c1085e04c2112
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Nov 13 17:09:20 2017

[root layer scrolls] Invalidate scrolling contents on size changes

This patch factors ViewPaintInvalidator into BoxPaintInvalidator
which reuses BoxPaintInvalidator's logic for invalidating the
scrolling contents layer. This fixes one root layer scrolling test.

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I62a84be195920a63e2db1207d4e329450eebeabf
Reviewed-on: https://chromium-review.googlesource.com/759738
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515969}
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/viewport-gradient-background-html-resize-expected.txt
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/Source/core/layout/LayoutView.h
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/Source/core/paint/BUILD.gn
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/b85e62b2f4b37ed1e4903b06940c1085e04c2112/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
[delete] https://crrev.com/6a4bf41e0952e2b7793ab06940b10ec0e601c28b/third_party/WebKit/Source/core/paint/ViewPaintInvalidator.cpp
[delete] https://crrev.com/6a4bf41e0952e2b7793ab06940b10ec0e601c28b/third_party/WebKit/Source/core/paint/ViewPaintInvalidator.h

Project Member

Comment 8 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/669001e747fa2124a044600bf8557424451be7d9

commit 669001e747fa2124a044600bf8557424451be7d9
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Nov 13 19:24:10 2017

[root layer scrolls] Fix 2 paint invalidation tests

The RLS baseline was wrong and we now match non-RLS except with
a scrolling content layer:
paint/invalidation/table-two-pass-layout-overpaint.html

This test was looking for paint invalidations on the root layer
but needed to use the scrolling contents layer with RLS:
paint/invalidation/media-audio-no-spurious-repaints.html

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Ia60a485552149da396d9847659835a9b06c338d3
Reviewed-on: https://chromium-review.googlesource.com/765569
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515999}
[modify] https://crrev.com/669001e747fa2124a044600bf8557424451be7d9/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/669001e747fa2124a044600bf8557424451be7d9/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table-two-pass-layout-overpaint-expected.txt
[modify] https://crrev.com/669001e747fa2124a044600bf8557424451be7d9/third_party/WebKit/LayoutTests/paint/invalidation/media-audio-no-spurious-repaints.html

Project Member

Comment 9 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3dfd0186983e030bf3f0d5bcc62230d14939514

commit d3dfd0186983e030bf3f0d5bcc62230d14939514
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Nov 14 18:03:40 2017

[root layer scrolls] Rebaseline 3 passing tests

These tests were all passing according to:
http://wince.sfo.corp.google.com:8766/rls

This test was recently rebaselined in
https://chromium-review.googlesource.com/c/chromium/src/+/742238
but was missing a windows expectation:
invalidation-rect-includes-newline-for-vertical-lr.html

These tests match the non-RLS expectations except they have additional
Scrolling Layer and Scrolling Contents Layers:
paint/invalidation/selection-clear-after-move.html
paint/invalidation/compositing/should-not-repaint-move-backface-hidden.html

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Ic70afc049f2095b92b5cf8179736dc552d06534b
Reviewed-on: https://chromium-review.googlesource.com/765015
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516352}
[modify] https://crrev.com/d3dfd0186983e030bf3f0d5bcc62230d14939514/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/d3dfd0186983e030bf3f0d5bcc62230d14939514/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/compositing/should-not-repaint-move-backface-hidden-expected.txt
[add] https://crrev.com/d3dfd0186983e030bf3f0d5bcc62230d14939514/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/selection/selection-clear-after-move-expected.txt
[add] https://crrev.com/d3dfd0186983e030bf3f0d5bcc62230d14939514/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/selection/invalidation-rect-includes-newline-for-vertical-lr-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2

commit 41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Nov 15 01:44:45 2017

[root layer scrolls] Invalidate on LayoutView style changes

The document element propagates styles to the LayoutView (see
Document::PropagateStyleToViewport) but the LayoutView was early-
outing before fully handling these style changes. In particular,
background color changes did not set
SetBackgroundChangedSinceLastPaintInvalidation.

It does not seem like this code needs to early-out when !parent.
This early-out was added in [1].

[1] https://chromium.googlesource.com/chromium/src/+/a5f6dc8469d54164bc957968cf1a5fde441e4f23

Bug:  781419 ,  777506 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I6a1e7d28e9dc082a1dac9ba6584ecf7c1efeb9bd
Reviewed-on: https://chromium-review.googlesource.com/768334
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516552}
[modify] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/background/background-image-paint-invalidation-expected.txt
[modify] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/relative-sized-document-scrollbars-expected.txt
[add] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/position/positioned-document-element-expected.txt
[add] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/position/positioned-document-element-expected.txt
[add] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/position/positioned-document-element-expected.txt
[modify] https://crrev.com/41ecce8b3fefc4d967b1ea183ffb3c67bc0f3ac2/third_party/WebKit/Source/core/layout/LayoutObject.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e

commit 3a664cc9ddcf5f4f78243e1a09a82dd21a47150e
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Nov 17 02:33:47 2017

[root layer scrolls] Use layout overflow for background invalidation

When the LayoutView uses a background from the document element, and
one of the background layers uses local geometry, a change in the
document element's layout overflow, not size, should invalidate the
background. Using ShouldFullyInvalidateBackgroundOnLayoutOverflowChange
generates invalidations on layout overflow location changes which is
new for the LayoutView and fixes an existing invalidation bug.

This patch adds an invalidation test where the layout overflow changes
but the size remains static. Before this patch, the test would crash
with root layer scrolling due to underinvalidation.

This patch also adds an invalidation test where the layout location
changes but the size remains static. Before this patch, the test would
fail with and without root layer scrolling.

The change in BoxPaintInvalidatorTest.NonCompositedLayoutViewGradientResize
from kBackground to kGeometry is not obvious. Before this change, the size
change was detected in ViewBackgroundShouldFullyInvalidate even though the
background did not need to be fully invalidated, which resulted in
kBackground. With this change, the background does not need an invalidation
and the size change is detected later in ComputePaintInvalidationReason
which results in kGeometry.

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I01cbc5cc173a51be8a998cd2e49b8b2fae915dc2
Reviewed-on: https://chromium-review.googlesource.com/770603
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517254}
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.png
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-move-overflow.html
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.png
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize-overflow.html
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/background/viewport-gradient-background-html-resize.html
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/background/viewport-gradient-background-html-move-overflow-expected.txt
[add] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/background/viewport-gradient-background-html-resize-overflow-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.h
[modify] https://crrev.com/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e/third_party/WebKit/Source/core/paint/BoxPaintInvalidatorTest.cpp

Project Member

Comment 12 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc645ca3adb300e03f222bb239aa9b40b35f0719

commit cc645ca3adb300e03f222bb239aa9b40b35f0719
Author: Philip Rogers <pdr@chromium.org>
Date: Sat Nov 18 00:40:08 2017

[root layer scrolls] Rebaseline 2 passing invalidation tests

Just needed a mac10.11-specific baseline (non-RLS also needs this):
paint/invalidation/background/change-text-content-and-background-color.html
The difference is:
-          "rect": [30, 30, 45, 23],
+          "rect": [30, 30, 44, 23

Just needed a fixed win10 baseline:
paint/invalidation/selection/japanese-rl-selection-clear.html
The difference is:
-          "rect": [230, 123, 542, 394],
+          "rect": [273, 123, 499, 394],

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Iff5add970393cc19e3f803ec738b2f7d09db8310
Reviewed-on: https://chromium-review.googlesource.com/777943
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517635}
[add] https://crrev.com/cc645ca3adb300e03f222bb239aa9b40b35f0719/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac-mac10.11/paint/invalidation/background/change-text-content-and-background-color-expected.txt
[modify] https://crrev.com/cc645ca3adb300e03f222bb239aa9b40b35f0719/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/selection/japanese-rl-selection-clear-expected.txt

Project Member

Comment 13 by bugdroid1@chromium.org, Nov 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce

commit dd344698dd5b4e21766c1067c9b0e7f34d04a7ce
Author: Philip Rogers <pdr@chromium.org>
Date: Sat Nov 18 01:05:30 2017

[root layer scrolls] Rebaseline 14 invalidation resize tests

These root layer scrolling expectations are now correct.
paint/invalidation/window-resize/window-resize-frameset.html
paint/invalidation/window-resize/window-resize-viewport-percent.html
paint/invalidation/window-resize/window-resize-positioned-percent-top.html
paint/invalidation/window-resize/window-resize-positioned-bottom.html
paint/invalidation/window-resize/window-resize-percent-width-height.html
paint/invalidation/window-resize/window-resize-percent-html.html
paint/invalidation/window-resize/window-resize-no-layout-change2.html
paint/invalidation/window-resize/window-resize-no-layout-change1.html
paint/invalidation/window-resize/window-resize-media-query.html
paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos.html
paint/invalidation/window-resize/window-resize-background-image-non-fixed.html
paint/invalidation/window-resize/window-resize-background-image-generated.html
paint/invalidation/window-resize/window-resize-background-image-fixed-centered-composited.html
paint/invalidation/window-resize/window-resize-background-image-fixed-centered.html

window-resize-vertical-writing-mode.html has not been rebaselined
because it fails for underinvalidation and needs to be fixed.

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: If96694875991c95895deeca322c1e5b20612d5c2
Reviewed-on: https://chromium-review.googlesource.com/777482
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517652}
[modify] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-background-image-fixed-centered-composited-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-background-image-fixed-centered-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-background-image-generated-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-background-image-non-fixed-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-centered-inline-under-fixed-pos-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-frameset-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-media-query-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-no-layout-change1-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-no-layout-change2-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-percent-html-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-percent-width-height-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-positioned-bottom-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-positioned-percent-top-expected.txt
[add] https://crrev.com/dd344698dd5b4e21766c1067c9b0e7f34d04a7ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/window-resize/window-resize-viewport-percent-expected.txt

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb99b4ebb0e2836e856746a5829fe5cec2d50d5

commit 8eb99b4ebb0e2836e856746a5829fe5cec2d50d5
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Nov 20 21:11:06 2017

[root layer scrolls] Relayout after scrollbars change

Without root layer scrolling (RLS), the LayoutView is laid out a second
time after scrollbars change in LocalFrameView's ScrollbarExistenceMaybeChanged.
With root layer scrolling we instead do a nested layout through
PaintLayerScrollableArea's UpdateAfterLayout. Before this patch, the nested
layout for root layer scrolling did not invalidate SVG after the widths changed.

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I7c4d30172f11527f6105251a849c7eb0377ce4d8
Reviewed-on: https://chromium-review.googlesource.com/775544
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517927}
[modify] https://crrev.com/8eb99b4ebb0e2836e856746a5829fe5cec2d50d5/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/8eb99b4ebb0e2836e856746a5829fe5cec2d50d5/third_party/WebKit/Source/core/layout/LayoutBlock.cpp
[modify] https://crrev.com/8eb99b4ebb0e2836e856746a5829fe5cec2d50d5/third_party/WebKit/Source/core/layout/LayoutView.cpp
[modify] https://crrev.com/8eb99b4ebb0e2836e856746a5829fe5cec2d50d5/third_party/WebKit/Source/core/layout/LayoutView.h

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149eed97cbbf8fb71c7e3e236ec76f521119d26b

commit 149eed97cbbf8fb71c7e3e236ec76f521119d26b
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Nov 21 20:08:21 2017

[root layer scrolls] Update expectations

paint/invalidation/svg/js-update-stop-linked-gradient.svg:
This test was recently updated which removed gradient stops:
https://chromium.googlesource.com/chromium/src/+/e3276a9902608cd3930d2a1dad67d56b5ae98313
This patch updates the RLS expectation too.

http/tests/devtools/agents-enable-disable.js (and virtual variant):
This test is crashing on all platforms but the expectation was marked as
timeout on just mac.

plugins/mouse-events-fixedpos.html:
This test is crashing flakily (see:  https://crbug.com/786117 ).

To make it easier to update the expectations file, a new section for
flaky tests has been added.

Bug:  781419 ,  786117 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: Iba1f45b03a1ac2093c48a2cfcabf70c6f93a9d4d
Reviewed-on: https://chromium-review.googlesource.com/779760
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518353}
[modify] https://crrev.com/149eed97cbbf8fb71c7e3e236ec76f521119d26b/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/149eed97cbbf8fb71c7e3e236ec76f521119d26b/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-stop-linked-gradient-expected.txt

Project Member

Comment 16 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bbcd68d9408c47c2a8e378b0b8d274d2e8c28042

commit bbcd68d9408c47c2a8e378b0b8d274d2e8c28042
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Nov 21 22:44:09 2017

[root layer scrolls] re-rebaseline japanese-rl-selection-clear.html

This patch fixes a bug in where japanese-rl-selection-clear.html
was rebaselined incorrectly:
https://chromium.googlesource.com/chromium/src/+/cc645ca3adb300e03f222bb239aa9b40b35f0719

Bug:  781419 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I6c35947c11e912da420f217f6b0c71b568bb324e
Reviewed-on: https://chromium-review.googlesource.com/783652
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518420}
[modify] https://crrev.com/bbcd68d9408c47c2a8e378b0b8d274d2e8c28042/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/selection/japanese-rl-selection-clear-expected.txt

Comment 17 by pdr@chromium.org, Nov 22 2017

Blockedon: 787666
Project Member

Comment 18 by bugdroid1@chromium.org, Nov 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8343353bd2d776f81d028531400101060a9630b4

commit 8343353bd2d776f81d028531400101060a9630b4
Author: Philip Rogers <pdr@chromium.org>
Date: Thu Nov 23 06:06:54 2017

Do not invalidate solid color backgrounds on location changes

[1] introduced a perf regression because it caused background
invalidations whenever the layout overflow's location changed.
This is needed for cases such as gradients, but is not needed in
the common case of solid color backgrounds.

This patch adds logic to not invalidate backgrounds on location
changes when the background is solid color and fully covers the
layout overflow area. This required extracting the incremental
invalidation logic out of ShouldFullyInvalidateBackgroundOnLayoutOverflowChange
so the function now returns true for background changes only.

This restores the following tests to their baselines before [1]:
paint/invalidation/overflow/justify-items-overflow-change.html
paint/invalidation/overflow/justify-self-overflow-change.html
paint/invalidation/position/transform-absolute-child.html
paint/invalidation/transform/transform-rotate-and-remove.html
paint/invalidation/offset-change-wrong-invalidation-with-float.html

[1] https://chromium.googlesource.com/chromium/src/+/3a664cc9ddcf5f4f78243e1a09a82dd21a47150e

Bug:  781419 ,  787178 

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I875f83a3f0d126af97f8d389d982f5f613737170
Reviewed-on: https://chromium-review.googlesource.com/786149
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518863}
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/paint/invalidation/position/transform-absolute-child-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/offset-change-wrong-invalidation-with-float-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/overflow/justify-items-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/overflow/justify-self-overflow-change-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/LayoutTests/virtual/spv175/paint/invalidation/transform/transform-rotate-and-remove-expected.txt
[modify] https://crrev.com/8343353bd2d776f81d028531400101060a9630b4/third_party/WebKit/Source/core/paint/BoxPaintInvalidator.cpp

Project Member

Comment 19 by bugdroid1@chromium.org, Nov 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/357023510a19423ea8c162b3bdd7c025f11a27e6

commit 357023510a19423ea8c162b3bdd7c025f11a27e6
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Nov 24 20:32:41 2017

[root layer scrolls] Rebaseline svg invalidation tests

The following tests were updated in [1] and need RLS updates:
paint/invalidation/svg/hairline-stroke-squarecap.svg
paint/invalidation/svg/js-late-marker-and-object-creation.svg
paint/invalidation/svg/js-late-marker-creation.svg
paint/invalidation/svg/js-repaint-rect-on-path-with-stroke.svg
paint/invalidation/svg/js-update-polygon-changes.svg
paint/invalidation/svg/js-update-polygon-removal.svg
paint/invalidation/svg/js-update-transform-addition.svg
paint/invalidation/svg/js-update-transform-changes.svg
paint/invalidation/svg/marker-child-changes-css.svg
paint/invalidation/svg/marker-child-changes.svg
paint/invalidation/svg/marker-strokeWidth-changes.svg
paint/invalidation/svg/marker-viewBox-changes.svg
paint/invalidation/svg/paintorder-filtered.svg
paint/invalidation/svg/path-pathlength-change.html
paint/invalidation/svg/repaint-paintorder.svg
paint/invalidation/svg/tabgroup.svg
paint/invalidation/svg/window.svg

[1] https://chromium.googlesource.com/chromium/src/+/e9bd34c60d38b0b5bcee52a6cd475b9124974aab

Bug:  781419 
Change-Id: I82721b8fc8f912edc81be194203b971eb8efa13c
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/789370
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519157}
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/hairline-stroke-squarecap-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-marker-creation-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-repaint-rect-on-path-with-stroke-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-polygon-changes-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-polygon-removal-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-transform-addition-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-transform-changes-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-child-changes-css-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-child-changes-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-strokeWidth-changes-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-viewBox-changes-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/paintorder-filtered-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/path-pathlength-change-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/repaint-paintorder-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/window-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/tabgroup-expected.txt
[modify] https://crrev.com/357023510a19423ea8c162b3bdd7c025f11a27e6/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/window-expected.txt

Project Member

Comment 20 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c8d9594e89897263e41dc512631d5bbe469d8fe

commit 2c8d9594e89897263e41dc512631d5bbe469d8fe
Author: Philip Rogers <pdr@chromium.org>
Date: Mon Nov 27 22:09:23 2017

[root layer scrolls] Cleanup composited-iframe-scroll-repaint-iframe.html

paint/invalidation/composited-iframe-scroll-repaint-iframe.html was
added in [1] as a test of composited iframe scrolling and used an
overflow: hidden scroller. With Root Layer Scrolling (RLS),
overflow: hidden no longer composites (see discussion in
 https://crbug.com/784053 ) so this test does not work.

This patch updates the test to use overflow: scroll and adds a style
for hiding the scrollbars. There is no change in behavior for the
non-RLS codepath, but with this change the test now works for RLS.

[1] https://chromium.googlesource.com/chromium/src/+/64135db5fe189001e230a40b97572c1a59b2c157

Bug:  781419 
Change-Id: I8d988919f49155f11b84c76cb5854e88d6b9d012
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/789492
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519423}
[modify] https://crrev.com/2c8d9594e89897263e41dc512631d5bbe469d8fe/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/2c8d9594e89897263e41dc512631d5bbe469d8fe/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/composited-iframe-scroll-repaint-expected.txt
[modify] https://crrev.com/2c8d9594e89897263e41dc512631d5bbe469d8fe/third_party/WebKit/LayoutTests/paint/invalidation/resources/composited-iframe-scroll-repaint-iframe.html

Comment 21 by pdr@chromium.org, Nov 28 2017

Blockedon: 789184
Project Member

Comment 22 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a5919139d729cc1da52b7f510a067e1d6a1263f

commit 5a5919139d729cc1da52b7f510a067e1d6a1263f
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Nov 29 19:20:32 2017

[PE] Remove extra iframe invalidation on slow scrolls

LocalFrameView::ScrollContentsSlowPath had an invalidation for
iframes but this invalidation was already handled will full
invalidation. This patch removes this extra invalidation.

This makes the root layer scrolling (RLS) and non-RLS
expectations match because this extra invalidation was not
issued for RLS.

Bug:  781419 
Change-Id: I2e6bf51682e24b2e2dfa8b56abffa7665ab2bcf4
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/795183
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520191}
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/LayoutTests/paint/invalidation/scroll/iframe-scroll-repaint-expected.txt
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/LayoutTests/platform/win/paint/invalidation/scroll/repaint-during-scroll-with-zoom-expected.txt
[modify] https://crrev.com/5a5919139d729cc1da52b7f510a067e1d6a1263f/third_party/WebKit/Source/core/frame/LocalFrameView.cpp

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21daba15ee6ae7578455e2029eb6f3ea103460ce

commit 21daba15ee6ae7578455e2029eb6f3ea103460ce
Author: Philip Rogers <pdr@chromium.org>
Date: Fri Dec 01 17:11:13 2017

[root layer scrolls] Rebaseline 6 paint invalidation tests

This patch rebaselines the following paint invalidation tests:
paint/invalidation/resize-iframe-text.html
paint/invalidation/scroll/overflow-scroll-body-appear.html
paint/invalidation/svg/absolute-sized-document-no-scrollbars.svg
paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1.html
paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2.html
paint/invalidation/svg/window.svg

Bug:  781419 
Change-Id: I1fc2a3cf849d6aef28f5cd58de062f563a51edab
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/797616
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520969}
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt
[add] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt
[add] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/scroll/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/svg/window-expected.txt
[add] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/scroll/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/window-expected.txt
[add] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/resize-iframe-text-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/scroll/overflow-scroll-body-appear-expected.txt
[modify] https://crrev.com/21daba15ee6ae7578455e2029eb6f3ea103460ce/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/window-expected.txt

Owner: chrishtr@chromium.org
Status: Fixed (was: Assigned)
Blockedon: -787666

Sign in to add a comment